From: Joel Selvaraj <joelselvaraj.oss@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Caleb Connolly <caleb@connolly.tech>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Henrik Rydberg <rydberg@bitmath.org>,
Arnd Bergmann <arnd@arndb.de>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Jeff LaBundy <jeff@labundy.com>,
Markuss Broks <markuss.broks@gmail.com>,
Jean Delvare <jdelvare@suse.de>, Job Noorman <job@noorman.info>,
Alistair Francis <alistair@alistair23.me>,
Chris Morgan <macromorgan@hotmail.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [PATCH v2 1/5] dt-bindings: input: touchscreen: add bindings for focaltech,fts5452
Date: Thu, 13 Apr 2023 19:32:40 -0500 [thread overview]
Message-ID: <b89c39af-da87-8138-9899-fb631ebe76e1@gmail.com> (raw)
In-Reply-To: <f9552bb6-ea73-93b4-f15d-d5d7c326c708@linaro.org>
Hi Krzysztof Kozlowski,
Konrad Dybcio suggested to use interrupts-extended instead interrupts.
So in my WIP v3, I have updated it in the dts and bindings example.
However, I am confused if I should replace the "interrupts" with
"interrupts-extended" property in the schema too? I see a lot of schemas
specifying "interrupts", with examples using "interrupts" or
"interrupts-extended". At the same time, I see some specifying both
"interrupts" and "interrupts-extended" (like one of these two) and very
few others specify only "interrupts-extended" in the schema. Which is
the currently recommended way to do this?
In between, the interrupt property should be a required property as the
driver will not function without an interrupt. I will fix that in v3.
Thanks,
Joel Selvaraj
next prev parent reply other threads:[~2023-04-14 0:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 16:01 [PATCH v2 0/5] Add support for Focaltech FTS Touchscreen Joel Selvaraj
2023-04-10 16:01 ` [PATCH v2 1/5] dt-bindings: input: touchscreen: add bindings for focaltech,fts5452 Joel Selvaraj
2023-04-11 5:55 ` Krzysztof Kozlowski
2023-04-14 0:32 ` Joel Selvaraj [this message]
2023-04-14 7:44 ` Krzysztof Kozlowski
2023-04-10 16:01 ` [PATCH v2 2/5] Input: add driver for Focaltech FTS touchscreen Joel Selvaraj
2023-04-10 16:01 ` [PATCH v2 3/5] arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes Joel Selvaraj
2023-04-11 5:56 ` Krzysztof Kozlowski
2023-04-10 16:01 ` [PATCH v2 4/5] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce support for fts touchscreen Joel Selvaraj
2023-04-11 19:58 ` Konrad Dybcio
2023-04-10 16:02 ` [PATCH v2 5/5] arm64: dts: qcom: sdm845-shift-axolotl: update focaltech touchscreen properties Joel Selvaraj
2023-04-11 19:59 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b89c39af-da87-8138-9899-fb631ebe76e1@gmail.com \
--to=joelselvaraj.oss@gmail.com \
--cc=agross@kernel.org \
--cc=alistair@alistair23.me \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=caleb@connolly.tech \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.de \
--cc=jeff@labundy.com \
--cc=job@noorman.info \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=markuss.broks@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox