Re: [PATCH v3 1/4] ARM: dts: qcom: msm8960: expressatt: Sort node references and includes

Rudraksha Gupta
2026-04-07T20:39:57Z

On 4/7/26 12:59, Krzysztof Kozlowski wrote:
> On 01/04/2026 22:32, Rudraksha Gupta via B4 Relay wrote:
>> From: Rudraksha Gupta <guptarud@gmail.com>
>>
>> Reorganize the DTS file for consistency with other msm8960 board files.
>>
>> Assisted-by: Claude:claude-opus-4.6
>> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
>> ---
>> .../dts/qcom/qcom-msm8960-samsung-expressatt.dts | 408 +++++++++++----------
>> 1 file changed, 207 insertions(+), 201 deletions(-)
>>
> Sorry, but no. We are not taking Claude as one determining coding style.
> Are we going to do the work again the moment we come with proper tool?

There is no tool currently to auto format DTS, and doesn't seem to be
coming for a while:

https://www.youtube.com/watch?v=cvoIbTL_ZQA

Claude didn't determine the coding style. I did based on sony-huashan,
which is already upstream:

https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/qcom/qcom-msm8960-sony-huashan.dts

I just used Claude to do the manual work for me. In v2, I made sure the
diff before and after the change was nill. v3 included additional
changes requested by Konrad and some comments that I remembered during
prior attempts mainlining patch series for this device.

>
> Same comment as usually - this is highly invasive change which should be
> done with dts linter, not LLM, not manually.
>
> Best regards,
> Krzysztof