From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Xu Wang <vulab@iscas.ac.cn>,
robdclark@gmail.com, sean@poorly.run, airlied@linux.ie,
daniel@ffwll.ch, jcrouse@codeaurora.org, tzimmermann@suse.de,
abhinavk@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/msm/mdp5: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare
Date: Sat, 2 Oct 2021 22:48:45 +0300 [thread overview]
Message-ID: <b8e7ca23-b8aa-18ef-c4a9-2fcaec0f52f6@linaro.org> (raw)
In-Reply-To: <20201231094935.25737-1-vulab@iscas.ac.cn>
On 31/12/2020 12:49, Xu Wang wrote:
> Because clk_prepare_enable() and clk_disable_unprepare() already checked
> NULL clock parameter, so the additional checks are unnecessary, just
> remove them.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 18 ++++++------------
> drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c | 12 ++++--------
> 2 files changed, 10 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> index 15aed45022bc..8d373d2ffd51 100644
> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> @@ -303,15 +303,12 @@ static int mdp5_disable(struct mdp5_kms *mdp5_kms)
> mdp5_kms->enable_count--;
> WARN_ON(mdp5_kms->enable_count < 0);
>
> - if (mdp5_kms->tbu_rt_clk)
> - clk_disable_unprepare(mdp5_kms->tbu_rt_clk);
> - if (mdp5_kms->tbu_clk)
> - clk_disable_unprepare(mdp5_kms->tbu_clk);
> + clk_disable_unprepare(mdp5_kms->tbu_rt_clk);
> + clk_disable_unprepare(mdp5_kms->tbu_clk);
> clk_disable_unprepare(mdp5_kms->ahb_clk);
> clk_disable_unprepare(mdp5_kms->axi_clk);
> clk_disable_unprepare(mdp5_kms->core_clk);
> - if (mdp5_kms->lut_clk)
> - clk_disable_unprepare(mdp5_kms->lut_clk);
> + clk_disable_unprepare(mdp5_kms->lut_clk);
>
> return 0;
> }
> @@ -325,12 +322,9 @@ static int mdp5_enable(struct mdp5_kms *mdp5_kms)
> clk_prepare_enable(mdp5_kms->ahb_clk);
> clk_prepare_enable(mdp5_kms->axi_clk);
> clk_prepare_enable(mdp5_kms->core_clk);
> - if (mdp5_kms->lut_clk)
> - clk_prepare_enable(mdp5_kms->lut_clk);
> - if (mdp5_kms->tbu_clk)
> - clk_prepare_enable(mdp5_kms->tbu_clk);
> - if (mdp5_kms->tbu_rt_clk)
> - clk_prepare_enable(mdp5_kms->tbu_rt_clk);
> + clk_prepare_enable(mdp5_kms->lut_clk);
> + clk_prepare_enable(mdp5_kms->tbu_clk);
> + clk_prepare_enable(mdp5_kms->tbu_rt_clk);
>
> return 0;
> }
> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c
> index 09bd46ad820b..02c6c4b68c68 100644
> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c
> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c
> @@ -137,10 +137,8 @@ static int mdp5_mdss_enable(struct msm_mdss *mdss)
> DBG("");
>
> clk_prepare_enable(mdp5_mdss->ahb_clk);
> - if (mdp5_mdss->axi_clk)
> - clk_prepare_enable(mdp5_mdss->axi_clk);
> - if (mdp5_mdss->vsync_clk)
> - clk_prepare_enable(mdp5_mdss->vsync_clk);
> + clk_prepare_enable(mdp5_mdss->axi_clk);
> + clk_prepare_enable(mdp5_mdss->vsync_clk);
>
> return 0;
> }
> @@ -150,10 +148,8 @@ static int mdp5_mdss_disable(struct msm_mdss *mdss)
> struct mdp5_mdss *mdp5_mdss = to_mdp5_mdss(mdss);
> DBG("");
>
> - if (mdp5_mdss->vsync_clk)
> - clk_disable_unprepare(mdp5_mdss->vsync_clk);
> - if (mdp5_mdss->axi_clk)
> - clk_disable_unprepare(mdp5_mdss->axi_clk);
> + clk_disable_unprepare(mdp5_mdss->vsync_clk);
> + clk_disable_unprepare(mdp5_mdss->axi_clk);
> clk_disable_unprepare(mdp5_mdss->ahb_clk);
>
> return 0;
>
--
With best wishes
Dmitry
prev parent reply other threads:[~2021-10-02 19:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 9:49 [PATCH] drm/msm/mdp5: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare Xu Wang
2021-10-02 19:48 ` Dmitry Baryshkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8e7ca23-b8aa-18ef-c4a9-2fcaec0f52f6@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox