public inbox for linux-arm-msm@vger.kernel.org
 help / color / mirror / Atom feed
From: Hemant Kumar <hemantk@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>, manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mhi: unconstify mhi_event_config
Date: Tue, 5 Jan 2021 18:28:37 -0800	[thread overview]
Message-ID: <b8f16e9d-0d95-0122-12f6-2565d777e707@codeaurora.org> (raw)
In-Reply-To: <1609865076-13890-1-git-send-email-loic.poulain@linaro.org>

Hi Loic

On 1/5/21 8:44 AM, Loic Poulain wrote:
> Some parameters may have to be determined at runtime.
> It is the case for the event ring MSI vector.
> 
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>   v2: no change
> 
>   include/linux/mhi.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 62da830..48b1b2a 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -290,7 +290,7 @@ struct mhi_controller_config {
>   	u32 num_channels;
>   	const struct mhi_channel_config *ch_cfg;
>   	u32 num_events;
> -	const struct mhi_event_config *event_cfg;
> +	struct mhi_event_config *event_cfg;
commented on previous patch set, copying my comment here
Do we need to update mhi controller driver like ath11k and generic pci 
driver to avoid compiler warnings?
>   	bool use_bounce_buf;
>   	bool m2_no_db;
>   };
> 

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

  parent reply	other threads:[~2021-01-06  2:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 16:44 [PATCH v2 1/2] mhi: unconstify mhi_event_config Loic Poulain
2021-01-05 16:44 ` [PATCH v2 2/2] mhi: pci_generic: Fix shared MSI vector support Loic Poulain
2021-01-06  2:14   ` Hemant Kumar
2021-01-06 13:20   ` Manivannan Sadhasivam
2021-01-06  2:28 ` Hemant Kumar [this message]
     [not found]   ` <CAMZdPi-m9WopviGqH+9XJdg7oi0wA4ASLkyXcqcBqrJdY_Oq8w@mail.gmail.com>
2021-01-06 13:16     ` [PATCH v2 1/2] mhi: unconstify mhi_event_config Manivannan Sadhasivam
2021-01-06 13:20 ` Manivannan Sadhasivam
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8f16e9d-0d95-0122-12f6-2565d777e707@codeaurora.org \
    --to=hemantk@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=manivannan.sadhasivam@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox