From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To: Stephen Boyd <sboyd@kernel.org>, Andy Gross <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <quic_ppratap@quicinc.com>,
<quic_jackp@quicinc.com>,
Udipto Goswami <quic_ugoswami@quicinc.com>
Subject: Re: [RFC 4/8] clk: qcom: gcc-sm8450: Keep usb30 prim gdsc on during runtime suspend
Date: Thu, 19 Oct 2023 14:07:20 +0530 [thread overview]
Message-ID: <b8fa17a7-296e-4e17-9438-a8be04dbd476@quicinc.com> (raw)
In-Reply-To: <e38ae24c09ef321c224a6b6aeb97e73b.sboyd@kernel.org>
On 10/19/2023 6:28 AM, Stephen Boyd wrote:
> Quoting Krishna Kurapati (2023-10-17 06:19:44)
>> When runtime suspend happens in host mode, if cable is removed at this
>> instant, it triggers a resume where a xhci register access is done when
>> gdsc is not on leading to a crash. Keep usb30 prim gdsc as on during
>> runtime suspend to avoid this crash.
>>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>> ---
>> Note: I am not sure if this is the right way or setting GDSC flags to
>> PWRSTS_RET_ON is the right approach. So for now made this change to
>
> Does using PWRSTS_RET_ON work? Does the GDSC support being turned off or
> is the lowest power state retention?
I didn't see any issue when I put it as PWRSTS_RET_ON. If the GDSC is
off, when we remove cable in host mode, we see a crash because of xhci
register access. But when I try putting PWRSTS_RET_ON /
CLK_RPM_ALWAYS_ON it doesn't crash.
Regard,
Krishna,
next prev parent reply other threads:[~2023-10-19 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 13:19 [RFC 4/8] clk: qcom: gcc-sm8450: Keep usb30 prim gdsc on during runtime suspend Krishna Kurapati
2023-10-19 0:58 ` Stephen Boyd
2023-10-19 8:37 ` Krishna Kurapati PSSNV [this message]
2023-10-20 0:05 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8fa17a7-296e-4e17-9438-a8be04dbd476@quicinc.com \
--to=quic_kriskura@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_ugoswami@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox