From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/11] arm64: dts: qcom: msm8998: Remove AGGRE2 clock from SLPI
Date: Sat, 12 Aug 2023 13:46:33 +0200 [thread overview]
Message-ID: <b93bd745-fd93-4317-a16b-1aa05a34d60d@linaro.org> (raw)
In-Reply-To: <43afe706-5765-a8e7-2bbe-d9b21ec7a06e@quicinc.com>
On 21.07.2023 17:50, Jeffrey Hugo wrote:
> On 7/21/2023 9:36 AM, Konrad Dybcio wrote:
>> The AGGRE2 clock is a clock for the entire AGGRE2 bus, managed from
>> within the interconnect driver. Attaching it to SLPI was a total hack.
>> Get rid of it.
>
> Nit - why do we care what driver manages the clock? DT describes hardware...
>
> The entire SLPI block hangs off the AGGRE2 bus, so that bus needs to be on for the SLPI. I agree that AGGRE2 is really an interconnect device and SLPI should be a consumer of that, but we don't have 8998 interconnects defined yet. Seems like this hack is still needed.
As we concluded in private, this has no effect as the clk-smd-rpm driver
leaves that clock dangling at FMAX anyway
Konrad
next prev parent reply other threads:[~2023-08-12 11:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 15:36 [PATCH 00/11] Clean up RPM bus clocks remnants Konrad Dybcio
2023-07-21 15:36 ` [PATCH 01/11] arm64: dts: qcom: msm8916: Drop RPM bus clocks Konrad Dybcio
2023-07-21 15:36 ` [PATCH 02/11] arm64: dts: qcom: msm8996: " Konrad Dybcio
2023-07-21 15:36 ` [PATCH 03/11] arm64: dts: qcom: qcs404: " Konrad Dybcio
2023-07-21 15:36 ` [PATCH 04/11] arm64: dts: qcom: sdm630: " Konrad Dybcio
2023-07-23 14:08 ` Krzysztof Kozlowski
2023-08-26 11:55 ` Konrad Dybcio
2023-07-21 15:36 ` [PATCH 05/11] arm64: dts: qcom: msm8939: " Konrad Dybcio
2023-07-21 15:36 ` [PATCH 06/11] dt-bindings: remoteproc: qcom,adsp: Remove AGGRE2 clock Konrad Dybcio
2023-07-23 9:33 ` Krzysztof Kozlowski
2023-07-21 15:36 ` [PATCH 07/11] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Remove PNoC clock Konrad Dybcio
2023-07-23 9:34 ` Krzysztof Kozlowski
2023-07-21 15:36 ` [PATCH 08/11] remoteproc: qcom: q6v5-mss: Remove PNoC clock from 8996 MSS Konrad Dybcio
2023-07-21 15:36 ` [PATCH 09/11] arm64: dts: qcom: msm8998: Remove AGGRE2 clock from SLPI Konrad Dybcio
2023-07-21 15:50 ` Jeffrey Hugo
2023-07-26 15:48 ` Konrad Dybcio
2023-08-12 11:46 ` Konrad Dybcio [this message]
2023-07-21 15:36 ` [PATCH 10/11] arm64: dts: qcom: msm8996: " Konrad Dybcio
2023-07-21 15:36 ` [PATCH 11/11] arm64: dts: qcom: msm8996: Remove PNoC clock from MSS Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b93bd745-fd93-4317-a16b-1aa05a34d60d@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_jhugo@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).