From: Bryan O'Donoghue <pure.logic@nexus-software.ie>
To: Viken Dadhaniya <quic_vdadhani@quicinc.com>,
andersson@kernel.org, konrad.dybcio@linaro.org,
andi.shyti@kernel.org, linux-arm-msm@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
vkoul@kernel.org, quic_bjorande@quicinc.com,
manivannan.sadhasivam@linaro.org
Cc: quic_msavaliy@quicinc.com, quic_vtanuku@quicinc.com
Subject: Re: [V2] i2c: i2c-qcom-geni: Correct I2C TRE sequence
Date: Tue, 30 Jan 2024 15:24:06 +0000 [thread overview]
Message-ID: <b94c4c9f-a3dd-40fb-a80e-569199e93ee2@nexus-software.ie> (raw)
In-Reply-To: <20240129061003.4085-1-quic_vdadhani@quicinc.com>
On 29/01/2024 06:10, Viken Dadhaniya wrote:
> As per HPG(Hardware programming guide
Since you are doing a V3 here, please amend this too.
"As per HPG" means almost nothing outside of qcom.
"As per Qualcomm's internal Hardware Programming Guide"
Right thing to do to reference the document IMO but, you should make
clear its an internal silicon specification that's not public.
Also not sure the TRE description adds much.
Just give a high level description of the sequences being out-of-order
with respect to the hardware spec.
---
bod
next prev parent reply other threads:[~2024-01-30 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 6:10 [V2] i2c: i2c-qcom-geni: Correct I2C TRE sequence Viken Dadhaniya
2024-01-29 23:24 ` Andi Shyti
2024-01-30 11:32 ` Bryan O'Donoghue
2024-02-01 10:17 ` Viken Dadhaniya
2024-01-29 23:49 ` Dmitry Baryshkov
2024-01-30 9:42 ` Andi Shyti
2024-02-01 10:21 ` Viken Dadhaniya
2024-02-01 10:19 ` Viken Dadhaniya
2024-01-30 15:24 ` Bryan O'Donoghue [this message]
2024-02-01 10:23 ` Viken Dadhaniya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b94c4c9f-a3dd-40fb-a80e-569199e93ee2@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=quic_vtanuku@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).