Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Daniel Carter <yass27106@gmail.com>
To: vkoul@kernel.org
Cc: srinivas.kandagatla@oss.qualcomm.com, andersson@kernel.org,
	linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, yass27106@gmail.com
Subject: Re: [PATCH v5 3/3] soundwire: qcom: check clk_prepare_enable() return values
Date: Sun, 22 Nov 2026 07:41:06 -0800 (PST)	[thread overview]
Message-ID: <b9a72d2ad40d4a8087acef99a7bd2fc8@gmail.com> (raw)
In-Reply-To: <c15d3417cda640aebc7bebff76b0448e@gmail.com>

Hi Vinod,

A friendly ping on this one - it already has Srini's Reviewed-by and carries
Fixes: tags plus Cc: stable.

One rebase note: the patch was written against v7.4-rc2, and your fixes
branch has since gained "soundwire: qcom: disable the interrupt before
gating the clock", which shifts the runtime-resume hunk. I verified it
applies cleanly on top of your fixes branch (apply + build + checkpatch
clean), with the error path still returning before enable_irq():

	-	clk_prepare_enable(ctrl->hclk);
	+	ret = clk_prepare_enable(ctrl->hclk);
	+	if (ret)
	+		return ret;
	+
	 	enable_irq(ctrl->irq);

If you would like it for the current -rc cycle, I can resend it rebased on
soundwire/fixes; otherwise it can wait for the next merge window. Either
way, let me know if you want anything changed.

Best regards,
Daniel Carter

  reply	other threads:[~2026-11-22 15:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 20:55 [PATCH v5 0/3] arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA Daniel Carter
2026-11-16 20:55 ` [PATCH v5 1/3] dt-bindings: arm: qcom: document " Daniel Carter
2026-11-16 20:55   ` [PATCH v5 2/3] arm64: dts: qcom: add device tree for " Daniel Carter
2026-11-16 20:55     ` [PATCH v5 3/3] soundwire: qcom: check clk_prepare_enable() return values Daniel Carter
2026-11-22 15:41       ` Daniel Carter [this message]
     [not found]     ` <sashiko-outbox-217692@kernel.org>
2026-11-22 10:14       ` [PATCH v5 2/3] arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA Daniel Carter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9a72d2ad40d4a8087acef99a7bd2fc8@gmail.com \
    --to=yass27106@gmail.com \
    --cc=andersson@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox