From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 193EC193070 for ; Thu, 7 Nov 2024 12:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730982416; cv=none; b=FAdvVTh2vvgu9ly3lITbI8IHOQ+jhFSpruKz8U428N1KROCaAmROhINgfNs+z2H0jnqoCODltSTXjlkjtE2/gwEjHVBq7nbfCGqhF48bkFHPvYSK8g/dy94L13RBhBhtFGHr3tsM93MVgvJThsOd8ggepz50pOz9HyYErHqAzWQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730982416; c=relaxed/simple; bh=WVMN927o4qkeYTXILdzvcIvO1X/LpqgECegr3MVyyb8=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=JZqHfbwEFRoX+fGwP0IbIhswCINQbalBYUuF1lrFGKOYcxU2GpCkbrIkC3XxCZQUuJL8R/5BIYv3wBFeD5P/Z4R3UlTu6FsUmBEdLdqNhgS+LN3sYKp3L0Q2RR2gXtKjBit73qBi4S6PV9pFQEafwkKjQU0eroE7VKyq3OhitXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=B0z7mIqD; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="B0z7mIqD" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-431481433bdso7805905e9.3 for ; Thu, 07 Nov 2024 04:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730982413; x=1731587213; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=7vkRS/H+ZdcXDiRwjEKgfNuTb5DcFuR2X48KVwuB62o=; b=B0z7mIqDmVX4/Gz7SvAHjihbaVC8eihQyE6WN7DBAObfMSM5LKwwBp480YdrgE4tM5 sbcEMumaB9CQXu9sGBVf0+f11oNImuHxKZ3XkU8kqgbuUMpeh5HcbYuS0+DQhGV0CYuM 2wxZFn3MV7R2HeTuleImMi10tBWM8Tf8H8byBHjtdjzR8eWmcMoheUknCQQPxQKiJnCl 61ES3yKUZpu5FSe1utIsxtdCJb9wL5GKQLtdPR/GQMP+2du7AXq2xGJ7gXEF0zw9bGnI CEYIJPco+oD2fXB2dzUv+pvA2FgPlvCZ2eKQLkr/NoOXbEE7fjw3p1CWhxqGVUvY4Cj+ CIww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730982413; x=1731587213; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7vkRS/H+ZdcXDiRwjEKgfNuTb5DcFuR2X48KVwuB62o=; b=EliQlXOqlDSKIChfjibEcFqUNpOmP+ZwNLJ6lKDb7FLDmMikUzYbxJBNdBUGcUa5HH 0ArClQz+wtgAP40ebXpOOULN+NsPdUmnRFTMieBzU+Svfb+ffBvQDTblgSUwSnQQmvlP JpNtUgC+wuirJb1GDWvjgrc2RunewKT6SFJ9v1BB071Xx140BytcN6VD85IkoqMMN49c F5qihm8OWVslRwag2ptr9M0VkIMdA9SEXT4SHQE/K+4mTrUns+ty6gymnmHoQTQnHlGp 2uNQ+zJWt0JRJu7YpO8/ZXuo2nXBntzus2p2kjMDZ7enGwgek4g3D9sPZQWTL+GfQ3A8 IKaw== X-Gm-Message-State: AOJu0Yz7S8eBeB9/75aS4hU4iWi5m9gVhZfk8qaydKuSK7xH2qX3yGBE azDepi6X+W0LvAqL2n9mFmfhMJzZUb1azdWtsSFcxI9DvA+sSASm6oo9rlRgUM4= X-Google-Smtp-Source: AGHT+IFGWO5UdFCxajEysApkqvgppvf4I2d7N66E3WZTxWr029LJD2QTc2dczG2SHK/UBdlZ/06AjQ== X-Received: by 2002:a05:600c:1f0f:b0:431:5043:87c3 with SMTP id 5b1f17b1804b1-432b307b3efmr10799445e9.22.1730982413518; Thu, 07 Nov 2024 04:26:53 -0800 (PST) Received: from [172.16.23.252] ([154.14.63.34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed99a34bsm1580393f8f.54.2024.11.07.04.26.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Nov 2024 04:26:53 -0800 (PST) Message-ID: Date: Thu, 7 Nov 2024 13:26:51 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/2] clk: qcom: gcc-sm8550: Keep UFS PHY GDSCs ALWAYS_ON To: manivannan.sadhasivam@linaro.org, Bjorn Andersson , Michael Turquette , Stephen Boyd , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Pundir , Nitin Rawat , stable@vger.kernel.org References: <20241107-ufs-clk-fix-v1-0-6032ff22a052@linaro.org> <20241107-ufs-clk-fix-v1-1-6032ff22a052@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241107-ufs-clk-fix-v1-1-6032ff22a052@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/11/2024 12:58, Manivannan Sadhasivam via B4 Relay wrote: > From: Manivannan Sadhasivam > > Starting from SM8550, UFS PHY GDSCs doesn't support hardware retention. So > using RETAIN_FF_ENABLE is wrong. Moreover, without ALWAYS_ON flag, GDSCs > will get powered down during suspend, causing the UFS PHY to loose its > state. And this will lead to below UFS error during resume as observed on > SM8550-QRD: > > ufshcd-qcom 1d84000.ufs: ufshcd_uic_hibern8_exit: hibern8 exit failed. ret = 5 > ufshcd-qcom 1d84000.ufs: __ufshcd_wl_resume: hibern8 exit failed 5 > ufs_device_wlun 0:0:0:49488: ufshcd_wl_resume failed: 5 > ufs_device_wlun 0:0:0:49488: PM: dpm_run_callback(): scsi_bus_resume+0x0/0x84 returns 5 > ufs_device_wlun 0:0:0:49488: PM: failed to resume async: error 5 > > Cc: stable@vger.kernel.org # 6.8 > Fixes: 1fe8273c8d40 ("clk: qcom: gcc-sm8550: Add the missing RETAIN_FF_ENABLE GDSC flag") > Reported-by: Neil Armstrong > Suggested-by: Nitin Rawat > Signed-off-by: Manivannan Sadhasivam > --- > drivers/clk/qcom/gcc-sm8550.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sm8550.c b/drivers/clk/qcom/gcc-sm8550.c > index 5abaeddd6afc..7dd08e175820 100644 > --- a/drivers/clk/qcom/gcc-sm8550.c > +++ b/drivers/clk/qcom/gcc-sm8550.c > @@ -3046,7 +3046,7 @@ static struct gdsc ufs_phy_gdsc = { > .name = "ufs_phy_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > - .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE, > + .flags = POLL_CFG_GDSCR | ALWAYS_ON, > }; > > static struct gdsc ufs_mem_phy_gdsc = { > @@ -3055,7 +3055,7 @@ static struct gdsc ufs_mem_phy_gdsc = { > .name = "ufs_mem_phy_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > - .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE, > + .flags = POLL_CFG_GDSCR | ALWAYS_ON, > }; > > static struct gdsc usb30_prim_gdsc = { > Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8550-HDK Thanks, Neil