From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BAFCC433F5 for ; Wed, 16 Feb 2022 14:20:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234951AbiBPOVD (ORCPT ); Wed, 16 Feb 2022 09:21:03 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234933AbiBPOVC (ORCPT ); Wed, 16 Feb 2022 09:21:02 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 695B4265BC0 for ; Wed, 16 Feb 2022 06:20:50 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id v12so3775293wrv.2 for ; Wed, 16 Feb 2022 06:20:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=fJttqD83JtcJ4lbDggnFlbM6cstaH6DYAd/AKXx3eLo=; b=S657ZCmwQ0Q6bSYlkDVeZ6mhrjpjDuakfGtu2AwZSz1wQ1biP8aSnn3FfncID+4RgR lOQzP6MJgXdZeuZVDlWh8IrFOXGas68VPXmwNWjQz4WZ1IkRU2svHateZ/1MsEIDycOt AfxKO+Ik0JxTT51Jaludyg4qTB3uV6Oi7bwagq9XO+CL//b2korJMnkdEQZwI7RG7gGG DpS9a03ijmmikXKp/nyr2O5lP0IuJ2N8bXv3rX6gpFCFBkAJgCL4vCcd/k+ns2vtb6GF /JIwNZmJwY7X5UA4OCuM9iaXltZPMMuOBtXd4UfWUcKWC+qXxwepAaRLUfmR078Vn5fu PH8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fJttqD83JtcJ4lbDggnFlbM6cstaH6DYAd/AKXx3eLo=; b=WSxxgL1Lq8gf8jUBOi/O8gF00gJEwH7WlmpcxZeTJna3zoNgssxB88Sf8cSHYFIWp/ WAYzHbo0670HC9gkpIr7gz4pEpypwQk+5s139Cx5t2Q3O0p4OXDcVWrVCYFPWgUZRYe9 1KsjTyAkbESAlQgukUcxlGuSIguMvjAgytY3dTOMw5aYZu+YPRexhXQZrsU53Pff1dlv 3fay6TDmJLxG9O5nixzlbEWiwuoH3rptYHipKmbkCI7EU8bdLLZL3BVt6lmzXlvhvWsd lXJ4o8T1jzl3XkL4UGePNYAMoVYZBKGMYdxNu3IWumoNMVXaM/6QGqL/SC+LVk0qk8sh 07FA== X-Gm-Message-State: AOAM531JwoNuhWmgR4QnMybOusz0c9duYPsP8HKmeyz9LVSFJZQD/Hpe E/gyscCO4njvtD+yG69UR55G6w== X-Google-Smtp-Source: ABdhPJxm23Yuzt/CVqGgMXoOxwEXECgdCw4FnfkCJOiYKoi9WKeYemIFFyT21qzVKpv1dm1S/D9Ykg== X-Received: by 2002:adf:d1cb:0:b0:1e8:57d1:8f50 with SMTP id b11-20020adfd1cb000000b001e857d18f50mr1656042wrd.21.1645021249045; Wed, 16 Feb 2022 06:20:49 -0800 (PST) Received: from [192.168.86.34] (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.googlemail.com with ESMTPSA id e8sm20591211wru.37.2022.02.16.06.20.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Feb 2022 06:20:48 -0800 (PST) Message-ID: Date: Wed, 16 Feb 2022 14:20:47 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v6 5/7] pinctrl: qcom: Extract chip specific LPASS LPI code Content-Language: en-US To: Srinivasa Rao Mandadapu , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, judyhsiao@chromium.org, Linus Walleij , linux-gpio@vger.kernel.org Cc: Venkata Prasad Potturu References: <1644851994-22732-1-git-send-email-quic_srivasam@quicinc.com> <1644851994-22732-6-git-send-email-quic_srivasam@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <1644851994-22732-6-git-send-email-quic_srivasam@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 14/02/2022 15:19, Srinivasa Rao Mandadapu wrote: > Extract the chip specific SM8250 data from the LPASS LPI pinctrl driver > to allow reusing the common code in the addition of subsequent > platforms. > > Signed-off-by: Srinivasa Rao Mandadapu > Co-developed-by: Venkata Prasad Potturu > Signed-off-by: Venkata Prasad Potturu > --- > drivers/pinctrl/qcom/Kconfig | 8 + > drivers/pinctrl/qcom/Makefile | 1 + > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 233 +----------------------- > drivers/pinctrl/qcom/pinctrl-lpass-lpi.h | 86 +++++++++ > drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c | 166 +++++++++++++++++ > 5 files changed, 266 insertions(+), 228 deletions(-) > create mode 100644 drivers/pinctrl/qcom/pinctrl-lpass-lpi.h > create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c > > diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig > index ca6f68a..8871451 100644 > --- a/drivers/pinctrl/qcom/Kconfig > +++ b/drivers/pinctrl/qcom/Kconfig > @@ -357,4 +357,12 @@ config PINCTRL_LPASS_LPI > Qualcomm Technologies Inc LPASS (Low Power Audio SubSystem) LPI > (Low Power Island) found on the Qualcomm Technologies Inc SoCs. > > +config PINCTRL_SM8250_LPASS_LPI > + tristate "Qualcomm Technologies Inc SM8250 LPASS LPI pin controller driver" > + depends on PINCTRL_LPASS_LPI shouldn't this be select instead of depends. > + help > + This is the pinctrl, pinmux, pinconf and gpiolib driver for the > + Qualcomm Technologies Inc LPASS (Low Power Audio SubSystem) LPI > + (Low Power Island) found on the Qualcomm Technologies Inc SM8250 platform. > + > endif