From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6094E257AFA; Mon, 14 Apr 2025 09:57:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744624640; cv=none; b=uhjOM43zQ4oDFIkcUJwlnwuLuD2iN06AtwCS0x2fu6ZMKHeB0x6obdr6cqqfP6TdwijjB+RWkMe+BNLCmLMT8o4dgMg3gE++ngwrBB8RcKTkc8WZ0vIOY/a/xwj06nyvgLb/Awl6kbbHx9G8ZI51bc3CssOgKmwL5sUI6koIbh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744624640; c=relaxed/simple; bh=7GgL3xtvI7pnGeuvq9RVd04janbGJVSlvm5BxXVmlgQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=TG6CkPW8aFgZyMD3JFNiLry3LAIKkiIHj+CnKE4VRqKlioBZZk3paXkLJv2X0qTCtoLBMbvTdIAwp5ZN/eHGdfURTg1KXF25p8rkbM2CG8GQKSrzmAj5TYA0bzzmsC8cpVo8EEaG30TEAS63kKOCVl1pQ4I/JasjJqWe7ONQRxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=ZHx+w8bl; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="ZHx+w8bl" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53E99qRt011398; Mon, 14 Apr 2025 09:56:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4VHC8WYpl+uLggBA75zLhVV+Fe7u1dbbrYvZ0DxrmwE=; b=ZHx+w8blJmgNpPdx ZuI3JHLeJJ0EpXJT9Ql1p0pzljSctU6IqOmkcWjmvFvL0DaVexXTM/08XA6ySM5o 6HG3jxqUIinw+R9LFxJfIsiQrc6OmW+heO8sB77+Eromy1i4v2bJAxWJW4Cj3HcN ckbQYSU2r7BMkKd1v9pl7YtuUXV+rZyJOQ+qUCczugtsY0L7a2Jyut58Rn9W1iak YOvRUtKSc2/iq+enK+jjyQ2ovoYtw+BRn+CV2q3pHfbEXVRnMjPWtyLHX5uAjr1J clJV25yfr36AJRivRDT+/vO9tbJnVIsqHzlZ3R7bvHJGzJYP++Ji7hubdSa4xfWk b4V8Iw== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45yg8wc2u6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Apr 2025 09:56:54 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 53E9ur1R006022 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Apr 2025 09:56:53 GMT Received: from [10.204.66.137] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 14 Apr 2025 02:56:46 -0700 Message-ID: Date: Mon, 14 Apr 2025 15:26:43 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes To: Dmitry Baryshkov CC: , , , , , , , , , , , , , , , , , , , , , , , , References: <20250404115539.1151201-1-quic_amakhija@quicinc.com> <20250404115539.1151201-8-quic_amakhija@quicinc.com> <0f4eca6c-67df-4730-88b3-a277903deabc@quicinc.com> Content-Language: en-US From: Ayushi Makhija In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Authority-Analysis: v=2.4 cv=E9TNpbdl c=1 sm=1 tr=0 ts=67fcdbe7 cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=gEfo2CItAAAA:8 a=COk6AnOGAAAA:8 a=8v7svmj6aq3A3Q3kazgA:9 a=QEXdDO2ut3YA:10 a=sptkURWiP4Gy88Gu7hUp:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: 8Z-j7vyNj4iUSOfE710VIG7ZGQwXoleI X-Proofpoint-GUID: 8Z-j7vyNj4iUSOfE710VIG7ZGQwXoleI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-14_03,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 mlxscore=0 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504140072 Hi Dmitry, On 4/11/2025 1:31 AM, Dmitry Baryshkov wrote: > On Thu, Apr 10, 2025 at 06:37:54PM +0530, Ayushi Makhija wrote: >> Hi Dmirity/Konard >> >> On 4/7/2025 1:42 AM, Dmitry Baryshkov wrote: >>> On Fri, Apr 04, 2025 at 05:25:36PM +0530, Ayushi Makhija wrote: >>>> Add anx7625 DSI to DP bridge device nodes. >>>> >>>> Signed-off-by: Ayushi Makhija >>>> --- >>>> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 208 ++++++++++++++++++++- >>>> 1 file changed, 207 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >>>> index 175f8b1e3b2d..8e784ccf4138 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >>>> @@ -28,6 +28,13 @@ chosen { >>>> stdout-path = "serial0:115200n8"; >>>> }; >>>> >>>> + vph_pwr: vph-pwr-regulator { >>>> + compatible = "regulator-fixed"; >>>> + regulator-name = "vph_pwr"; >>>> + regulator-always-on; >>>> + regulator-boot-on; >>>> + }; >>>> + >>>> vreg_conn_1p8: vreg_conn_1p8 { >>>> compatible = "regulator-fixed"; >>>> regulator-name = "vreg_conn_1p8"; >>>> @@ -128,6 +135,30 @@ dp1_connector_in: endpoint { >>>> }; >>>> }; >>>> }; >>>> + >>>> + dp-dsi0-connector { >>>> + compatible = "dp-connector"; >>>> + label = "DSI0"; >>>> + type = "full-size"; >>>> + >>>> + port { >>>> + dp_dsi0_connector_in: endpoint { >>>> + remote-endpoint = <&dsi2dp_bridge0_out>; >>>> + }; >>>> + }; >>>> + }; >>>> + >>>> + dp-dsi1-connector { >>>> + compatible = "dp-connector"; >>>> + label = "DSI1"; >>>> + type = "full-size"; >>>> + >>>> + port { >>>> + dp_dsi1_connector_in: endpoint { >>>> + remote-endpoint = <&dsi2dp_bridge1_out>; >>>> + }; >>>> + }; >>>> + }; >>>> }; >>>> >>>> &apps_rsc { >>>> @@ -517,9 +548,135 @@ &i2c11 { >>>> >>>> &i2c18 { >>>> clock-frequency = <400000>; >>>> - pinctrl-0 = <&qup_i2c18_default>; >>>> + pinctrl-0 = <&qup_i2c18_default>, >>>> + <&io_expander_intr_active>, >>>> + <&io_expander_reset_active>; >>> >>> These pinctrl entries should go to the IO expander itself. >>> >>>> pinctrl-names = "default"; >>>> + >>>> status = "okay"; >>>> + >>>> + io_expander: gpio@74 { >>>> + compatible = "ti,tca9539"; >>>> + reg = <0x74>; >>>> + interrupts-extended = <&tlmm 98 IRQ_TYPE_EDGE_BOTH>; >>>> + gpio-controller; >>>> + #gpio-cells = <2>; >>>> + interrupt-controller; >>>> + #interrupt-cells = <2>; >>>> + >>>> + gpio2-hog { >>> >>> This needs a huuge explanation in the commit message. Otherwise I'd say >>> these pins should likely be used by the corresponding anx bridges. >> >> Thanks, for the review. >> >> Previously, I was referring to the downstream DT and misunderstood the use of gpio-hog. >> After reading the schematic, I realized that gpio2, gpio3, gpio10, and gpio11 are all input pins >> to the IO expander TC9539. We have already configured gpio2 and gpio10 as interrupts in the >> ANX7625 bridges, so the gpio-hog is not required. It is working without the gpio-hog configuration. > > Please make sure that there are pinctrl entries for all pins. > Thanks, for the review. While declaring the pinctrl entries inside the io_expander node, I am getting below error while checking the DTBS check against DT-binding. Error : /local/mnt/workspace/amakhija/linux_next_11042025/linux/arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: gpio@74: 'dsi0-int-pin-state', 'dsi1-int-pin-state' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml# io_expander: gpio@74 { compatible = "ti,tca9539"; reg = <0x74>; interrupts-extended = <&tlmm 98 IRQ_TYPE_EDGE_BOTH>; gpio-controller; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; pinctrl-0 = <&io_expander_intr_active>, <&io_expander_reset_active>; pinctrl-names = "default"; dsi0_int_pin: dsi0-int-pin-state { pins = "gpio2"; input-enable; bias-disable; }; dsi1_int_pin: dsi1-int-pin-state { pins = "gpio10"; input-enable; bias-disable; }; }; I couldn't find any devicetree example of tca9539 which is using pinctrl. The gpio-pca95xx.yaml DT binding does not match with any regex of the patterns properties. Thanks, Ayushi