From: Bart Van Assche <bvanassche@acm.org>
To: Palash Kambar <palash.kambar@oss.qualcomm.com>
Cc: mani@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
peter.griffin@linaro.org, krzk@kernel.org,
peter.wang@mediatek.com, beanhuo@micron.com,
quic_nguyenb@quicinc.com, adrian.hunter@intel.com,
ebiggers@kernel.org, neil.armstrong@linaro.org,
James.Bottomley@hansenpartnership.com,
martin.petersen@oracle.com, linux-arm-msm@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_cang@quicinc.com, quic_nitirawa@quicinc.com
Subject: Re: [PATCH V1 2/2] ufs: ufs-qcom: Disable AHIT before SQ tail update to prevent race in MCQ mode
Date: Wed, 15 Oct 2025 08:45:18 -0700 [thread overview]
Message-ID: <bb9c7926-4820-4922-a67d-65a6b1bace9a@acm.org> (raw)
In-Reply-To: <CAGbPq5dhUXr59U_J3W4haNHughkaiXpnc4kAZWXB0SjPdFQMhg@mail.gmail.com>
On 10/15/25 7:08 AM, Palash Kambar wrote:
> Since AHIT is a hardware-based power-saving feature, disabling it
> entirely
> could lead to significant power penalties. Therefore, this patch aims to
> preserve
> power efficiency while resolving the race condition.
> We have tested this change and observed no noticeable performance
> degradation.
> Also, adding in RPM callbacks will not solve the power penalty as it
> autosuspend timer is
> 3 secs in comparision to AHIT timer which is 5ms.
The runtime power management timeout can be modified. Please verify
whether the power consumption with AHIT disabled and the runtime power
management timeout set to 5 ms is acceptable.
Thanks,
Bart.
next prev parent reply other threads:[~2025-10-15 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 6:04 [PATCH V1 0/2] Address race condition in MCQ mode and enhance palash.kambar
2025-10-14 6:04 ` [PATCH V1 1/2] ufs: core:Add vendor-specific callbacks and update setup_xfer_req interface palash.kambar
2025-10-14 16:10 ` Bart Van Assche
2025-10-18 6:49 ` Palash Kambar
2025-10-14 6:04 ` [PATCH V1 2/2] ufs: ufs-qcom: Disable AHIT before SQ tail update to prevent race in MCQ mode palash.kambar
2025-10-14 16:18 ` Bart Van Assche
[not found] ` <CAGbPq5dhUXr59U_J3W4haNHughkaiXpnc4kAZWXB0SjPdFQMhg@mail.gmail.com>
2025-10-15 15:45 ` Bart Van Assche [this message]
2025-10-18 6:44 ` Palash Kambar
2025-10-20 6:53 ` Peter Wang (王信友)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb9c7926-4820-4922-a67d-65a6b1bace9a@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=ebiggers@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neil.armstrong@linaro.org \
--cc=palash.kambar@oss.qualcomm.com \
--cc=peter.griffin@linaro.org \
--cc=peter.wang@mediatek.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).