From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39B78DDC5; Tue, 24 Dec 2024 04:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735015031; cv=none; b=l3Y9Cg37GRFppS0B9QAaVH4B6Rot0XC3cL8nXOIXIO14ELmRW/DemgFpD24UnmgqgYnzzMmL9epOK9lw8hGgbVeP1OfVzXX8T9fHrPydI+in+qizagF7D9j/xQ61BM4PYDNwRhRqEjc1ImFeB6qiPbOMAhCqtiUi+t1jbVFeReI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735015031; c=relaxed/simple; bh=SFddqfnJ/cS15F00gCuaFN7VtuJm7ES3KxKf5yG/cJU=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=KaDEUYB+fXrJG8AEYkt67Ou6z0DFSospLB5nmAt/eZu0wxnY92Z389SMum0WeewbusuvI6DNp2+uE3U1SrpRPp/xNm9j+gk/AyZ0RpIgOV4FEqauApuU4ZMZSQxmtyjY7zpBloUbUvIFTeJxaBSlXiwP32HGJPmuOULstcrc46Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=EnV/u9fJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="EnV/u9fJ" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BNHSeJn022275; Tue, 24 Dec 2024 04:36:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wqk8yyGdYA8+tgU3o+j68767OwMhgx8P7yMqLGIol3c=; b=EnV/u9fJtxJ9aliD vaW2vE6sxFA+3XiEtvfgv8qQJyP7UTd32kt9nLPaK7Vfh68nCi27P4gWKTtSSM2b AgXljU5ihqR2bVnh9UX3gWJn0tUNNsJqO7JAFGmlGjxf11Jdja7iyEBz3edicZW5 hWUuSBOBxaf1V6aNvwm+a9xYW06eCplQSqSVSW4ojvk0flnAVnEg+v9vJoCwD0jO 2h9I9JYHDBAiViEsFer4Vwnaftc4PMSacA26aJcQPvhINjoK5dfoBySglqnp8Scr pd9t4v4MyQQJIraip8VSFdt5KKQnHkp4n8xYHO+m2wQFghfhy7ge7gWvO2jK/H/9 xQ6ORg== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43qca01dyp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Dec 2024 04:36:38 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4BO4abna004324 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Dec 2024 04:36:37 GMT Received: from [10.253.36.144] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 23 Dec 2024 20:36:32 -0800 Message-ID: Date: Tue, 24 Dec 2024 12:36:29 +0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] net: stmmac: dwmac-qcom-ethqos: add support for EMAC on qcs615 platforms To: Dmitry Baryshkov CC: Vinod Koul , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bhupesh Sharma , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Coquelin , Krzysztof Kozlowski , , , , , , References: <20241224-schema-v2-0-000ea9044c49@quicinc.com> <20241224-schema-v2-3-000ea9044c49@quicinc.com> <62wm4samob5bzsk2br75fmllkrgptxxj2pgo7hztnhkhvwt54v@zz7edyq6ys77> Content-Language: en-US From: Yijie Yang In-Reply-To: <62wm4samob5bzsk2br75fmllkrgptxxj2pgo7hztnhkhvwt54v@zz7edyq6ys77> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: WvN_FrKIbTJwUF6DwnfAplq0TvfLmvAG X-Proofpoint-ORIG-GUID: WvN_FrKIbTJwUF6DwnfAplq0TvfLmvAG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 clxscore=1011 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412240034 On 2024-12-24 12:18, Dmitry Baryshkov wrote: > On Tue, Dec 24, 2024 at 11:07:03AM +0800, Yijie Yang wrote: >> qcs615 uses EMAC version 2.3.1, add the relevant defines and add the new >> compatible. >> >> Signed-off-by: Yijie Yang >> --- >> drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c >> index 901a3c1959fa57efb078da795ad4f92a8b6f71e1..8c76beaee48821eb2853f4e3f8bfd37db8cadf78 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c >> @@ -249,6 +249,22 @@ static const struct ethqos_emac_driver_data emac_v2_1_0_data = { >> .has_emac_ge_3 = false, >> }; >> >> +static const struct ethqos_emac_por emac_v2_3_1_por[] = { >> + { .offset = RGMII_IO_MACRO_CONFIG, .value = 0x00C01343 }, >> + { .offset = SDCC_HC_REG_DLL_CONFIG, .value = 0x2004642C }, > > lowercase the hex, please. I will take care of it. > >> + { .offset = SDCC_HC_REG_DDR_CONFIG, .value = 0x00000000 }, >> + { .offset = SDCC_HC_REG_DLL_CONFIG2, .value = 0x00200000 }, >> + { .offset = SDCC_USR_CTL, .value = 0x00010800 }, >> + { .offset = RGMII_IO_MACRO_CONFIG2, .value = 0x00002060 }, >> +}; >> + >> +static const struct ethqos_emac_driver_data emac_v2_3_1_data = { >> + .por = emac_v2_3_1_por, >> + .num_por = ARRAY_SIZE(emac_v2_3_1_por), >> + .rgmii_config_loopback_en = true, >> + .has_emac_ge_3 = false, >> +}; > > Modulo emac_v2_3_1_por vs emac_v2_3_0_por, this is the same as > emac_v2_3_0_data. Which means that bindings for qcs615-ethqos should be > corrected to use qcom,qcs404-ethqos as as fallback entry, making this > patch unused. Please correct the bindings instead. Although they currently share the same data, they are actually two different versions. Their differences are not apparent now but will become evident once new features are uploaded. If I revert to qcom,qcs404-ethqos now, it will be challenging to distinguish between them in the future. > >> + >> static const struct ethqos_emac_por emac_v3_0_0_por[] = { >> { .offset = RGMII_IO_MACRO_CONFIG, .value = 0x40c01343 }, >> { .offset = SDCC_HC_REG_DLL_CONFIG, .value = 0x2004642c }, >> @@ -898,6 +914,7 @@ static int qcom_ethqos_probe(struct platform_device *pdev) >> >> static const struct of_device_id qcom_ethqos_match[] = { >> { .compatible = "qcom,qcs404-ethqos", .data = &emac_v2_3_0_data}, >> + { .compatible = "qcom,qcs615-ethqos", .data = &emac_v2_3_1_data}, >> { .compatible = "qcom,sa8775p-ethqos", .data = &emac_v4_0_0_data}, >> { .compatible = "qcom,sc8280xp-ethqos", .data = &emac_v3_0_0_data}, >> { .compatible = "qcom,sm8150-ethqos", .data = &emac_v2_1_0_data}, >> >> -- >> 2.34.1 >> > -- Best Regards, Yijie