From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7000E156222 for ; Tue, 9 Apr 2024 18:17:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712686622; cv=none; b=UdldnJU9c8jdck8axCZzGUDTXyrI0ixcG7Vqr2WxU9XpJqTrNUBcwW9ZFpwt8DxGme3c053JhTzt4EdlVuq7MDVgk+bqIkrHp+vWP7edySbRPlzZi9oP/Y4NIG3rkIKxF+mrtNeSi6jp/Y4g/daRWL5blGE5wJlMYp8o47KS9lE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712686622; c=relaxed/simple; bh=8v7Bw7Ml2qSXocRuYkT6D/f4NYEZj9FMUacUtYK7PxQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UUOEVE3yUPqlOSf9D+bWmYXmJZCoHRFZGC7HV93CNHrPEs1aRA3TOiqFINn7LmUd8IkU+4mCm2o6AY0HBaTARZwBYsHmMYjY6kO2SRzOmEeH0f1rpZD3q/uZ0tf7YZecMIO7wn9wHfA20vlxYgNJysY8bhqyicfZ9MNZaiMBBzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NkxYjiG2; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NkxYjiG2" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-516d4d80d00so5361878e87.0 for ; Tue, 09 Apr 2024 11:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712686619; x=1713291419; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KwRcEqJdl/aKPcyjjUDw4PrMEBdsdFKPMiKh/b3NCj0=; b=NkxYjiG27JOn6YNUPIHrMmshU6ip4pbLatylyNZUeFkgXkhlH68Bz1VUkCcjP5FX06 meJpageOM9/wIFE9wAJvoA5gqGKBKCLHXOmCOXibTZF0OBYecjOVxFqO8OyPE8yyMPNQ X/Qs7wn4AsbjklvKP6RbXBZ6txByD2uLVEG9HHSPDbOPHtgGSlKdCsQMlGq+SoR8MtYS c6k7jVa1Nn6RaVk3SrFIaN+/tHXWSMcXV/patllyDu0e0fmXuOYH9IJnuyoS48CFVCrn 6Blk60SAVKH+ZTT1HQeQlTkTVxEGdGH9BffOZn/FfHuTCV+TF9vaVOo8XGgU9kH7tZFi ve6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712686619; x=1713291419; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KwRcEqJdl/aKPcyjjUDw4PrMEBdsdFKPMiKh/b3NCj0=; b=SsU3wGLvvQWEDOTRfRW9i2tc8CNaHsgeX6iaE/0tDmVOfM2sqYLQGcq43ZlurVyZhG 7S2N8Cg2pHv2vMnDMyEg261nSNplDLADA5grojV3OKfWyFG7COjc99ko+9Gp0LXtxW+f LbDWpbbwNSC8ueMRuZeoyIyfbOkLiIxES+jz0+A84hjxbxXWal+x8xS5GSVakoXrag9C /7Y4QTV8N0c67hpwfBWNOirNM7od/NV588rJdykLGDBlngla0JXKeJQDKf8jDCl6hJx1 hQ1ekUDny23s8cIIfGBoEIuW4dTjwqwQu93OhjYH++SpEEJmWPPbX0qCrTrZPYIFVQuj gayA== X-Forwarded-Encrypted: i=1; AJvYcCX+1/D1xaFdywYJFAEoFjVyAgLK92HTAUANKk6sHwXRI31yNsY6yG4qSkXUxrZDwV3e0TrzfYyWL1a0HrdLx4CRrKgzV2zv5twK/7VJPg== X-Gm-Message-State: AOJu0Yz3ZiOys4g5S+Hvilcsn8uwuKqtRGBxSPBQ8w59gys6jVtTTsM4 vl1RYf7ykoReLO4QlkFW2zeAUc6Zn+2A/S8Q0RyWxCV5xV2BfF2+xl3ZVTNq9pw= X-Google-Smtp-Source: AGHT+IFi97DTqvvh7mVWzHxai8ZC6jdD8XWkBMYhCggo9XKB7YbQyLLHUqoq4tjk99obPxsTaf1bQQ== X-Received: by 2002:a05:6512:2c95:b0:516:c600:64e8 with SMTP id dw21-20020a0565122c9500b00516c60064e8mr200709lfb.1.1712686618619; Tue, 09 Apr 2024 11:16:58 -0700 (PDT) Received: from [172.30.205.99] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id x7-20020ac259c7000000b00516dc765e1esm1276627lfn.267.2024.04.09.11.16.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 11:16:58 -0700 (PDT) Message-ID: Date: Tue, 9 Apr 2024 20:16:56 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 03/19] media: venus: pm_helpers: Add kerneldoc to venus_clks_get() To: Dikshita Agarwal , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Philipp Zabel Cc: Marijn Suijten , Stanimir Varbanov , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230911-topic-mars-v3-0-79f23b81c261@linaro.org> <20230911-topic-mars-v3-3-79f23b81c261@linaro.org> <80c0ecb3-1157-1d7a-0829-c3b68b65f17f@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <80c0ecb3-1157-1d7a-0829-c3b68b65f17f@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/5/24 10:26, Dikshita Agarwal wrote: > > > On 3/27/2024 11:38 PM, Konrad Dybcio wrote: >> To make it easier to understand the various clock requirements within >> this driver, add kerneldoc to venus_clk_get() explaining the fluff. >> >> Reviewed-by: Bryan O'Donoghue >> Signed-off-by: Konrad Dybcio >> --- >> drivers/media/platform/qcom/venus/pm_helpers.c | 28 ++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c >> index ac7c83404c6e..cf91f50a33aa 100644 >> --- a/drivers/media/platform/qcom/venus/pm_helpers.c >> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c >> @@ -23,6 +23,34 @@ >> >> static bool legacy_binding; >> >> +/** >> + * venus_clks_get() - Get Venus clocks that are not bound to a vcodec >> + * @core: A pointer to the venus core resource >> + * >> + * The Venus block (depending on the generation) can be split into a couple >> + * of clock domains: one for main logic and one for each video core (0-2 instances). >> + * >> + * MSM8916 (and possibly other HFIv1 users) only feature the "main logic" >> + * domain, so this function is the only kind if clk_get necessary there. >> + * >> + * MSM8996 (and other HFIv3 users) feature two video cores, with core0 being >> + * statically defined a decoder and core1 an encoder, with both having >> + * their own clock domains. >> + * >> + * SDM845 features two video cores, each one of which may or may not be >> + * subdivided into two encoder/decoder threads. >> + * >> + * Other SoCs either feature a single video core (with its own clock domain) >> + * or one video core and one CVP (Computer Vision Processor) core. In both cases >> + * we treat it the same way (CVP only happens to live near-by Venus on the SoC). >> + * >> + * Due to unfortunate developments in the past, we need to support legacy > why unfortunate? please re-phrase this. It's unfortunate because another binding has been created to represent the same hardware to solve a "problem" that could have been dealt with using a couple lines of C and that we now need to carry support for. Konrad