From: Krzysztof Kozlowski <krzk@kernel.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
gregkh@linuxfoundation.org, konrad.dybcio@linaro.org,
djakov@kernel.org, quic_wcheng@quicinc.com,
quic_kathirav@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 2/5] dt-bindings: usb: qcom,dwc3: Update ipq5332 clock details
Date: Wed, 24 Jul 2024 13:55:41 +0200 [thread overview]
Message-ID: <bc2da461-fd21-44d1-85a7-f89c60e2b207@kernel.org> (raw)
In-Reply-To: <ZqDoXu9+Y4+O8M7W@hu-varada-blr.qualcomm.com>
On 24/07/2024 13:41, Varadarajan Narayanan wrote:
> On Wed, Jul 24, 2024 at 08:27:03AM +0200, Krzysztof Kozlowski wrote:
>> On 23/07/2024 11:03, Varadarajan Narayanan wrote:
>>> USB uses icc-clk framework to enable the NoC interface clock.
>>> Hence the 'iface' clock is removed from the list of clocks.
>>> Update the clock-names list accordingly.
>>
>> But the clock is still there and is still used by this block. This looks
>> like adjusting hardware per Linux implementation.
>>
>> Why suddenly this clock was removed from this hardware?
>
> This clock per se is not used by the USB block. It is needed to
> enable the path for CPU to reach the USB block (and vice versa).
> Hence, we were adviced to use the ICC framework to enable this
> clock and not the clocks/clock-names DT entries.
>
> Please refer to [1] where similar clocks for IPQ9574 were NAK'ed.
So the original submission was not correct?
You really need to stop sending DTS based on current driver support and
focus on proper hardware description.
Such things pop up from time to time for Qualcomm and I don't see much
of improvement. And we do not talk about some ancient code, predating
guidelines, but IPQ5332 upstreamed ~1 year ago.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-24 11:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 9:02 [PATCH v4 0/5] Add interconnect driver for IPQ5332 SoC Varadarajan Narayanan
2024-07-23 9:03 ` [PATCH v4 1/5] dt-bindings: interconnect: Add Qualcomm IPQ5332 support Varadarajan Narayanan
2024-07-23 9:03 ` [PATCH v4 2/5] dt-bindings: usb: qcom,dwc3: Update ipq5332 clock details Varadarajan Narayanan
2024-07-24 6:27 ` Krzysztof Kozlowski
2024-07-24 11:41 ` Varadarajan Narayanan
2024-07-24 11:55 ` Krzysztof Kozlowski [this message]
2024-07-25 7:55 ` Varadarajan Narayanan
2024-07-23 9:03 ` [PATCH v4 3/5] clk: qcom: ipq5332: Register gcc_qdss_tsctr_clk_src Varadarajan Narayanan
2024-07-23 11:40 ` Dmitry Baryshkov
2024-07-23 9:03 ` [PATCH v4 4/5] clk: qcom: ipq5332: Use icc-clk for enabling NoC related clocks Varadarajan Narayanan
2024-07-23 11:40 ` Dmitry Baryshkov
2024-07-23 9:03 ` [PATCH v4 5/5] arm64: dts: qcom: ipq5332: Add icc provider ability to gcc Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc2da461-fd21-44d1-85a7-f89c60e2b207@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox