[PATCH v2 0/3] Add support for remoteprocs on SM7635

[PATCH v2 0/3] Add support for remoteprocs on SM7635

[Luca Weiss]

Add the bindings and driver for the ADSP, CDSP, MPSS and WPSS on the
SM7635 SoC.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- Update default firmware names from .mdt to .mbn
- Link to v1: https://lore.kernel.org/r/20250625-sm7635-remoteprocs-v1-0-730d6b5171ee@fairphone.com

---
Luca Weiss (3):
      dt-bindings: remoteproc: qcom,sm8350-pas: document SM7635 MPSS & WPSS
      dt-bindings: remoteproc: qcom,sm8550-pas: document SM7635 ADSP & CDSP
      remoteproc: qcom: pas: Add SM7635 remoteproc support

 .../bindings/remoteproc/qcom,sm8350-pas.yaml       | 19 +++++++++++
 .../bindings/remoteproc/qcom,sm8550-pas.yaml       | 37 ++++++++++++++++++++++
 drivers/remoteproc/qcom_q6v5_pas.c                 | 24 ++++++++++++++
 3 files changed, 80 insertions(+)
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250620-sm7635-remoteprocs-149da64084b8

Best regards,
-- 
Luca Weiss <luca.weiss@fairphone.com>

[PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: document SM7635 MPSS & WPSS

[Luca Weiss]

Document the MPSS & WPSS remoteprocs on the SM7635 Platform.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 .../bindings/remoteproc/qcom,sm8350-pas.yaml          | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
index 6d09823153fc8331f04d4657d9acba718533cce6..9ffddafea33739d325fd4c469642bff461a933b8 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
@@ -18,6 +18,8 @@ properties:
     oneOf:
       - enum:
           - qcom,sar2130p-adsp-pas
+          - qcom,sm7635-mpss-pas
+          - qcom,sm7635-wpss-pas
           - qcom,sm8350-adsp-pas
           - qcom,sm8350-cdsp-pas
           - qcom,sm8350-slpi-pas
@@ -91,6 +93,7 @@ allOf:
       properties:
         compatible:
           enum:
+            - qcom,sm7635-mpss-pas
             - qcom,sm8350-mpss-pas
             - qcom,sm8450-mpss-pas
     then:
@@ -142,6 +145,22 @@ allOf:
             - const: cx
             - const: mxc
 
+  - if:
+      properties:
+        compatible:
+          enum:
+            - qcom,sm7635-wpss-pas
+    then:
+      properties:
+        power-domains:
+          items:
+            - description: CX power domain
+            - description: MX power domain
+        power-domain-names:
+          items:
+            - const: cx
+            - const: mx
+
 unevaluatedProperties: false
 
 examples:

-- 
2.50.0

[PATCH v2 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: document SM7635 ADSP & CDSP

[Luca Weiss]

Document the ADSP & CDSP remoteprocs on the SM7635 Platform.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 .../bindings/remoteproc/qcom,sm8550-pas.yaml       | 37 ++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
index 2dd479cf48217a0799ab4e4318026d8b93c3c995..44cc329be5067ab6cbaa0a467669cb3f55c7e714 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
@@ -18,6 +18,8 @@ properties:
     oneOf:
       - enum:
           - qcom,sdx75-mpss-pas
+          - qcom,sm7635-adsp-pas
+          - qcom,sm7635-cdsp-pas
           - qcom,sm8550-adsp-pas
           - qcom,sm8550-cdsp-pas
           - qcom,sm8550-mpss-pas
@@ -165,6 +167,24 @@ allOf:
           minItems: 5
           maxItems: 5
 
+  - if:
+      properties:
+        compatible:
+          enum:
+            - qcom,sm7635-adsp-pas
+            - qcom,sm7635-cdsp-pas
+    then:
+      properties:
+        interrupts:
+          minItems: 6
+          maxItems: 6
+        interrupt-names:
+          minItems: 6
+          maxItems: 6
+        memory-region:
+          minItems: 2
+          maxItems: 2
+
   - if:
       properties:
         compatible:
@@ -185,6 +205,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,sm7635-adsp-pas
               - qcom,sm8550-adsp-pas
               - qcom,sm8650-adsp-pas
               - qcom,sm8750-adsp-pas
@@ -239,6 +260,22 @@ allOf:
             - const: mxc
             - const: nsp
 
+  - if:
+      properties:
+        compatible:
+          enum:
+            - qcom,sm7635-cdsp-pas
+    then:
+      properties:
+        power-domains:
+          items:
+            - description: CX power domain
+            - description: MX power domain
+        power-domain-names:
+          items:
+            - const: cx
+            - const: mx
+
 unevaluatedProperties: false
 
 examples:

-- 
2.50.0

[PATCH v2 3/3] remoteproc: qcom: pas: Add SM7635 remoteproc support

[Luca Weiss]

Add the different remoteprocs found on SM7635: ADSP, CDSP, MPSS and
WPSS.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 drivers/remoteproc/qcom_q6v5_pas.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index b306f223127c452f8f2d85aa0fc98db2d684feae..908a9c3d3a115dd1b561a899a36a15cc79616450 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -1261,6 +1261,26 @@ static const struct adsp_data sdx55_mpss_resource = {
 	.ssctl_id = 0x22,
 };
 
+static const struct adsp_data sm7635_cdsp_resource = {
+	.crash_reason_smem = 601,
+	.firmware_name = "cdsp.mbn",
+	.dtb_firmware_name = "cdsp_dtb.mbn",
+	.pas_id = 18,
+	.dtb_pas_id = 0x25,
+	.minidump_id = 7,
+	.auto_boot = true,
+	.proxy_pd_names = (char*[]){
+		"cx",
+		"mx",
+		NULL
+	},
+	.load_state = "cdsp",
+	.ssr_name = "cdsp",
+	.sysmon_name = "cdsp",
+	.ssctl_id = 0x17,
+	.smem_host_id = 5,
+};
+
 static const struct adsp_data sm8450_mpss_resource = {
 	.crash_reason_smem = 421,
 	.firmware_name = "modem.mdt",
@@ -1478,6 +1498,10 @@ static const struct of_device_id adsp_of_match[] = {
 	{ .compatible = "qcom,sm6375-adsp-pas", .data = &sm6350_adsp_resource},
 	{ .compatible = "qcom,sm6375-cdsp-pas", .data = &sm8150_cdsp_resource},
 	{ .compatible = "qcom,sm6375-mpss-pas", .data = &sm6375_mpss_resource},
+	{ .compatible = "qcom,sm7635-adsp-pas", .data = &sm8550_adsp_resource},
+	{ .compatible = "qcom,sm7635-cdsp-pas", .data = &sm7635_cdsp_resource},
+	{ .compatible = "qcom,sm7635-mpss-pas", .data = &sm8450_mpss_resource},
+	{ .compatible = "qcom,sm7635-wpss-pas", .data = &sc7280_wpss_resource},
 	{ .compatible = "qcom,sm8150-adsp-pas", .data = &sm8150_adsp_resource},
 	{ .compatible = "qcom,sm8150-cdsp-pas", .data = &sm8150_cdsp_resource},
 	{ .compatible = "qcom,sm8150-mpss-pas", .data = &mpss_resource_init},

-- 
2.50.0

Re: [PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: document SM7635 MPSS & WPSS

[Krzysztof Kozlowski]

On Fri, Jun 27, 2025 at 08:55:42AM +0200, Luca Weiss wrote:
> @@ -91,6 +93,7 @@ allOf:
>        properties:
>          compatible:
>            enum:
> +            - qcom,sm7635-mpss-pas
>              - qcom,sm8350-mpss-pas
>              - qcom,sm8450-mpss-pas
>      then:
> @@ -142,6 +145,22 @@ allOf:
>              - const: cx
>              - const: mxc
>  
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,sm7635-wpss-pas

Everything fits better sm6350 and no need for new if:then: entry, at
least it looks like.

Best regards,
Krzysztof

Re: [PATCH v2 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: document SM7635 ADSP & CDSP

[Krzysztof Kozlowski]

On Fri, Jun 27, 2025 at 08:55:43AM +0200, Luca Weiss wrote:
> Document the ADSP & CDSP remoteprocs on the SM7635 Platform.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  .../bindings/remoteproc/qcom,sm8550-pas.yaml       | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> index 2dd479cf48217a0799ab4e4318026d8b93c3c995..44cc329be5067ab6cbaa0a467669cb3f55c7e714 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> @@ -18,6 +18,8 @@ properties:
>      oneOf:
>        - enum:
>            - qcom,sdx75-mpss-pas
> +          - qcom,sm7635-adsp-pas
> +          - qcom,sm7635-cdsp-pas

I don't understand why this is here and mpss and wpss are in other file.
It is supposed to be in one binding file, especiall that:

>            - qcom,sm8550-adsp-pas
>            - qcom,sm8550-cdsp-pas
>            - qcom,sm8550-mpss-pas
> @@ -165,6 +167,24 @@ allOf:
>            minItems: 5
>            maxItems: 5
>  
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,sm7635-adsp-pas
> +            - qcom,sm7635-cdsp-pas

it does not fit existing cases!

> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 6
> +          maxItems: 6
> +        interrupt-names:
> +          minItems: 6
> +          maxItems: 6
> +        memory-region:
> +          minItems: 2
> +          maxItems: 2
> +
>    - if:
>        properties:
>          compatible:
> @@ -185,6 +205,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - qcom,sm7635-adsp-pas
>                - qcom,sm8550-adsp-pas
>                - qcom,sm8650-adsp-pas
>                - qcom,sm8750-adsp-pas

sm6350 fits, doesn't it?

> @@ -239,6 +260,22 @@ allOf:
>              - const: mxc
>              - const: nsp
>  
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,sm7635-cdsp-pas
> +    then:
> +      properties:
> +        power-domains:
> +          items:
> +            - description: CX power domain
> +            - description: MX power domain
> +        power-domain-names:
> +          items:
> +            - const: cx
> +            - const: mx

And again this is like sm6350 :/

Best regards,
Krzysztof

Re: [PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: document SM7635 MPSS & WPSS

[Luca Weiss]

Hi Krzysztof,

On Tue Jul 1, 2025 at 10:12 AM CEST, Krzysztof Kozlowski wrote:
> On Fri, Jun 27, 2025 at 08:55:42AM +0200, Luca Weiss wrote:
>> @@ -91,6 +93,7 @@ allOf:
>>        properties:
>>          compatible:
>>            enum:
>> +            - qcom,sm7635-mpss-pas
>>              - qcom,sm8350-mpss-pas
>>              - qcom,sm8450-mpss-pas
>>      then:
>> @@ -142,6 +145,22 @@ allOf:
>>              - const: cx
>>              - const: mxc
>>  
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          enum:
>> +            - qcom,sm7635-wpss-pas
>
> Everything fits better sm6350 and no need for new if:then: entry, at
> least it looks like.

True, that seems to work fine as well. I can add it to the
qcom,sm6350-pas.yaml bindings instead of sm8350 in the next version.

To be honest, I don't quite understand what the concept behind the
different PAS bindings are, when an SoC should get a new .yaml file, and
when to add to an existing one.

Regards
Luca

>
> Best regards,
> Krzysztof

Re: [PATCH v2 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: document SM7635 ADSP & CDSP

[Luca Weiss]

Hi Krzysztof,

On Tue Jul 1, 2025 at 10:14 AM CEST, Krzysztof Kozlowski wrote:
> On Fri, Jun 27, 2025 at 08:55:43AM +0200, Luca Weiss wrote:
>> Document the ADSP & CDSP remoteprocs on the SM7635 Platform.
>> 
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> ---
>>  .../bindings/remoteproc/qcom,sm8550-pas.yaml       | 37 ++++++++++++++++++++++
>>  1 file changed, 37 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
>> index 2dd479cf48217a0799ab4e4318026d8b93c3c995..44cc329be5067ab6cbaa0a467669cb3f55c7e714 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
>> @@ -18,6 +18,8 @@ properties:
>>      oneOf:
>>        - enum:
>>            - qcom,sdx75-mpss-pas
>> +          - qcom,sm7635-adsp-pas
>> +          - qcom,sm7635-cdsp-pas
>
> I don't understand why this is here and mpss and wpss are in other file.
> It is supposed to be in one binding file, especiall that:

Is that the idea? (see my reply to my sm8350-pas patch)

>
>>            - qcom,sm8550-adsp-pas
>>            - qcom,sm8550-cdsp-pas
>>            - qcom,sm8550-mpss-pas
>> @@ -165,6 +167,24 @@ allOf:
>>            minItems: 5
>>            maxItems: 5
>>  
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          enum:
>> +            - qcom,sm7635-adsp-pas
>> +            - qcom,sm7635-cdsp-pas
>
> it does not fit existing cases!
>
>> +    then:
>> +      properties:
>> +        interrupts:
>> +          minItems: 6
>> +          maxItems: 6
>> +        interrupt-names:
>> +          minItems: 6
>> +          maxItems: 6
>> +        memory-region:
>> +          minItems: 2
>> +          maxItems: 2
>> +
>>    - if:
>>        properties:
>>          compatible:
>> @@ -185,6 +205,7 @@ allOf:
>>          compatible:
>>            contains:
>>              enum:
>> +              - qcom,sm7635-adsp-pas
>>                - qcom,sm8550-adsp-pas
>>                - qcom,sm8650-adsp-pas
>>                - qcom,sm8750-adsp-pas
>
> sm6350 fits, doesn't it?

Not quite, for sure the firmware-name and memory-region for adsp and
cdsp on this SoC requires the dtb firmware file as well, apart from that
it looks similar enough.

I'm also okay with creating a new (after the whole renaming thing)
qcom,milos-pas.yaml which contains the bindings for all 4 *-pas'es.

Let me know what you want to see in the next version.

Regards
Luca

>
>> @@ -239,6 +260,22 @@ allOf:
>>              - const: mxc
>>              - const: nsp
>>  
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          enum:
>> +            - qcom,sm7635-cdsp-pas
>> +    then:
>> +      properties:
>> +        power-domains:
>> +          items:
>> +            - description: CX power domain
>> +            - description: MX power domain
>> +        power-domain-names:
>> +          items:
>> +            - const: cx
>> +            - const: mx
>
> And again this is like sm6350 :/
>
> Best regards,
> Krzysztof

Re: [PATCH v2 3/3] remoteproc: qcom: pas: Add SM7635 remoteproc support

[Konrad Dybcio]

On 27-Jun-25 08:55, Luca Weiss wrote:
> Add the different remoteprocs found on SM7635: ADSP, CDSP, MPSS and
> WPSS.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---

With the agreed rename:

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: document SM7635 MPSS & WPSS

[Krzysztof Kozlowski]

On 01/07/2025 12:12, Luca Weiss wrote:
> Hi Krzysztof,
> 
> On Tue Jul 1, 2025 at 10:12 AM CEST, Krzysztof Kozlowski wrote:
>> On Fri, Jun 27, 2025 at 08:55:42AM +0200, Luca Weiss wrote:
>>> @@ -91,6 +93,7 @@ allOf:
>>>        properties:
>>>          compatible:
>>>            enum:
>>> +            - qcom,sm7635-mpss-pas
>>>              - qcom,sm8350-mpss-pas
>>>              - qcom,sm8450-mpss-pas
>>>      then:
>>> @@ -142,6 +145,22 @@ allOf:
>>>              - const: cx
>>>              - const: mxc
>>>  
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          enum:
>>> +            - qcom,sm7635-wpss-pas
>>
>> Everything fits better sm6350 and no need for new if:then: entry, at
>> least it looks like.
> 
> True, that seems to work fine as well. I can add it to the
> qcom,sm6350-pas.yaml bindings instead of sm8350 in the next version.
> 
> To be honest, I don't quite understand what the concept behind the
> different PAS bindings are, when an SoC should get a new .yaml file, and
> when to add to an existing one.

It is purely arbitrary way of organizing things, to reduce amount of
ifs:then: and make things easier to read. Adding ifs: does not make it
simple. Adding same SoC to multiple bindings does not make it simple.

Best regards,
Krzysztof

Re: [PATCH v2 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: document SM7635 ADSP & CDSP

[Krzysztof Kozlowski]

On 01/07/2025 12:16, Luca Weiss wrote:
>>>    - if:
>>>        properties:
>>>          compatible:
>>> @@ -185,6 +205,7 @@ allOf:
>>>          compatible:
>>>            contains:
>>>              enum:
>>> +              - qcom,sm7635-adsp-pas
>>>                - qcom,sm8550-adsp-pas
>>>                - qcom,sm8650-adsp-pas
>>>                - qcom,sm8750-adsp-pas
>>
>> sm6350 fits, doesn't it?
> 
> Not quite, for sure the firmware-name and memory-region for adsp and
> cdsp on this SoC requires the dtb firmware file as well, apart from that
> it looks similar enough.

I looked briefly, so indeed it might not fit well. That's on you to
investigate and find the best candidate which will mean the least amount
of changes or the simplest binding.

> 
> I'm also okay with creating a new (after the whole renaming thing)
> qcom,milos-pas.yaml which contains the bindings for all 4 *-pas'es.

If it does not fit sm6350 or others then yes, new binding it is.



Best regards,
Krzysztof