From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24DA8C76196 for ; Thu, 6 Apr 2023 18:32:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229463AbjDFSct (ORCPT ); Thu, 6 Apr 2023 14:32:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239619AbjDFScs (ORCPT ); Thu, 6 Apr 2023 14:32:48 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62CC3A26B for ; Thu, 6 Apr 2023 11:32:42 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id 20so41617205lju.0 for ; Thu, 06 Apr 2023 11:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680805960; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Bb7AHlVzzDMUYgUKWXYiRLmXkdswaw+n2t+bRcy2/rg=; b=fqjOEAr1lUjhphcKWwklh6oWc9fP/hWg8Lzk+AugAVD+xDpjzY5VsPsm3zYdiH2MJo vyadlXylXGaG3UTtmIZQTqUGYTE8ztTvH3Sm0cXNfS2To3y4smrm8ckbXyFAXcWrAqsd ZzlvY2aO7qiHwAeelLI2LC786Cgs1rs3Q4fRhUc+kdsWu3ql15huNeTmAWMd4NNcOAoz BGxUE+Ig/l6IA0Ij7MpUfE9UW8EaP8YTBXJuXltMrdbcx1YJMgSlu37JXH6TgoN0cPp7 FSvNLMqsW3i6UXzb5soW1A17XkQFnMgNlr4LdHsCkyg63D5lXZu3WQS4h7fXOsPN+dcL 12bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680805960; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bb7AHlVzzDMUYgUKWXYiRLmXkdswaw+n2t+bRcy2/rg=; b=x9F/2VNOn+X0/H0t6L1k5tRetLBm+4OCjlFsnAQxC+YSHqFw9edIEPFDVEbxHH2TM1 fllbgineEJ1lcSAsscVUewEpTMWwsabVPMZW+Tg02wWUR8QRBL6W4vBHtIiIm+OV34Zv NZqtEtQBLJtv1AARgWJbyiWQ5K0s1R+76I2kBpiRm/k3HdeRJf92xCzfY+FreH6jJr2r JSorp9TrkQ5WIT3FYS/vrnOWBI4FgUDaWIrHc8vfaHrHojQke50VsK3+mGSnnikFF3kk xrD/AfJug9PvJh2Tg9WPI0q7XWN0dCjZH9arDhSr1TfUBMGGSzpT3ZPtTGiRzRpr670X 96zQ== X-Gm-Message-State: AAQBX9e1MKUXYBPvdixM7dY6b+txpm6sKfDOB5vKaPPA9XIKF9Bz7h79 eOIN8RP7j3esIS5rp8hK0B3KHw== X-Google-Smtp-Source: AKy350bBUgim2iNgD2sYabdzyBZz7uqHM8WGfuNvgZIC5MmNx80787Am4O9xaU3OYx332Z41SAoMCQ== X-Received: by 2002:a2e:7814:0:b0:29d:ce75:5d06 with SMTP id t20-20020a2e7814000000b0029dce755d06mr3227238ljc.32.1680805960605; Thu, 06 Apr 2023 11:32:40 -0700 (PDT) Received: from [192.168.1.101] (abxh37.neoplus.adsl.tpnet.pl. [83.9.1.37]) by smtp.gmail.com with ESMTPSA id n9-20020a2e8789000000b00295a21c7954sm383798lji.50.2023.04.06.11.32.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 11:32:40 -0700 (PDT) Message-ID: Date: Thu, 6 Apr 2023 20:32:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Kees Cook , Tony Luck , "Guilherme G. Piccoli" Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20230406-topic-lenovo_features-v1-0-c73a5180e48e@linaro.org> <20230406-topic-lenovo_features-v1-4-c73a5180e48e@linaro.org> <7476b5ba-426c-3701-c4aa-d3e2db3de112@linaro.org> From: Konrad Dybcio In-Reply-To: <7476b5ba-426c-3701-c4aa-d3e2db3de112@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 6.04.2023 19:51, Dmitry Baryshkov wrote: > On 06/04/2023 18:25, Konrad Dybcio wrote: >> Enable the onboard QCA Wi-Fi. HW identifiers for reference: >> qmi chip_id 0x320 chip_family 0x4001 board_id 0xff soc_id 0x400e0000 >> >> Firmware sources: >> /vendor/firmware_mnt/image/wlanmdsp.bin -> qcom/.../wlanmdsp.mbn >> /vendor/firmware_mnt/image/bdwlan.bXX [1] -> [2] -> ath10k/.../board-2.bin >> [3] -> ath10k/.../firmware-5.bin >> >> Not sure where 3 comes from on the device itself, gotta investigate that.. >> >> According to [4], it's called WCN3990_STRAIT. >> >> [1] XX = board_id printed when the file is missing or by your downstream >> kernel firmware loader in the dmesg; if XX=ff, use bdwlan.bin > > Since the board_id is 0xff, please add qcom,ath10k-calibration-variant Do I make up a name, or is there some convention? I see Johan used "LE_X13S" in commit 2702f54f400ad3979632cdb76553772414f4c5e3. Should I go with "LE_P11"? > > Ideally, could you please send the bdwlan to ath10k for inclusion, see https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles . The legal situation is ambiguous at best :/ Konrad > >> >> [2] https://github.com/jhugo/linux/blob/5.5rc2_wifi/README >> [3] https://github.com/kvalo/ath10k-firmware/blob/master/WCN3990/hw1.0/HL3.1/WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1/firmware-5.bin >> [4] https://git.codelinaro.org/clo/la/platform/vendor/qcom-opensource/wlan/qca-wifi-host-cmn/-/blob/LA.VENDOR.1.0.r1-20700-WAIPIO.QSSI13.0/hif/src/hif_hw_version.h#L55 >> >> Signed-off-by: Konrad Dybcio >> --- >>   arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 8 ++++++++ >>   1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts >> index 2aac25171dec..4ba8e59a27d8 100644 >> --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts >> +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts >> @@ -315,6 +315,14 @@ &usb_hsphy { >>       status = "okay"; >>   }; >>   +&wifi { >> +    vdd-0.8-cx-mx-supply = <&pm6125_l8>; >> +    vdd-1.8-xo-supply = <&pm6125_l16>; >> +    vdd-1.3-rfa-supply = <&pm6125_l17>; >> +    vdd-3.3-ch0-supply = <&pm6125_l23>; >> +    status = "okay"; >> +}; >> + >>   &xo_board { >>       clock-frequency = <19200000>; >>   }; >> >