From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B432835F184 for ; Fri, 5 Jun 2026 12:31:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780662685; cv=none; b=ioIATVSxvXQNyqXYQ23imwjemlnPIaMs3QUHGp+IX0D09yztz41UqLXGF/Lfc5m+JkuPVuUXiZGbNlH7VrNF0F9fVziusTfkKuUXbuXQYGI8Gtzbd9R8EaDUcKMfyxAmi51MErjEcxqFbzLI92BZovt/O94RZevTk6oqgW/MfZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780662685; c=relaxed/simple; bh=Cco+vFiWz8nH8jHJl25YPtjf0AjyxuJKLseQuLXyV6w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mbFEZkf2GrcJmXLoU0a+FBPeLzjT0WT8xGR0n0y9p2J4iOr34JazXlrP29xIVNN9VmuYErHZ1KZR8KvZfpw8eMXLg2r6Z7XIJgsrd4fOGos1igRNT6x5UwObZ3fvlo4TUdzuSTFnVaf6V6n7CC5Dj5hAdAfGWY/pkOeIDQYcjP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=AjT+aBqW; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="AjT+aBqW" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-91563382bcfso217476385a.0 for ; Fri, 05 Jun 2026 05:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1780662683; x=1781267483; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hOWy2W3C8F0epU9cKoqDrCPhuhX/iOel8Vt4x+uvwak=; b=AjT+aBqWizkLdvUMaBbYfBh7oE5WYcRT/7yFXpMi3eDRULV1f9de9JmViVCcUmUZJ4 4Ue2vyhVsdkhp51/QSD+WPuhgK7bTf2mZnbOdKhID8F/BpmVnVZJGntk+evXbLEDdVm2 IFmp3dG74nq7yDcQS44+IjVd6QrX5wSCC+xMl/t/GCHTslzlgOzBMWz/LrHR85GS5s3l LxDFJ7DKONX+jKPCc15B52/AE9L2elODoyLShqa7LJF49mRbTwIwB/lg7cjLNg7CISG5 kuexekCd4sNp6Vmd+Ul2/+VdUvTbXQDpGyS3va0BrzHXlLXlXSp+IbakH5bmQGhFl45n pWwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780662683; x=1781267483; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hOWy2W3C8F0epU9cKoqDrCPhuhX/iOel8Vt4x+uvwak=; b=mz8RFR9JrDmM9IEewJrA9B8tcV15OgnwcVuSS/1tpo2ek/506OCScMfBppHyo6IEnf 90/Z7EOkOrmDY7uqlKG/JBt10aEtFUQNv4goUsoXFA8fGksltw85g038T+1VVBayjuQ0 CdwIUmJ+R70AhEfSSJxJ839Vr1nearr3wc36eVCAGZlW1a2iq9RgEKEFQWsHkaMIX1Zr 38aCn9DARToG2NUnKatBo8AZJcaIllx3JMjkL2X5SfsL4oUcmFl7GUkxpTDa3pjZ+yLq 690DPDKNeYtHUQBt8liSAKxfvVoeX2qKHCcl2+a7ntoGs4R6fUENU+EV3LMAv1kInYVM 85Sg== X-Forwarded-Encrypted: i=1; AFNElJ8Di6hPUV1WrNc/P7+UjCxZZkfaRygRBx1OnfBFAynaLTumpN/3F6DKmhFFOEOLmyV+NCZiPoolIGxu4WWD@vger.kernel.org X-Gm-Message-State: AOJu0Yx+CSHDerVg1NPPyQQYIPy8msVZpsJxOKgXiOyh0Fqiw5AnFEfo 0x6FTb2YixoHyvsr4ddbHHet/OEmbx/42eMn03Tp1PJV57ktdYyd4p6TqHyhKkkX79O63Ex0pUj Pgj5IQLA= X-Gm-Gg: Acq92OFtI2mr9CAIbimJddUCUAWX5AMI75shTudj/ZKZYA+V6qFHCmNBMhPmZ0P0i2y IeGaTYbU5axFFg/KiEhqKQPba8wy5jcqQcddRwr5gDtlXuYmvJr4x0Z329ti5O7DNLOk949vObL u8tbb5lBG9NJGQGQzHD60MqPK0v97AAwOe+ZtTGG84Pq0vPEmLL0bM6ewqASMhzkfcaYtv6Y6Y2 baQEWthwh3Nq3YvI5t+xFMwphr0a53doZaInpdDREo4QpQzFeMGW8pUCVX42eywSjCYANP3Z9cE VKv8cb2bzB9Sst7aheGOKCj27Dg0XAfViGVyQ6z0Mi0xLmVghaIg45br6YRONqjifpAt/Z4kmGZ jPlXj3mYab6xc4wdKRDL1i65UtQGm2xfBGW2e0fBEeGY63PayhnXsNoHg2GyGXyA+KE7DzOtxHT /ivNJ5L9Gh2oYapxJ3KnYsN8AlcEGZq9lcZnw= X-Received: by 2002:a05:6830:6685:b0:7e6:deb1:484d with SMTP id 46e09a7af769-7e70c7b1386mr1725355a34.13.1780662284484; Fri, 05 Jun 2026 05:24:44 -0700 (PDT) Received: from [172.22.22.234] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e6e7974f22sm5817653a34.25.2026.06.05.05.24.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2026 05:24:44 -0700 (PDT) Message-ID: Date: Fri, 5 Jun 2026 07:24:40 -0500 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 10/14] dt-bindings: net: toshiba,tc9654-dwmac: add TC9564 Ethernet bridge To: "Rob Herring (Arm)" Cc: weishangjuan@eswincomputing.com, linux-gpio@vger.kernel.org, inochiama@gmail.com, davem@davemloft.net, devicetree@vger.kernel.org, kuba@kernel.org, me@ziyao.cc, hawk@kernel.org, arnd@arndb.de, konradybcio@kernel.org, mohd.anwar@oss.qualcomm.com, hkallweit1@gmail.com, pabeni@redhat.com, ast@kernel.org, maxime.chevallier@bootlin.com, bpf@vger.kernel.org, boon.khai.ng@altera.com, linusw@kernel.org, andersson@kernel.org, sdf@fomichev.me, linux-kernel@vger.kernel.org, livelycarpet87@gmail.com, a0987203069@gmail.com, linux-stm32@st-md-mailman.stormreply.com, daniel@iogearbox.net, john.fastabend@gmail.com, alexandre.torgue@foss.st.com, richardcochran@gmail.com, rmk+kernel@armlinux.org.uk, krzk+dt@kernel.org, conor+dt@kernel.org, rohan.g.thomas@altera.com, gregkh@linuxfoundation.org, Daniel Thompson , chenchuangyu@xiaomi.com, andrew+netdev@lunn.ch, mcoquelin.stm32@gmail.com, edumazet@google.com, siyanteng@cqsoftware.com.cn, wens@kernel.org, brgl@kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, julianbraha@gmail.com, netdev@vger.kernel.org, chenhuacai@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com References: <20260605010022.968612-1-elder@riscstar.com> <20260605010022.968612-11-elder@riscstar.com> <178062720108.1744752.12164392208085928081.robh@kernel.org> Content-Language: en-US From: Alex Elder In-Reply-To: <178062720108.1744752.12164392208085928081.robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/4/26 9:40 PM, Rob Herring (Arm) wrote: > > On Thu, 04 Jun 2026 20:00:17 -0500, Alex Elder wrote: >> From: Daniel Thompson >> >> Add devicetree bindings for the Toshiba TC956x family of Ethernet-AVB/TSN >> bridges. >> >> The TC9564 contains a PCIe switch with one upstream and three downstream >> PCIe ports. The third PCIe downstream port has an attached embedded PCIe >> endpoint, and that endpoint implements two PCIe functions. Each internal >> PCIe function has a Synopsys XGMAC Ethernet interface capable of 10 Gbps >> operation. >> >> The TC9564 also implements an embedded GPIO controller, which exposes >> 10 lines externally. Some platforms use these GPIO lines, so this >> GPIO controller is managed by a separate driver. Other embedded >> peripherals (like a microcontroller, SRAM, and UART) are currently >> unused. >> >> The GPIO controller is managed by registers accessed via MMIO on an >> internal PCIe function's registers. >> >> Signed-off-by: Daniel Thompson >> Signed-off-by: Alex Elder >> --- >> .../bindings/net/toshiba,tc9564-dwmac.yaml | 120 ++++++++++++++++++ >> MAINTAINERS | 6 + >> 2 files changed, 126 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: Thank you for this report. After upgrading the "dtschema" package I also see these errors. The "gpio" and "ethernet" properties will have an "unevaluatedProperties: false" constraint added in the next version of this series. The name of the binding file will also be correct in the MAINTAINERS file. -Alex > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml: gpio: Missing additionalProperties/unevaluatedProperties constraint > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml: ethernet: Missing additionalProperties/unevaluatedProperties constraint > > doc reference errors (make refcheckdocs): > Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/net/toshiba,tc956x-dwmac.yaml > MAINTAINERS: Documentation/devicetree/bindings/net/toshiba,tc956x-dwmac.yaml > > See https://patchwork.kernel.org/project/devicetree/patch/20260605010022.968612-11-elder@riscstar.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >