From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanimir Varbanov Subject: Re: [PATCH v2 15/29] venus: helpers: rename a helper function and use buffer mode from caps Date: Thu, 31 May 2018 11:23:32 +0300 Message-ID: References: <20180515075859.17217-1-stanimir.varbanov@linaro.org> <20180515075859.17217-16-stanimir.varbanov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Tomasz Figa Cc: Mauro Carvalho Chehab , Hans Verkuil , Linux Media Mailing List , Linux Kernel Mailing List , linux-arm-msm , vgarodia@codeaurora.org List-Id: linux-arm-msm@vger.kernel.org Hi Tomasz, Thanks for the review! On 05/31/2018 10:59 AM, Tomasz Figa wrote: > On Tue, May 15, 2018 at 5:06 PM Stanimir Varbanov > wrote: >> >> Rename is_reg_unreg_needed() to better name is_dynamic_bufmode() and >> use buffer mode from enumerated per codec capabilities. >> >> Signed-off-by: Stanimir Varbanov >> --- >> drivers/media/platform/qcom/venus/helpers.c | 21 +++++++++++---------- >> 1 file changed, 11 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c >> index 2b21f6ed7502..1eda19adbf28 100644 >> --- a/drivers/media/platform/qcom/venus/helpers.c >> +++ b/drivers/media/platform/qcom/venus/helpers.c >> @@ -354,18 +354,19 @@ session_process_buf(struct venus_inst *inst, struct vb2_v4l2_buffer *vbuf) >> return 0; >> } >> >> -static inline int is_reg_unreg_needed(struct venus_inst *inst) >> +static inline int is_dynamic_bufmode(struct venus_inst *inst) > > nit: Could be made bool. And drop inline I guess? :) -- regards, Stan