From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cheng Jiang <quic_chejiang@quicinc.com>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
Rocky Liao <quic_rjliao@quicinc.com>
Cc: linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
quic_bt@quicinc.com
Subject: Re: [PATCH v1 2/3] dt-bindings: net: Add QCA6698 Bluetooth
Date: Thu, 28 Nov 2024 15:41:05 +0100 [thread overview]
Message-ID: <bd4cb046-f0c1-4044-897c-00f30c6e84d2@kernel.org> (raw)
In-Reply-To: <20241128120922.3518582-3-quic_chejiang@quicinc.com>
On 28/11/2024 13:09, Cheng Jiang wrote:
> Add the compatible for the Bluetooth part of the Qualcomm QCA6698 chipset.
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Respond to the comment and then implement it.
Also, version your patches correct and provide changelog. This is v2,
not v1.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-28 14:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 12:09 [PATCH v1 0/3] bluetooth: qca: Add QCA6698 Bluetooth chip Cheng Jiang
2024-11-28 12:09 ` [PATCH v1 1/3] arm64: dts: qcom: sa8775p-ride: Change the BT node Cheng Jiang
2024-11-28 14:39 ` Krzysztof Kozlowski
2024-11-29 2:47 ` Cheng Jiang (IOE)
2024-11-28 12:09 ` [PATCH v1 2/3] dt-bindings: net: Add QCA6698 Bluetooth Cheng Jiang
2024-11-28 12:58 ` Dmitry Baryshkov
2024-11-29 2:30 ` Cheng Jiang (IOE)
2024-11-29 17:13 ` Dmitry Baryshkov
2024-11-30 3:16 ` Cheng Jiang (IOE)
2024-11-28 14:41 ` Krzysztof Kozlowski [this message]
2024-11-28 14:41 ` Krzysztof Kozlowski
2024-11-29 2:13 ` Cheng Jiang (IOE)
2024-11-29 6:56 ` Krzysztof Kozlowski
2024-11-29 2:15 ` Cheng Jiang (IOE)
2024-11-28 12:09 ` [PATCH v1 3/3] Bluetooth: btqca: Add QCA6698 support Cheng Jiang
2024-11-28 13:02 ` Dmitry Baryshkov
2024-11-29 2:05 ` Cheng Jiang (IOE)
2024-11-29 17:18 ` Dmitry Baryshkov
2024-11-29 1:13 ` kernel test robot
2024-11-29 3:38 ` kernel test robot
2024-11-28 12:57 ` [PATCH v1 0/3] bluetooth: qca: Add QCA6698 Bluetooth chip Dmitry Baryshkov
2024-11-29 1:20 ` Cheng Jiang (IOE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd4cb046-f0c1-4044-897c-00f30c6e84d2@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_bt@quicinc.com \
--cc=quic_chejiang@quicinc.com \
--cc=quic_rjliao@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox