From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Karthik S <karthik.s@qss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] arm64: dts: qcom: qcs6490-rb3gen2: Add WCD headset playback and record for qcs6490-rb3gen2 industrial mezzanine
Date: Mon, 20 Apr 2026 17:43:23 +0200 [thread overview]
Message-ID: <bd832819-52b3-47e7-a16b-ed4aff16967c@kernel.org> (raw)
In-Reply-To: <vgrw3n5invft2zxmeh2gsknxvkgluqus4dfb4h2ipea7lvma4k@wrumrkki54s7>
On 18/04/2026 01:06, Dmitry Baryshkov wrote:
> On Fri, Apr 17, 2026 at 12:12:46PM +0200, Krzysztof Kozlowski wrote:
>> On 17/04/2026 11:42, Krzysztof Kozlowski wrote:
>>>
>>> And finally:
>>>
>>> Please run scripts/checkpatch.pl on the patches and fix reported
>>> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
>>> patches and (probably) fix more warnings. Some warnings can be ignored,
>>> especially from --strict run, but the code here looks like it needs a
>>> fix. Feel free to get in touch if the warning is not clear.
>>
>> As you pointed correctly after offline talk, checkpatch does not report
>> undocumented compatible for the sound card qcs6490-rb3gen2-ia-snd-card.
>>
>> Unfortunately this patch did not go through internal toolset fully
>> (PatchWise), which could have flag the issue. Let's discuss it
>> internally next week.
>>
>>>
>>> Undocumented ABI (without any reference in changelog where to find
>>> posted patch).
>> You still need to solve the undocumented sound card ABI - new
>> compatible. If it is already sent to mailing lists, then provide link in
>> patch changelog (---).
>
> Which compatible is new there? I think it is a model and not compatible.
Ahh, damn, you are right. It's not adding any new compatible.
It's fine, I got confused, no new ABI here.
Thanks Dmitry, for pointing this out.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-04-20 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 9:33 [PATCH v1] arm64: dts: qcom: qcs6490-rb3gen2: Add WCD headset playback and record for qcs6490-rb3gen2 industrial mezzanine Karthik S
2026-04-17 9:42 ` Krzysztof Kozlowski
2026-04-17 10:12 ` Krzysztof Kozlowski
2026-04-17 23:06 ` Dmitry Baryshkov
2026-04-20 15:43 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd832819-52b3-47e7-a16b-ed4aff16967c@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=karthik.s@qss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox