From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE553597A for ; Sat, 5 Apr 2025 14:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743864544; cv=none; b=rcUHXO0nwCRAYUePjk5VQq3IFfmY+piTYzHfO/yxsMAM3HwY/QtQvyueQ/xYVLfMEWgz7jJbSOA3huOIDcZDAS9atvTpiMvjVvyOOvSitBAwVTHySeJFifn+q0knduxpWhxZvGHWL3AJ4KD+Yqgahtyq/7sVX0U94YSzB+6kU4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743864544; c=relaxed/simple; bh=cMQjM++Dxc5Sp0/UX+qLKMmSrpRpvoeH0ZmSjyYi0+s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gmw1U0NjbRGp+FwlfdUOlbtiE1b9izGWkg6/9w69Vjzitwnvi7qa5kdVixpPxPWvKfsumWBZeEZUt0EzmhsFoIZgBsJL12w6T873SHHlMIVotTGkIJJPez7FsTE84lnF5/xRum3RxLxoFmm5rnkzJiEu5uIj53AhIC8omrUH+gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ic6VdYU9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ic6VdYU9" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 535DC5QX031353 for ; Sat, 5 Apr 2025 14:49:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M+PEihR5tW26XOtjKkNuGBixh9BPxadJqebcLYBJWDI=; b=ic6VdYU9A10z6CuU UoeHanu6cMwKCA3TYWexR5qTJ25J0UdLeur+q3ttTzYaSW7ZluL176OQnn4oVhHq gWLON3KUFtL/3wSgg2l1cZvhGmMf0XZ5vCmAt+rm8c6ocgs+CgM0QAAkXROW/w9T MnldOjyiloX1KHqp1vVYrHAEBztXepmsN/bBYxYnMz47POU+S0u+lYPLfBXv4uu2 mbYwjABSSw4yNJrodffY33eItMuDT84Yu2sMSsQGuogry0bUx+bZrBAEWCXLxmc2 gm1q4eDi4c98BrKVYETAk1wQBnXta6dhcghRP4r4UZn8m8XGYRsr/fzb13oaNucL VbrA7w== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45twdg8kv3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 05 Apr 2025 14:49:01 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c5f876bfe0so516798685a.3 for ; Sat, 05 Apr 2025 07:49:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743864540; x=1744469340; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M+PEihR5tW26XOtjKkNuGBixh9BPxadJqebcLYBJWDI=; b=OAl6PAubOSJOQNqku0nU2wiwOZnvMFEyfeMEbsLb7wRDr3F1oabb9tyLpVId0KH1G2 PpR835Z5raKuk6U+/G1Ytd7op+s9XXYAxVBYr2Rls5wBMHzsz6cFw1blZmN9N6HGshdT VcXyEJ6Oz55lxtC7WYNMP6nod/BoZO/MAw0JDseOTy8Gt5XQc2pNOPtV5ogCGXnoGYHf N8Q+IM6TEj1rV61R24ga7vNSUH2jDV8JYiGVIzThGVR70SK7vPcet6NPFEZvrv2HgFIg RGnENUza4G4DiKOTokAluxojk6wFuL0fZXYJs6NsTw19bdVqUJglhFIYUkQyv++Ez9Sb qltw== X-Forwarded-Encrypted: i=1; AJvYcCVP2MlDlGwMZxiqv95pDM/Ktmch2cUwmsI9+jDHS6sEBNsQRu4aDWvN1qXK4tVD9+hQ0ex0CZqcsu7XTKFb@vger.kernel.org X-Gm-Message-State: AOJu0Yx9HGZTcf/zFa7JilLxyt3IFBUgC1lbeEmMHt3OXRwmDA8NdrhS nOiM2QEGmrs87Rn6zHv7BK5Xmin/6IABwuQaHsjsWj+dPvoLY0j3sNkleMpCyBEKto6zhGyZQAT /7PfvLDowJKXzWkHmsJinRihV4clLgxwCRBsZvlBpCV0sskcKIxHwfyLeZxxALweX X-Gm-Gg: ASbGncvJ50d71DTPjBhKTnLthh3Xf9Wyf32Ms34CivEfvABwpoWqjypuDbbSxVheHe8 MiT46AUBLBjq/93Ng1l1mukuU0QrhlPxoAfi8zYAAcvDVXm/oImed8+XVhquGZMlQqR9HW2d+nK 2K5zzZXxnEOlJ0JEgo6N13IRL3WEILJ8co6z6Vk85OcXktgGRMM6uJ2VMRcKCGjhIKVDM4f8uXL OYFTFOJDvgzjduSXa8bCNMizycA3SrS8yWLb3gaVtL5Bbx5Z5//MOI0KA+ShGaRD+D6m22a7kA7 Vy0Qxmlll7F+MpiJ207Xjn3seKhdxtqMZ3UkvON1Fu7swrzDVIs6bdPkIhvD+PFg/+DqY0m9jYV xzfW2a2QDvkmsh55bkkq8TxvaddG68snAujhIN5GoIk7WkolLTNoa4lwsryGn96p/DqTM X-Received: by 2002:a05:620a:28ca:b0:7c5:d72b:1a00 with SMTP id af79cd13be357-7c77dd61ac1mr391248785a.15.1743864540350; Sat, 05 Apr 2025 07:49:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEutc1kNv9JQea/tmH5cHUtkD2IZVayC2pgcE7eKc+f/LQTGUDJVkqGd0AbWMhRe0FcVGQgsg== X-Received: by 2002:a05:620a:28ca:b0:7c5:d72b:1a00 with SMTP id af79cd13be357-7c77dd61ac1mr391246485a.15.1743864539939; Sat, 05 Apr 2025 07:48:59 -0700 (PDT) Received: from ?IPV6:2001:14bb:c4:a6bd:f097:4050:9ce6:5d7f? (2001-14bb-c4-a6bd-f097-4050-9ce6-5d7f.rev.dnainternet.fi. [2001:14bb:c4:a6bd:f097:4050:9ce6:5d7f]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54c1e670d1bsm730472e87.214.2025.04.05.07.48.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Apr 2025 07:48:59 -0700 (PDT) Message-ID: Date: Sat, 5 Apr 2025 17:48:57 +0300 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] Reup: SM8350 and SC8280XP venus support To: Vikash Garodia Cc: Bryan O'Donoghue , Stanimir Varbanov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Bjorn Andersson , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold References: <20250304-b4-linux-media-comitters-sc8280xp-venus-v1-0-279c7ea55493@linaro.org> <8cfaeb25-2657-9df4-5cea-018aad62f579@quicinc.com> <1dd6e03d-09be-4853-741a-4fb47b7619a0@quicinc.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: <1dd6e03d-09be-4853-741a-4fb47b7619a0@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=PJgP+eqC c=1 sm=1 tr=0 ts=67f142dd cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=fIlTlRh94wJvY906GsMA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: M9o5lGd-aNgb6zfqocin8GZrnoC9DmTB X-Proofpoint-GUID: M9o5lGd-aNgb6zfqocin8GZrnoC9DmTB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-05_06,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 malwarescore=0 spamscore=0 impostorscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504050093 On 04/04/2025 08:24, Vikash Garodia wrote: > Hi Dmitry, > > On 4/3/2025 10:28 PM, Dmitry Baryshkov wrote: >> On Wed, Mar 05, 2025 at 08:49:37AM +0530, Vikash Garodia wrote: >>> >>> On 3/4/2025 6:37 PM, Bryan O'Donoghue wrote: >>>> This series is a re-up of Konrad's original venus series for sc8280xp and >>>> sm8350.Why this is enabled on venus driver ? Why not iris driver ? This needs an >>> explanation on was this even tried to bring up on iris driver. >>> >>> How different is this from sm8250 which is already enabled on iris driver ? >> >> As far as I remember, SM8250 support in Iris did not reach >> feature-parity yet. So in my opinion it is fine to add new platforms to >> the Venus driver, that will later migrate to the Iris driver. > I would say, from decoder side all codecs are there now on Iris. H264 merged, > while h265 and VP9 dec are posted as RFC, there is one compliance failure which > is under debug to post them as regular patches. > If we are mainly looking for decode usecases, then we should be on Iris. No, we are not limited to the decode use case. > Preference would be to stay on Iris, otherwise we would have that extra ask to > port it later from venus to iris. Yes, but that would (hopefully) be easy to handle. >> >> Otherwise users of SC8280XP either have to use external patchsets (like >> this one) or a non-full-featured driver (and still possibly external >> patchsets, I didn't check if these two platforms can use >> qcom,sm8250-venus as a fallback compat string). > It should, atleast from the hardware spec perspective, AFAIK. >> >> Bryan, Konrad, in my opinion, let's get these patches merged :-) >> >>> >>>> Link: https://lore.kernel.org/all/20230731-topic-8280_venus-v1-0-8c8bbe1983a5@linaro.org/ >>>> >>>> The main obstacle to merging that series at the time was the longstanding >>>> but invalid usage of "video-encoder" and "video-decoder" which is a >>>> driver level configuration option not a description of hardware. >>>> >>>> Following on from that discussion a backwards compatible means of >>>> statically selecting transcoder mode was upstreamed >>>> >>>> commit: 687bfbba5a1c ("media: venus: Add support for static video encoder/decoder declarations") >>>> >>>> Reworking this series from Konrad to incorporate this simple change >>>> >> > Regards, > Vikash -- With best wishes Dmitry