From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/3] clk: qcom: common: Add support for power-domain attachment
Date: Wed, 11 Dec 2024 14:54:08 +0000 [thread overview]
Message-ID: <beaf4e8a-51a5-431e-8538-269d2db94f15@linaro.org> (raw)
In-Reply-To: <fca39cde-b9c8-4f1d-a4d0-92a1d739b57f@linaro.org>
On 11/12/2024 13:36, Vladimir Zapolskiy wrote:
>> + struct dev_pm_domain_attach_data pd_data = {
>> + .pd_names = 0,
>> + .num_pd_names = 0,
>> + };
>
> Please remove the added local variable.
>
>> cc = devm_kzalloc(dev, sizeof(*cc), GFP_KERNEL);
>> if (!cc)
>> return -ENOMEM;
>> + ret = devm_pm_domain_attach_list(dev, &pd_data, &cc->pd_list);
>
> Please simplify it to
>
> ret = devm_pm_domain_attach_list(dev, NULL, &cc->pd_list);
My apologies, I cherry-picked the wrong version of this patch from my
working tree to my b4/send tree.
---
bod
next prev parent reply other threads:[~2024-12-11 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 0:27 [PATCH v7 0/3] clk: qcom: Add support for multiple power-domains for a clock controller Bryan O'Donoghue
2024-12-11 0:27 ` [PATCH v7 1/3] clk: qcom: gdsc: Capture pm_genpd_add_subdomain result code Bryan O'Donoghue
2024-12-11 0:27 ` [PATCH v7 2/3] clk: qcom: common: Add support for power-domain attachment Bryan O'Donoghue
2024-12-11 13:36 ` Vladimir Zapolskiy
2024-12-11 14:54 ` Bryan O'Donoghue [this message]
2024-12-11 0:27 ` [PATCH v7 3/3] clk: qcom: Support attaching GDSCs to multiple parents Bryan O'Donoghue
2024-12-11 13:15 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beaf4e8a-51a5-431e-8538-269d2db94f15@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox