From: Hemant Kumar <hemantk@codeaurora.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, jhugo@codeaurora.org,
bbhatt@codeaurora.org, loic.poulain@linaro.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v13 4/4] bus: mhi: Add userspace client interface driver
Date: Mon, 30 Nov 2020 17:08:23 -0800 [thread overview]
Message-ID: <becbd9ac-09a1-1ce7-7fdb-333a302601cb@codeaurora.org> (raw)
In-Reply-To: <20201128061117.GJ3077@thinkpad>
Hi Mani,
On 11/27/20 10:11 PM, Manivannan Sadhasivam wrote:
> Hi Hemant,
>
> On Fri, Nov 27, 2020 at 07:26:06PM -0800, Hemant Kumar wrote:
>> This MHI client driver allows userspace clients to transfer
>> raw data between MHI device and host using standard file operations.
>> Driver instantiates UCI device object which is associated to device
>> file node. UCI device object instantiates UCI channel object when device
>> file node is opened. UCI channel object is used to manage MHI channels
>> by calling MHI core APIs for read and write operations. MHI channels
>> are started as part of device open(). MHI channels remain in start
>> state until last release() is called on UCI device file node. Device
>> file node is created with format
>>
>> /dev/mhi_<mhi_device_name>
>>
>> Currently it supports QMI channel.
>>
>
> Thanks for the update. This patch looks good to me. But as I'm going to
> apply Loic's "bus: mhi: core: Indexed MHI controller name" patch, you
> need to update the documentation accordingly.
This is what i added in documentation on v13
Device file node is created with format:-
/dev/mhi_<mhi_device_name>
mhi_device_name includes mhi controller name and the name of the MHI
channel being used by MHI client in userspace to send or receive data
using MHI protocol.
Loic's patch is going to update the controller name as indexed
controller name, which goes fine with or without his change going first.
For example: With Loic's change name of device node would be
/dev/mhi_mhi0_QMI
Without Loic's change it would be
/dev/mhi_0000:00:01.2_QMI
Please let me know if i am missing something.
Thanks,
Hemant
>
>> Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Thanks,
> Mani
>
[..]
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-12-01 1:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 3:26 [PATCH v13 0/4] userspace MHI client interface driver Hemant Kumar
2020-11-28 3:26 ` [PATCH v13 1/4] bus: mhi: core: Add helper API to return number of free TREs Hemant Kumar
2020-11-28 3:26 ` [PATCH v13 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file Hemant Kumar
2020-11-28 3:26 ` [PATCH v13 3/4] docs: Add documentation for userspace client interface Hemant Kumar
2020-11-28 3:26 ` [PATCH v13 4/4] bus: mhi: Add userspace client interface driver Hemant Kumar
2020-11-28 6:11 ` Manivannan Sadhasivam
2020-12-01 1:08 ` Hemant Kumar [this message]
2020-11-30 18:22 ` Loic Poulain
2020-12-01 1:16 ` Hemant Kumar
2020-12-01 17:36 ` Loic Poulain
2020-12-01 17:37 ` Jeffrey Hugo
2020-12-01 17:52 ` Loic Poulain
2020-12-01 17:51 ` Jeffrey Hugo
2020-12-01 18:05 ` Loic Poulain
2020-12-01 18:04 ` Jeffrey Hugo
2020-12-01 21:59 ` Hemant Kumar
2020-12-01 19:29 ` [PATCH v13 0/4] userspace MHI " Jakub Kicinski
2020-12-01 19:40 ` Jeffrey Hugo
2020-12-01 20:03 ` Jakub Kicinski
2020-12-01 20:48 ` Jeffrey Hugo
2020-12-02 2:55 ` Jakub Kicinski
2020-12-02 4:59 ` Jeffrey Hugo
2020-12-06 8:33 ` Leon Romanovsky
2020-12-08 16:59 ` Manivannan Sadhasivam
2020-12-08 19:16 ` Leon Romanovsky
2020-12-02 4:15 ` Manivannan Sadhasivam
2020-12-02 4:38 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=becbd9ac-09a1-1ce7-7fdb-333a302601cb@codeaurora.org \
--to=hemantk@codeaurora.org \
--cc=bbhatt@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).