From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4B1A236A9F for ; Mon, 23 Jun 2025 09:31:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750671113; cv=none; b=Uqybq6voNaOqcu4UTNawPI/otpEFoNKFFphgM008Vw35qIhrK7iyttsRDAxl0IcqbToIzOn5vHVqCFDGkwKmZJ86WKdsi5KpXdSMQHK/EHUMU2JHYlWk159759jjZxsGVnOak4OcH6lSLSJ5MOtE2xjRrEZkJt8Gn4gHLkFhdfU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750671113; c=relaxed/simple; bh=jBkECa9RVZ+l2pdBEqTlTVtcmeZGky2J0XHjAXvpFIQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=jrj/AuaHt9Gdkj+xyfV/ap8zG9Vd+wcVKFGEat9TqqUG70VlR98JdfQK+PVGpKVUvjba8xsrNXNGRx+bDh0pwWidjN5ueneHybxPPoi3uhDmFDfmSGjuQOWKpliBzB7+b8AZFb6MWZJsY2XsQZ9kaOAgRMJzR4Y9cyEiOmfxBpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cBPXhvo2; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cBPXhvo2" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4535fbe0299so20068465e9.3 for ; Mon, 23 Jun 2025 02:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750671109; x=1751275909; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=hwwKos7qPkEDfzDF1aNvUABLMH1ha0PD0/gSjYFHfWE=; b=cBPXhvo29QL1+cIKDBDHoKHuU9N7p2XScHs48MVpCtXL9kq5i34avUKPjN1Nm2txg5 6nOvkrY5OxLji3PkFDrRv4Bt28gmEGWuyqkwn/Aalwdm2NKOfLf1zwyyDL0ee/dfGaNH 2ZafJE4Yc5WYQZ1LHOpyzwf51WFcez62H2+Mh+LUgVAOnM8OTwD848NQ9kj0ZLqP1YmB TePDXZgV2EDPvBiGEM5JttPBw2U6Hbog02WealCTnUlOVBaiJ24y3Ljas6vTtL1QasmA OafQj0/G2v0d/B679LcwvKlCjWsQtbyPCyLnmgnR64ZhS8q+voXJU/a3hBKl8vQVyyti TTfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750671109; x=1751275909; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=hwwKos7qPkEDfzDF1aNvUABLMH1ha0PD0/gSjYFHfWE=; b=MEcrd9gFUp1Cx20Z9UCPCIOXiNf3aYS4ztmmiHIVRp+o/t1KsInqHBPButAb90Ge3Y N8Ttti9sC9Kgdg/c+d2KqNuHGqqfHhBE5i9Jnjjh/IQpeiIlfH675LVICWel5yf+7Lzx 2tgXnGXAHHVrrmqLzdU+ImVsO9mN01sCkqIYu7K2tp5xTtWQdV+fLhoAyYXxmNJoh3jZ PCbduFVSLSBDLo2ZSJ7Qnmvulr2y5NYavMAUSgdO1T2YRyIbJBltEFzhaVptsadprhXO jodeJduFIVzkxVKzwtmH+4aqj3v1blCowOjItTMUbLTW83xS3HAF2SD2ZgmIvet49vO8 ijsg== X-Forwarded-Encrypted: i=1; AJvYcCVfFvKR8vu/wHTaQbhrZPdHsEP6N+s6firC+zwPOpNxuVeyqZXPwpBMxWLKbqjx7ZXxSnTXqr+3AfX65nk+@vger.kernel.org X-Gm-Message-State: AOJu0YwFqWOzXeSl+F/Bg93ATzwI4YPqmTqWJ2JbBKi36of1LfIaJcja 29nXS3HdnX3mjNjD1VqJIKhtp8Ii+5BYOc2EMz6VP3t1vPk6FBGxVsYyx1yOHc/XvGM= X-Gm-Gg: ASbGncveE0mpEfRp8YihhYSMynLr4vx0B4bsd+PSakOUQ+0p5yvwxAN4Yk8t6C0MckP QT7B8odDcbO1tlS5RcCpS0HxtBKPtAtf9WvSxCeHxn6em51xRkorGlEuRe30bEm+AMTOH33oSmg 3a/+6+udxuFDYXATKeYyNifAtj8ZM8QsPyzjiRv619EKw7Km8iO8GTmhULVJnX35xcbb+fnDigP gtysZrBTlT4rrIG2/sLz9jgW0juGdUpcqxEzKQLIeWcrNwFbjOh1JQvBh7oXxS4+F7x2n3p/Lip qeqUmXUQYuHYHfVaMtARIn1kjYR8P/cl6as+M3uFaG4qES+sIZZCc2xNjDiHXDsCuil1fDHrUre i9azzq8s0NFXZ4b9wTrf0lTmbfYgjrlPFqszkurV1/2uJ7hMCaQ== X-Google-Smtp-Source: AGHT+IFBqwtFTrV2RJJWLnfSwBkn+cHmN5bYqxTgZf0F7hFiKkS8UhH3g7wssfa8DtWBEnCbVdLBZg== X-Received: by 2002:a05:600c:1caa:b0:442:f4a3:9388 with SMTP id 5b1f17b1804b1-453659ec1cemr95163195e9.19.1750671109073; Mon, 23 Jun 2025 02:31:49 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:8c08:7c51:bbb1:5a2d? ([2a01:e0a:3d9:2080:8c08:7c51:bbb1:5a2d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4536466596asm108289945e9.0.2025.06.23.02.31.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 02:31:48 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2025 11:31:48 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 09/10] [RFT] arm64: dts: qcom: sm8250: extend CAMSS with new CSIPHY subdevices To: Vladimir Zapolskiy , Krzysztof Kozlowski , Rob Herring , Bjorn Andersson , Konrad Dybcio , Bryan O'Donoghue Cc: Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org References: <20250612011531.2923701-1-vladimir.zapolskiy@linaro.org> <20250612011531.2923701-10-vladimir.zapolskiy@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250612011531.2923701-10-vladimir.zapolskiy@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/06/2025 03:15, Vladimir Zapolskiy wrote: > Following the new device tree bindings for CAMSS IPs introduce csiphy2 > device tree node under SM8250 CAMSS, which allows to perform camera > tests of the model on an RB5 board with an attached vision mezzanine. > > Note that the optional 'phys' property is deliberately not added. > > Signed-off-by: Vladimir Zapolskiy > --- > For testing only, do not merge. > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index f0d18fd37aaf..401a32679580 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -4613,6 +4613,10 @@ camss: camss@ac6a000 { > "cam_sf_0_mnoc", > "cam_sf_icp_mnoc"; > > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > ports { > #address-cells = <1>; > #size-cells = <0>; > @@ -4641,6 +4645,16 @@ port@5 { > reg = <5>; > }; > }; > + > + csiphy2: phy@ac6e000 { > + compatible = "qcom,csiphy"; > + reg = <0 0x0ac6e000 0 0x1000>; > + clocks = <&camcc CAM_CC_CSIPHY2_CLK>, > + <&camcc CAM_CC_CSI2PHYTIMER_CLK>; > + clock-names = "csiphy", "csiphy_timer"; > + interrupts = ; > + #phy-cells = <0>; > + }; I would've expected the CSI PHY nodes to be out of the camss node, why would you keep them as subnodes since you would reference them via phys phandles ? Neil > }; > > camcc: clock-controller@ad00000 {