From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Marc Gonzalez <mgonzalez@freebox.fr>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Douglas Anderson <dianders@chromium.org>,
Pierre-Hugues Husson <phhusson@freebox.fr>,
Arnaud Vrac <avrac@freebox.fr>
Subject: Re: [PATCH] clk: qcom: mmcc-msm8998: fix vdec low-power mode
Date: Wed, 10 Apr 2024 00:36:59 +0100 [thread overview]
Message-ID: <bf1d7f35-e109-48a3-8e95-e35a5b09b809@linaro.org> (raw)
In-Reply-To: <c427e89e-7ec6-472e-8ba8-65d5721df62b@freebox.fr>
On 09/04/2024 16:56, Marc Gonzalez wrote:
> Use same code as mmcc-msm8996 with:
> s/venus_gdsc/video_top_gdsc/
> s/venus_core0_gdsc/video_subcore0_gdsc/
>
> https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/include/dt-bindings/clock/msm-clocks-hwio-8996.h
> https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/include/dt-bindings/clock/msm-clocks-hwio-8998.h
>
> 0x1024 = MMSS_VIDEO GDSCR (undocumented)
> 0x1028 = MMSS_VIDEO_CORE_CBCR
> 0x1030 = MMSS_VIDEO_AHB_CBCR
> 0x1034 = MMSS_VIDEO_AXI_CBCR
> 0x1038 = MMSS_VIDEO_MAXI_CBCR
> 0x1040 = MMSS_VIDEO_SUBCORE0 GDSCR (undocumented)
> 0x1044 = MMSS_VIDEO_SUBCORE1 GDSCR (undocumented)
> 0x1048 = MMSS_VIDEO_SUBCORE0_CBCR
> 0x104c = MMSS_VIDEO_SUBCORE1_CBCR
>
> Suggested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
I think you should explain what this commit is for and why its needed.
Switching on additional GDSC registers that the top/subcore0 and
subcore1 depend on, instead of just saying "copy the code from 8996".
With that fixed.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2024-04-09 23:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 15:56 [PATCH] clk: qcom: mmcc-msm8998: fix vdec low-power mode Marc Gonzalez
2024-04-09 23:36 ` Bryan O'Donoghue [this message]
2024-04-10 11:18 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf1d7f35-e109-48a3-8e95-e35a5b09b809@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=avrac@freebox.fr \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mgonzalez@freebox.fr \
--cc=mturquette@baylibre.com \
--cc=phhusson@freebox.fr \
--cc=quic_jhugo@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox