From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E4D032ED27 for ; Tue, 28 Apr 2026 16:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777394853; cv=none; b=eV2Js2xSMjlpxFOS41vmTzFAHTlRQUulCwyjo0e5gPTrLrF6+ike0R4gec9szO8OZVZOEpazFmp/nXlbER3dIghyGX4sfFs22632/8y7xfB/pJrmMjKK5uWXnkrBwjEntNpzqWAl7hjk6AvuZc/rh5Loa2uwTNS1udBN14hJCRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777394853; c=relaxed/simple; bh=9S9GoA2wdMOKBwQUq6uU4RsjDD9B9w9gbFBChUNcp5Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BJnZlt9NOyXffvP78fRQ38ezUiTU1azCqEY7d9Y6a0YW+qZBUgSel//Vh96QQ5tlxS79q+0tKHpk34Ttgkmh1wE9+gxLzt59ge8V1D6c3Ql57kZrFZw9LgL+h0wu3c2ZO6pZF83GHKjBgJjK0R26KLVwOPHWZrIBmJVWHp39WQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ieee.org; spf=pass smtp.mailfrom=ieee.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b=XfiIGnuM; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ieee.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ieee.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b="XfiIGnuM" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-4042fe53946so5208365fac.3 for ; Tue, 28 Apr 2026 09:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1777394849; x=1777999649; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lsaS50fJFWEgKS/X3mmwXYg/L5d5/h6qIX6nFemmP8U=; b=XfiIGnuMwfnSZxVU2xMgiQkpcZx9aOzJFtBz/g7B0AIMVtPkX6kMu59YPBadlEyBuM FQF2p+kRwFoecg5nfEGOocMnL5tUqrba1mQGA9Vfuqpjh/BsagGOYnQzCwHt7+h5XFOb xfmVVCQ4cXKEpESLS4Di0RDcO629CVyZPLD6k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777394849; x=1777999649; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lsaS50fJFWEgKS/X3mmwXYg/L5d5/h6qIX6nFemmP8U=; b=IDanCJ4dEQ//izq1jNdNrrQaLrC+EK4likidOhIXeN3W2rFkLMMDm8bPkIVovoIUfm Vi0KlVaxSr/2w/rtrjYWPXOVjPlKCNdGtercNdHig4/gL07doNyzprRSuNsqzc1unKYW nrZ0BmneYHHa50lEwLHhjw1yFaaQ0Eq3q168aSDr+I08C+LFWL68S7LwFmFVxDlPfo53 Wd3FzlriU2ycT2XllYx5B0wUhZxxFRIlI/K6mzhrfCRrXRt9kdmytY1U8zSqOsOwImHa 5PJKGf35DmzRVRHCCa/ul1La4LsMv7UBGti+t6a3ika7rWFWlIha3VU6yk7HVvZEg4Lh 5deg== X-Forwarded-Encrypted: i=1; AFNElJ96thkGVsmTk+k3FHAX9nEVRM5KM8MZDeSGF6S+hz1HNk2ikPJQ6tiyDksMe7mwAUg4RO5AqpsuX5gq8yFZ@vger.kernel.org X-Gm-Message-State: AOJu0YykrJESzkW428tPwPuYTA9Qq8CHAaBf+3c/BIOfGGqgSV4myTWX V1S+pLdz2RyCcq2OlzbHU7S4u6aRMr3bvZUjqKEohO7Dep6ofL/s4g3GiOyzEue26cur6wH7Y0j a5f84x/Gh X-Gm-Gg: AeBDies3Uj8uIoVbYfTTQdEgU1/JIB81a+aqJ9SPgi0tY6C9aUjEKLi3bl4C7bL7dYi JYDxJhVAkcNfxvIfrDgXLRH317jNO2egdFgJuVZM0r0SOTuJ4LdyvyhSCbZEloQ3RIEmh2RRBio Dn8HJDoQ/VDbHcKqvk8d03gsnyAAY2O/RpzZFl6zC/Ke1zdbw9ZSBpX3hveFhYTAOtulpXA2S7d rjExaS5cCqph2i5ehgguXvGKtYgf/NeWTpeD/QSbNTsSS0yjZggTp+z+EzmuP23kVnIjC3gCqw7 LLNA1bCSXG+7W1pIV1dGICbikAiEdf5hpCXEIDGH+KPVy+Z/Q/As3XcQkE2DfK2Ou1hhrOU5EIl vnhy4qfSc5sr94Ej5Q/9mnUBGX+gqbAw8yFHlkb8DqytvvKF4oXtVW4xCGx+WKfM46SvzJqe0HU 60La5+WmiSt3IRH5MKbcHyATI2iwF8fGBwMe2HDECCIRvdx6Gy/NlDMg/iwXHHZcyPsYG5 X-Received: by 2002:a05:6871:e78f:b0:42f:ba47:36f5 with SMTP id 586e51a60fabf-433f396963emr2135147fac.17.1777394849189; Tue, 28 Apr 2026 09:47:29 -0700 (PDT) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-433efbf1d8dsm2255892fac.6.2026.04.28.09.47.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 09:47:28 -0700 (PDT) Message-ID: Date: Tue, 28 Apr 2026 11:47:26 -0500 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] net: ipa: Use the unified QMI service ID instead of defining it locally To: Daniel Lezcano , konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org, Dmitry Baryshkov References: <20260316171419.2619620-1-daniel.lezcano@oss.qualcomm.com> <20260316171419.2619620-2-daniel.lezcano@oss.qualcomm.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20260316171419.2619620-2-daniel.lezcano@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/16/26 12:14 PM, Daniel Lezcano wrote: > Instead of defining a local macro with a custom name for the QMI > service identifier, use the one provided in qmi.h and remove the > locally defined macro. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Daniel Lezcano Looks good! Reviewed-by: Alex Elder > --- > drivers/net/ipa/ipa_qmi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ipa/ipa_qmi.c b/drivers/net/ipa/ipa_qmi.c > index d771f3a71f94..37936ad132a2 100644 > --- a/drivers/net/ipa/ipa_qmi.c > +++ b/drivers/net/ipa/ipa_qmi.c > @@ -66,11 +66,9 @@ > * determination of when things are "ready" > */ > > -#define IPA_HOST_SERVICE_SVC_ID 0x31 > #define IPA_HOST_SVC_VERS 1 > #define IPA_HOST_SERVICE_INS_ID 1 > > -#define IPA_MODEM_SERVICE_SVC_ID 0x31 > #define IPA_MODEM_SERVICE_INS_ID 2 > #define IPA_MODEM_SVC_VERS 1 > > @@ -484,7 +482,7 @@ int ipa_qmi_setup(struct ipa *ipa) > if (ret) > return ret; > > - ret = qmi_add_server(&ipa_qmi->server_handle, IPA_HOST_SERVICE_SVC_ID, > + ret = qmi_add_server(&ipa_qmi->server_handle, QMI_SERVICE_ID_IPA, > IPA_HOST_SVC_VERS, IPA_HOST_SERVICE_INS_ID); > if (ret) > goto err_server_handle_release; > @@ -501,7 +499,7 @@ int ipa_qmi_setup(struct ipa *ipa) > /* We need this ready before the service lookup is added */ > INIT_WORK(&ipa_qmi->init_driver_work, ipa_client_init_driver_work); > > - ret = qmi_add_lookup(&ipa_qmi->client_handle, IPA_MODEM_SERVICE_SVC_ID, > + ret = qmi_add_lookup(&ipa_qmi->client_handle, QMI_SERVICE_ID_IPA, > IPA_MODEM_SVC_VERS, IPA_MODEM_SERVICE_INS_ID); > if (ret) > goto err_client_handle_release;