From mboxrd@z Thu Jan 1 00:00:00 1970 From: abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org Subject: Re: [DPU PATCH 10/11] drm/msm: Switch to atomic_helper_commit() Date: Thu, 08 Mar 2018 19:28:08 -0800 Message-ID: References: <20180228191906.185417-1-seanpaul@chromium.org> <20180228191906.185417-11-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180228191906.185417-11-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sean Paul Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-msm-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gMjAxOC0wMi0yOCAxMToxOSwgU2VhbiBQYXVsIHdyb3RlOgo+IE5vdyB0aGF0IGFsbCBvZiB0 aGUgbXNtLXNwZWNpZmljIGdvbyBpcyB0dWNrZWQgc2FmZWx5IGF3YXkgd2UgY2FuIAo+IHN3aXRj aAo+IG92ZXIgdG8gdXNpbmcgdGhlIGF0b21pYyBoZWxwZXIgY29tbWl0IGRpcmVjdGx5LiBcby8K PiAKW0FiaGluYXZdIENhbiB3ZSBzYXkgc29tZXRoaW5nIGxpa2UgIk1vdmUgcmVtYWluaW5nIG1z bS1zcGVjaWZpYyAKb3BlcmF0aW9ucyB0byBwcml2YXRlIGhhbmRsZXMgYW5kIHN3aXRjaCB0byBh dG9taWMgaGVscGVyIGNvbW1pdCBmb3IgdGhlIApyZXN0LgoKPiBDaGFuZ2UtSWQ6IEllYWIwYmQw YzUyNmIyYTlkM2IzMzQ1ZWViYTQwMmFjNDg1N2ZlNDE4Cj4gU2lnbmVkLW9mZi1ieTogU2VhbiBQ YXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20v bXNtX2F0b21pYy5jIHwgMTIwICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJp dmVycy9ncHUvZHJtL21zbS9tc21fZHJ2LmMgICAgfCAgIDcgKy0KPiAgZHJpdmVycy9ncHUvZHJt L21zbS9tc21fZHJ2LmggICAgfCAgIDMgKy0KPiAgMyBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlv bnMoKyksIDEyMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L21zbS9tc21fYXRvbWljLmMgCj4gYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9hdG9taWMuYwo+ IGluZGV4IDIwNGM2NmNiZmQzMS4uOTFmZmRlZDU3NmQ4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9tc20vbXNtX2F0b21pYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9tc21f YXRvbWljLmMKPiBAQCAtMTgsOCArMTgsNiBAQAo+IAo+ICAjaW5jbHVkZSAibXNtX2Rydi5oIgo+ ICAjaW5jbHVkZSAibXNtX2ttcy5oIgo+IC0jaW5jbHVkZSAibXNtX2dlbS5oIgo+IC0jaW5jbHVk ZSAibXNtX2ZlbmNlLmgiCj4gCj4gIHN0YXRpYyB2b2lkIG1zbV9hdG9taWNfd2FpdF9mb3JfY29t bWl0X2RvbmUoCj4gIAkJc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiBAQCAtMzksNyArMzcsNyBA QCBzdGF0aWMgdm9pZCBtc21fYXRvbWljX3dhaXRfZm9yX2NvbW1pdF9kb25lKAo+ICAJfQo+ICB9 Cj4gCj4gLXN0YXRpYyB2b2lkIG1zbV9hdG9taWNfY29tbWl0X3RhaWwoc3RydWN0IGRybV9hdG9t aWNfc3RhdGUgKnN0YXRlKQo+ICt2b2lkIG1zbV9hdG9taWNfY29tbWl0X3RhaWwoc3RydWN0IGRy bV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0g c3RhdGUtPmRldjsKPiAgCXN0cnVjdCBtc21fZHJtX3ByaXZhdGUgKnByaXYgPSBkZXYtPmRldl9w cml2YXRlOwo+IEBAIC04MSwxMTkgKzc5LDMgQEAgc3RhdGljIHZvaWQgbXNtX2F0b21pY19jb21t aXRfdGFpbChzdHJ1Y3QKPiBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAKPiAgCWttcy0+ZnVu Y3MtPmNvbXBsZXRlX2NvbW1pdChrbXMsIHN0YXRlKTsKPiAgfQo+IC0KPiAtLyogVGhlIChwb3Rl bnRpYWxseSkgYXN5bmNocm9ub3VzIHBhcnQgb2YgdGhlIGNvbW1pdC4gIEF0IHRoaXMgcG9pbnQK PiAtICogbm90aGluZyBjYW4gZmFpbCBzaG9ydCBvZiBhcm1hZ2VkZG9uLgo+IC0gKi8KPiAtc3Rh dGljIHZvaWQgY29tbWl0X3RhaWwoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+IC17 Cj4gLQlkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9mZW5jZXMoc3RhdGUtPmRldiwgc3RhdGUs IGZhbHNlKTsKPiAtCj4gLQlkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9kZXBlbmRlbmNpZXMo c3RhdGUpOwo+IC0KPiAtCW1zbV9hdG9taWNfY29tbWl0X3RhaWwoc3RhdGUpOwo+IC0KPiAtCWRy bV9hdG9taWNfaGVscGVyX2NvbW1pdF9jbGVhbnVwX2RvbmUoc3RhdGUpOwo+IC0KPiAtCWRybV9h dG9taWNfc3RhdGVfcHV0KHN0YXRlKTsKPiAtfQo+IC0KPiAtc3RhdGljIHZvaWQgY29tbWl0X3dv cmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+IC17Cj4gLQlzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSAqc3RhdGUgPSBjb250YWluZXJfb2Yod29yaywKPiAtCQkJCQkJICAgICAgc3RydWN0IGRy bV9hdG9taWNfc3RhdGUsCj4gLQkJCQkJCSAgICAgIGNvbW1pdF93b3JrKTsKPiAtCWNvbW1pdF90 YWlsKHN0YXRlKTsKPiAtfQo+IC0KPiAtLyoqCj4gLSAqIGRybV9hdG9taWNfaGVscGVyX2NvbW1p dCAtIGNvbW1pdCB2YWxpZGF0ZWQgc3RhdGUgb2JqZWN0Cj4gLSAqIEBkZXY6IERSTSBkZXZpY2UK PiAtICogQHN0YXRlOiB0aGUgZHJpdmVyIHN0YXRlIG9iamVjdAo+IC0gKiBAbm9uYmxvY2s6IG5v bmJsb2NraW5nIGNvbW1pdAo+IC0gKgo+IC0gKiBUaGlzIGZ1bmN0aW9uIGNvbW1pdHMgYSB3aXRo IGRybV9hdG9taWNfaGVscGVyX2NoZWNrKCkgCj4gcHJlLXZhbGlkYXRlZCBzdGF0ZQo+IC0gKiBv YmplY3QuIFRoaXMgY2FuIHN0aWxsIGZhaWwgd2hlbiBlLmcuIHRoZSBmcmFtZWJ1ZmZlciByZXNl cnZhdGlvbiAKPiBmYWlscy4KPiAtICoKPiAtICogUkVUVVJOUwo+IC0gKiBaZXJvIGZvciBzdWNj ZXNzIG9yIC1lcnJuby4KPiAtICovCj4gLWludCBtc21fYXRvbWljX2NvbW1pdChzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LAo+IC0JCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwgYm9vbCBu b25ibG9jaykKPiAtewo+IC0Jc3RydWN0IG1zbV9kcm1fcHJpdmF0ZSAqcHJpdiA9IGRldi0+ZGV2 X3ByaXZhdGU7Cj4gLQlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4gLQlzdHJ1Y3QgZHJtX2NydGNf c3RhdGUgKmNydGNfc3RhdGU7Cj4gLQlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZTsKPiAtCXN0cnVj dCBkcm1fcGxhbmVfc3RhdGUgKm9sZF9wbGFuZV9zdGF0ZSwgKm5ld19wbGFuZV9zdGF0ZTsKPiAt CWludCBpLCByZXQ7Cj4gLQo+IC0JLyoKPiAtCSAqIE5vdGUgdGhhdCBwbGFuZS0+YXRvbWljX2Fz eW5jX2NoZWNrKCkgc2hvdWxkIGZhaWwgaWYgd2UgbmVlZAo+IC0JICogdG8gcmUtYXNzaWduIGh3 cGlwZSBvciBhbnl0aGluZyB0aGF0IHRvdWNoZXMgZ2xvYmFsIGF0b21pYwo+IC0JICogc3RhdGUs IHNvIHdlJ2xsIG5ldmVyIGdvIGRvd24gdGhlIGFzeW5jIHVwZGF0ZSBwYXRoIGluIHRob3NlCj4g LQkgKiBjYXNlcy4KPiAtCSAqLwo+IC0JaWYgKHN0YXRlLT5hc3luY191cGRhdGUpIHsKPiAtCQly ZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9wcmVwYXJlX3BsYW5lcyhkZXYsIHN0YXRlKTsKPiAtCQlp ZiAocmV0KQo+IC0JCQlyZXR1cm4gcmV0Owo+IC0KPiAtCQlkcm1fYXRvbWljX2hlbHBlcl9hc3lu Y19jb21taXQoZGV2LCBzdGF0ZSk7Cj4gLQkJZHJtX2F0b21pY19oZWxwZXJfY2xlYW51cF9wbGFu ZXMoZGV2LCBzdGF0ZSk7Cj4gLQkJcmV0dXJuIDA7Cj4gLQl9Cj4gLQo+IC0JcmV0ID0gZHJtX2F0 b21pY19oZWxwZXJfc2V0dXBfY29tbWl0KHN0YXRlLCBub25ibG9jayk7Cj4gLQlpZiAocmV0KQo+ IC0JCXJldHVybiByZXQ7Cj4gLQo+IC0JSU5JVF9XT1JLKCZzdGF0ZS0+Y29tbWl0X3dvcmssIGNv bW1pdF93b3JrKTsKPiAtCj4gLQlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9wcmVwYXJlX3BsYW5l cyhkZXYsIHN0YXRlKTsKPiAtCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiAtCj4gLQlpZiAo IW5vbmJsb2NrKSB7Cj4gLQkJcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfd2FpdF9mb3JfZmVuY2Vz KGRldiwgc3RhdGUsIHRydWUpOwo+IC0JCWlmIChyZXQpCj4gLQkJCWdvdG8gZXJyb3I7Cj4gLQl9 Cj4gLQo+IC0JLyoKPiAtCSAqIFRoaXMgaXMgdGhlIHBvaW50IG9mIG5vIHJldHVybiAtIGV2ZXJ5 dGhpbmcgYmVsb3cgbmV2ZXIgZmFpbHMgCj4gZXhjZXB0Cj4gLQkgKiB3aGVuIHRoZSBodyBnb2Vz IGJvbmdoaXRzLiBXaGljaCBtZWFucyB3ZSBjYW4gY29tbWl0IHRoZSBuZXcgc3RhdGUgCj4gb24K PiAtCSAqIHRoZSBzb2Z0d2FyZSBzaWRlIG5vdy4KPiAtCSAqCj4gLQkgKiBzd2FwIGRyaXZlciBw cml2YXRlIHN0YXRlIHdoaWxlIHN0aWxsIGhvbGRpbmcgc3RhdGVfbG9jawo+IC0JICovCj4gLQlC VUdfT04oZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0ZShzdGF0ZSwgZmFsc2UpIDwgMCk7Cj4g LQo+IC0JLyoKPiAtCSAqIEV2ZXJ5dGhpbmcgYmVsb3cgY2FuIGJlIHJ1biBhc3luY2hyb25vdXNs eSB3aXRob3V0IHRoZSBuZWVkIHRvIAo+IGdyYWIKPiAtCSAqIGFueSBtb2Rlc2V0IGxvY2tzIGF0 IGFsbCB1bmRlciBvbmUgY29uZGl0aW9uczogSXQgbXVzdCBiZSAKPiBndWFyYW50ZWVkCj4gLQkg KiB0aGF0IHRoZSBhc3luY2hyb25vdXMgd29yayBoYXMgZWl0aGVyIGJlZW4gY2FuY2VsbGVkIChp ZiB0aGUgCj4gZHJpdmVyCj4gLQkgKiBzdXBwb3J0cyBpdCwgd2hpY2ggYXQgbGVhc3QgcmVxdWly ZXMgdGhhdCB0aGUgZnJhbWVidWZmZXJzIGdldAo+IC0JICogY2xlYW5lZCB1cCB3aXRoIGRybV9h dG9taWNfaGVscGVyX2NsZWFudXBfcGxhbmVzKCkpIG9yIGNvbXBsZXRlZAo+IC0JICogYmVmb3Jl IHRoZSBuZXcgc3RhdGUgZ2V0cyBjb21taXR0ZWQgb24gdGhlIHNvZnR3YXJlIHNpZGUgd2l0aAo+ IC0JICogZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0ZSgpLgo+IC0JICoKPiAtCSAqIFRoaXMg c2NoZW1lIGFsbG93cyBuZXcgYXRvbWljIHN0YXRlIHVwZGF0ZXMgdG8gYmUgcHJlcGFyZWQgYW5k Cj4gLQkgKiBjaGVja2VkIGluIHBhcmFsbGVsIHRvIHRoZSBhc3luY2hyb25vdXMgY29tcGxldGlv biBvZiB0aGUgcHJldmlvdXMKPiAtCSAqIHVwZGF0ZS4gV2hpY2ggaXMgaW1wb3J0YW50IHNpbmNl IGNvbXBvc2l0b3JzIG5lZWQgdG8gZmlndXJlIG91dCAKPiB0aGUKPiAtCSAqIGNvbXBvc2l0aW9u IG9mIHRoZSBuZXh0IGZyYW1lIHJpZ2h0IGFmdGVyIGhhdmluZyBzdWJtaXR0ZWQgdGhlCj4gLQkg KiBjdXJyZW50IGxheW91dC4KPiAtCSAqLwo+IC0KPiAtCWRybV9hdG9taWNfc3RhdGVfZ2V0KHN0 YXRlKTsKPiAtCWlmIChub25ibG9jaykKPiAtCQlxdWV1ZV93b3JrKHN5c3RlbV91bmJvdW5kX3dx LCAmc3RhdGUtPmNvbW1pdF93b3JrKTsKPiAtCWVsc2UKPiAtCQljb21taXRfdGFpbChzdGF0ZSk7 Cj4gLQo+IC0JcmV0dXJuIDA7Cj4gLQo+IC1lcnJvcjoKPiAtCWRybV9hdG9taWNfaGVscGVyX2Ns ZWFudXBfcGxhbmVzKGRldiwgc3RhdGUpOwo+IC0JcmV0dXJuIHJldDsKPiAtfQo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYuYyAKPiBiL2RyaXZlcnMvZ3B1L2RybS9t c20vbXNtX2Rydi5jCj4gaW5kZXggZTU4MmQ1ODg5YjY2Li5mZDlhN2QwODI1Y2QgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vbXNtL21zbV9kcnYuYwo+IEBAIC0xMjAsNyArMTIwLDExIEBAIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgZHJtX21vZGVfY29uZmlnX2Z1bmNzCj4gbW9kZV9jb25maWdfZnVuY3MgPSB7Cj4gIAkuZmJf Y3JlYXRlID0gbXNtX2ZyYW1lYnVmZmVyX2NyZWF0ZSwKPiAgCS5vdXRwdXRfcG9sbF9jaGFuZ2Vk ID0gbXNtX2ZiX291dHB1dF9wb2xsX2NoYW5nZWQsCj4gIAkuYXRvbWljX2NoZWNrID0gbXNtX2F0 b21pY19jaGVjaywKPiAtCS5hdG9taWNfY29tbWl0ID0gbXNtX2F0b21pY19jb21taXQsCj4gKwku YXRvbWljX2NvbW1pdCA9IGRybV9hdG9taWNfaGVscGVyX2NvbW1pdCwKPiArfTsKPiArCj4gK3N0 YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX21vZGVfY29uZmlnX2hlbHBlcl9mdW5jcyAKPiBtb2RlX2Nv bmZpZ19oZWxwZXJfZnVuY3MgPSB7Cj4gKwkuYXRvbWljX2NvbW1pdF90YWlsID0gbXNtX2F0b21p Y19jb21taXRfdGFpbCwKPiAgfTsKPiAKPiAgc3RhdGljIGlubGluZQo+IEBAIC02OTQsNiArNjk4 LDcgQEAgc3RhdGljIGludCBtc21fZHJtX2luaXQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QK PiBkcm1fZHJpdmVyICpkcnYpCj4gIAkgKiBhbiB1bnNldCB2YWx1ZSBkdXJpbmcgY2FsbCB0byBk cm1fZHJ2X3VzZXNfYXRvbWljX21vZGVzZXQoKQo+ICAJICovCj4gIAlkZGV2LT5tb2RlX2NvbmZp Zy5mdW5jcyA9ICZtb2RlX2NvbmZpZ19mdW5jczsKPiArCWRkZXYtPm1vZGVfY29uZmlnLmhlbHBl cl9wcml2YXRlID0gJm1vZGVfY29uZmlnX2hlbHBlcl9mdW5jczsKPiAKPiAgCWlmIChrbXMpIHsK PiAgCQlyZXQgPSBrbXMtPmZ1bmNzLT5od19pbml0KGttcyk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9tc20vbXNtX2Rydi5oIAo+IGIvZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZHJ2 LmgKPiBpbmRleCBlOTIzNzZhY2JjZmUuLjY1N2VhMDUyYTFlZSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNt X2Rydi5oCj4gQEAgLTU5Myw4ICs1OTMsNyBAQCBzdHJ1Y3QgbXNtX2Zvcm1hdCB7Cj4gIAl1aW50 MzJfdCBwaXhlbF9mb3JtYXQ7Cj4gIH07Cj4gCj4gLWludCBtc21fYXRvbWljX2NvbW1pdChzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LAo+IC0JCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwg Ym9vbCBub25ibG9jayk7Cj4gK3ZvaWQgbXNtX2F0b21pY19jb21taXRfdGFpbChzdHJ1Y3QgZHJt X2F0b21pY19zdGF0ZSAqc3RhdGUpOwo+ICBzdHJ1Y3QgbXNtX2ttc19zdGF0ZSAqbXNtX2ttc19n ZXRfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgCj4gKnN0YXRlKTsKPiAKPiAgdm9pZCBt c21fZ2VtX3VubWFwX3ZtYShzdHJ1Y3QgbXNtX2dlbV9hZGRyZXNzX3NwYWNlICphc3BhY2UsCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkZyZWVkcmVubyBt YWlsaW5nIGxpc3QKRnJlZWRyZW5vQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVubwo=