Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Rob Clark <robdclark@gmail.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Kuogee Hsieh <quic_khsieh@quicinc.com>,
	Mahadevan <quic_mahap@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: display: msm: dp-controller: document clock parents better
Date: Tue, 3 Dec 2024 09:01:31 +0100	[thread overview]
Message-ID: <bfa857c2-cd74-4fe2-a88c-3b35a58710b0@kernel.org> (raw)
In-Reply-To: <20241202-dp_mst_bindings-v1-2-9a9a43b0624a@quicinc.com>

On 03/12/2024 04:31, Abhinav Kumar wrote:
> Document the assigned-clock-parents better for the DP controller node
> to indicate its functionality better.


You change the clocks entirely, not "document". I would say that's an
ABI break if it really is a Linux requirement. You could avoid any
problems by just dropping the property from binding.

> 
> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
>  Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index 35ae2630c2b3..9fe2bf0484d8 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -72,8 +72,8 @@ properties:
>  
>    assigned-clock-parents:
>      items:
> -      - description: phy 0 parent
> -      - description: phy 1 parent
> +      - description: Link clock PLL output provided by PHY block
> +      - description: Stream 0 pixel clock PLL output provided by PHY block


Best regards,
Krzysztof

  reply	other threads:[~2024-12-03  8:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03  3:31 [PATCH 0/4] dt-bindings: msm/dp: add support for pixel clock to driver another stream Abhinav Kumar
2024-12-03  3:31 ` [PATCH 1/4] dt-bindings: display: msm: dp-controller: document pixel clock stream Abhinav Kumar
2024-12-03  8:01   ` Krzysztof Kozlowski
2025-04-23  2:23     ` Abhinav Kumar
2024-12-03  3:31 ` [PATCH 2/4] dt-bindings: display: msm: dp-controller: document clock parents better Abhinav Kumar
2024-12-03  8:01   ` Krzysztof Kozlowski [this message]
2024-12-03 13:41     ` Dmitry Baryshkov
2024-12-04  8:02       ` Krzysztof Kozlowski
2024-12-04 10:09         ` Dmitry Baryshkov
2024-12-05  7:33           ` Krzysztof Kozlowski
2024-12-05 11:32             ` Dmitry Baryshkov
2025-04-23  2:40               ` Abhinav Kumar
2024-12-03  3:31 ` [PATCH 3/4] dt-bindings: display/msm: add stream 1 pixel clock binding Abhinav Kumar
2024-12-03  8:04   ` Krzysztof Kozlowski
2025-04-23  2:46     ` Abhinav Kumar
2025-05-08  6:18       ` Krzysztof Kozlowski
2025-05-22  0:49         ` Abhinav Kumar
2024-12-03 13:43   ` Dmitry Baryshkov
2025-04-23  2:46     ` Abhinav Kumar
2025-04-23 14:23       ` Dmitry Baryshkov
2025-05-22  0:48         ` Abhinav Kumar
2024-12-03  3:31 ` [PATCH 4/4] dt-bindings: display: msm: dp: update maintainer entry Abhinav Kumar
2024-12-10  9:24   ` Krzysztof Kozlowski
2024-12-10 22:21 ` [PATCH 0/4] dt-bindings: msm/dp: add support for pixel clock to driver another stream Marijn Suijten
2024-12-24 20:41 ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfa857c2-cd74-4fe2-a88c-3b35a58710b0@kernel.org \
    --to=krzk@kernel.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=quic_mahap@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh@kernel.org \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox