From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gilad Broner" Subject: Re: [PATCH v2 2/4] scsi: ufs: add debugfs for ufs Date: Sun, 22 Feb 2015 15:00:21 -0000 Message-ID: References: <1423576735-26267-1-git-send-email-gbroner@codeaurora.org> <1423576735-26267-3-git-send-email-gbroner@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:58715 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752212AbbBVPAX (ORCPT ); Sun, 22 Feb 2015 10:00:23 -0500 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Akinobu Mita Cc: Gilad Broner , Jej B , LKML , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, Santosh Y , linux-scsi-owner@vger.kernel.org, Subhash Jadavani , Yaniv Gardi , Dolev Raviv , Lee Susman , Raviv Shvili , Vinayak Holikatti , "James E.J. Bottomley" > UFSDBG_REMOVE_DEBUGFS() is not called in the driver unloading path. > So ufs debugfs directory is not removed when unloading driver. It > should be called in ufshcd_remove(). > > BTW, do we really need UFSDBG_ADD_DEBUGFS() and UFSDBG_REMOVE_DEBUGFS() > macros? > We can use static inline functions in ufs-debugfs.h when !CONFIG_DEBUG_FS. > > #ifdef CONFIG_DEBUG_FS > void ufsdbg_add_debugfs(struct ufs_hba *hba); > > void ufsdbg_remove_debugfs(struct ufs_hba *hba); > #else > static inline void ufsdbg_add_debugfs(struct ufs_hba *hba) > { > } > > static inline void ufsdbg_remove_debugfs(struct ufs_hba *hba) > { > } > #endif > Thanks, I will fix the above two points and upload another patch. Gilad. -- Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project