From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9633C13A3ED for ; Wed, 23 Jul 2025 15:46:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753285592; cv=none; b=JjNSRtfu5C2DokVOeXWC2zjm5L99jFyOc/YKo2npBVVI54p0k4Od3h2lHGzzelSoWvYLue6gJfQU693pA88+XzXR21EycSETSBaqx4bMMTA4UfdnOhwdxAicj/Id94bqbRWfMhaUbtJi6tGuEX1oD5skFKtogpEC+3DfUDCNBuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753285592; c=relaxed/simple; bh=ta/nnHN012LXj1+PlNtGr0OXiDJWbolzf2pyXA4jqnA=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=DmaEAWoFTFFKCuMe/JW/3ATZOgcF3IhBqUqkltJycJKEhj2YNoUGC+7JPPO1yZ9WG/8fX2Tvj5KOTMUV/jTjWwt2S3zbur10tTTi5eVE6VScyIdFJ/X+I+jnzesqhqAVymV+3lotsycoEzUrkuaqS1uu3nc0CoYX1RkEy/8nSP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=P+zz5HVH; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="P+zz5HVH" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3a6d1369d4eso4154946f8f.2 for ; Wed, 23 Jul 2025 08:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753285589; x=1753890389; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=wmZ5bRV1PUfqwheCn0hCcu15gX58d2eDTkGCH+uULiU=; b=P+zz5HVHz84WH7Cc5Mb05ADRnoSJmdXntH5/wzYXMaDAA1vHAE6Qm0mzAhwbJjAGtR 6LqMW5MKMIyeXj0vX+gSm8sz6imQjgV2ODfwcl/zPZQW3NxkbhmAH24ab7KEvFh0ertu KJZxRn0w6kCL4aB63tCCKrjoCL36Ry7d5FXX6vW/NfZytxyizLEOY4U22iwLu3ZE6YJZ IWzKqXp5R/2Z6Rsh+aeANmKxipRpYrvvctIkigg8M0iN7nr2iPxlq1saS+RZlaNMWD4I PpM38IrQsGWuXtZvHgk1zqWle7G7asfi4UigVJh7Z/u3kZYZ8ZCmW7Hu+F7sg8Zw0gur bt5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753285589; x=1753890389; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wmZ5bRV1PUfqwheCn0hCcu15gX58d2eDTkGCH+uULiU=; b=j3Gew/MwS+1zzXzx7jKTSk/b9cJGrzjJn+PqLj9ffzw4Qh40EVHa3Dwz/Ax3pFAO4i f8L/paCSQ5jO9JWBOIzzc9pZH4dq8CFCbLoZX10mgAsqpDn+Jh+LOm+GIJivcdEymAx9 PGrfQH5iJBnvyD01dtogOZO9hQ7OqS0xvzxYw2j4NscenySgSVIGesDwn2dyV/LNyIi3 QQ6ydE/yEOGRJ0pyz44YnL8DakWlVXNMPfxgkpI6xPO/CYy5fxVVtpOcqciypHk18Wy/ coEdredoYMPzel9zdRGln9itomAeJf+kmiMm2DxV5ns6hJzR3bCh769ulUe+ULXXYRTZ 9CKw== X-Forwarded-Encrypted: i=1; AJvYcCW7a0KkLGLn7Bcz7do8ptniVwYdSBickIWUVbAcENBOke4M4532wQ34rGktOub1h9J5qx++dEkq3AGEZAf4@vger.kernel.org X-Gm-Message-State: AOJu0YzSSyvh4df+X6DJdGiFqOgeG4+KH7eDqzbepcHlOgpjix3X1cyV 0xVAe2bVOXlVdKygWFkWtEpIH4cyZj2Zid9cI8t9Mai+1ytm7B//19a6pkqIOqnpx90= X-Gm-Gg: ASbGncvsAfVbVzwdvG82AUdkqsJOaFUMk5TfO4+Fh/LWgycqvDBU8dEaW4M7kja/gT2 6/rm+1n+Cd62lxBLlMWjtwze4MggvAWcN03TOrFVF6CFA7/waRAowc3yCtb3n+s6vcq4mb4Thzy VPtCwZ+RvNH9QTswufCPngqeMaCHcASr2AWcdpO9NqUMUpbdo/muekgSC2L80+HEMCkXwous/K0 OK/Z8Que75LKHoa7XVAAOxdyYkjILclxq9oyM2tZiwgqJ+DZiLoABUADkZV2jlOAdM13ZoMuegk hNLM6XvuZQpynpD4a4mNB/Vq8UzApAPUaDnffeqhp58jR+s84J+SqvZh2xLKrDMu8BYffqSvjU7 6s0nHTP7aR0lgoRU/hGYllDveCkh/pJhdu45Y5eZuMZBOaqT1c4nsEhR3GSdfaPdFwnfKAH1R89 OP6hzwz8q4FJm0 X-Google-Smtp-Source: AGHT+IHlgEnmQBXXUEyZi32pN5BCGwjGY8lZuXGj+tGjDArR+gc7x5W/LA/pSb/walkpnyfSxvl2nQ== X-Received: by 2002:a05:6000:2389:b0:3aa:34f4:d437 with SMTP id ffacd0b85a97d-3b768ef9577mr2721271f8f.37.1753285588768; Wed, 23 Jul 2025 08:46:28 -0700 (PDT) Received: from ?IPV6:2a01:cb14:150f:cf00:b6af:e6a0:6569:3a1? ([2a01:cb14:150f:cf00:b6af:e6a0:6569:3a1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b75baa7072sm9616199f8f.2.2025.07.23.08.46.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jul 2025 08:46:28 -0700 (PDT) Message-ID: Date: Wed, 23 Jul 2025 17:46:25 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH] soc: qcom: mdt_loader: Fix error return values in mdt_header_valid() From: Neil Armstrong To: Dan Carpenter , Bjorn Andersson Cc: Konrad Dybcio , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 23/07/2025 16:46, neil.armstrong@linaro.org wrote: > Hi, > > On 25/06/2025 17:22, Dan Carpenter wrote: >> This function is supposed to return true for valid headers and false for >> invalid.  In a couple places it returns -EINVAL instead which means the >> invalid headers are counted as true.  Change it to return false. >> >> Fixes: 9f9967fed9d0 ("soc: qcom: mdt_loader: Ensure we don't read past the ELF header") >> Signed-off-by: Dan Carpenter >> --- >>   drivers/soc/qcom/mdt_loader.c | 4 ++-- >>   1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c >> index 1b4ebae458f3..0ca268bdf1f8 100644 >> --- a/drivers/soc/qcom/mdt_loader.c >> +++ b/drivers/soc/qcom/mdt_loader.c >> @@ -33,14 +33,14 @@ static bool mdt_header_valid(const struct firmware *fw) >>           return false; >>       if (ehdr->e_phentsize != sizeof(struct elf32_phdr)) >> -        return -EINVAL; >> +        return false; >>       phend = size_add(size_mul(sizeof(struct elf32_phdr), ehdr->e_phnum), ehdr->e_phoff); >>       if (phend > fw->size) >>           return false; >>       if (ehdr->e_shentsize != sizeof(struct elf32_shdr)) >> -        return -EINVAL; >> +        return false; >>       shend = size_add(size_mul(sizeof(struct elf32_shdr), ehdr->e_shnum), ehdr->e_shoff); >>       if (shend > fw->size) > > This patch on linux-next breaks loading DSP firmwares on at least SM8550, SM8650, X1E8: > > [    7.572665] remoteproc remoteproc1: Booting fw image qcom/sm8550/adsp.mbn, size 28342616 > [    7.615176] remoteproc remoteproc1: Failed to load program segments: -22 It also breaks GMU loading on the same platforms: [ 7.418330] msm_dpu ae01000.display-controller: [drm:adreno_load_gpu [msm]] *ERROR* gpu hw init failed: -22 Neil > > CI runs: > https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/248846#L1323 > https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/248850#L2037 > > Bisect log: > # bad: [a933d3dc1968fcfb0ab72879ec304b1971ed1b9a] Add linux-next specific files for 20250723 > # good: [89be9a83ccf1f88522317ce02f854f30d6115c41] Linux 6.16-rc7 > git bisect start 'a933d3dc1968fcfb0ab72879ec304b1971ed1b9a' 'v6.16-rc7' > # bad: [a56f8f8967ad980d45049973561b89dcd9e37e5d] Merge branch 'main' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git > git bisect bad a56f8f8967ad980d45049973561b89dcd9e37e5d > # bad: [f6a8dede4030970707e9bae5b3ae76f60df4b75a] Merge branch 'fs-next' of linux-next > git bisect bad f6a8dede4030970707e9bae5b3ae76f60df4b75a > # bad: [b863560c5a26fbcf164f5759c98bb5e72e26848d] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git > git bisect bad b863560c5a26fbcf164f5759c98bb5e72e26848d > # good: [6fe8797df6f2e3a7e3c736d5bd4862915a06a690] Merge branch 'for-next/core' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux > git bisect good 6fe8797df6f2e3a7e3c736d5bd4862915a06a690 > # good: [c522d00e1b4b00c5224c2acb9c2738bcc9c04ff5] Merge tag 'ti-k3-dt-for-v6.17' of https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux into soc/dt > git bisect good c522d00e1b4b00c5224c2acb9c2738bcc9c04ff5 > # good: [6a323f22a8b925f3646c884e2f9c733c79393f1d] Merge branch 'soc/drivers' into for-next > git bisect good 6a323f22a8b925f3646c884e2f9c733c79393f1d > # good: [5d8b3562faac8030b5c26efc1cd739a41c4db722] Merge branch 'soc/dt' into for-next > git bisect good 5d8b3562faac8030b5c26efc1cd739a41c4db722 > # bad: [b79c0d780e519d760c2529f0bf849111b9270192] Merge tag 'apple-soc-drivers-6.17' of https://git.kernel.org/pub/scm/linux/kernel/git/sven/linux into soc/drivers > git bisect bad b79c0d780e519d760c2529f0bf849111b9270192 > # good: [9841d92754d0f3846977a39844c3395ee2463381] Merge tag 'memory-controller-drv-6.17' of https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-mem-ctrl into soc/drivers > git bisect good 9841d92754d0f3846977a39844c3395ee2463381 > # good: [64a026dd896e423a177fe87e11aa69bf5348c27b] soc: qcom: socinfo: Add support to retrieve TME build details > git bisect good 64a026dd896e423a177fe87e11aa69bf5348c27b > # good: [9cea10a4f5a39fde32bf7b8addfa5f9175174e0e] dt-bindings: sram: qcom,imem: Add a number of missing compatibles > git bisect good 9cea10a4f5a39fde32bf7b8addfa5f9175174e0e > # good: [0445eee835d6e59d635e242ba1d9273f168035fa] soc: apple: rtkit: Make shmem_destroy optional > git bisect good 0445eee835d6e59d635e242ba1d9273f168035fa > # bad: [5b8141596b06fba7313cdfbd5f589649d7fde662] Merge tag 'qcom-drivers-for-6.17' of https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux into soc/drivers > git bisect bad 5b8141596b06fba7313cdfbd5f589649d7fde662 > # bad: [9f35ab0e53ccbea57bb9cbad8065e0406d516195] soc: qcom: mdt_loader: Fix error return values in mdt_header_valid() > git bisect bad 9f35ab0e53ccbea57bb9cbad8065e0406d516195 > # first bad commit: [9f35ab0e53ccbea57bb9cbad8065e0406d516195] soc: qcom: mdt_loader: Fix error return values in mdt_header_valid() > > Neil