From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function Date: Tue, 21 Nov 2017 23:45:37 -0600 Message-ID: References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-31-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1511328675-21981-31-git-send-email-okaya@codeaurora.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Sinan Kaya , linux-pci@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Helgaas , open list List-Id: linux-arm-msm@vger.kernel.org On 11/21/17 11:31 PM, Sinan Kaya wrote: > Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't > extract the domain number. Other places, use the actual domain number from > the device. > > Now that all users of pci_get_bus_and_slot() switched to > pci_get_domain_bus_and_slot(), it is now safe to remove this function. This doesn't really eliminate pci_get_bus_and_slot(), because it doesn't force developers to support non-zero domains. What's to stop a driver developer from doing this? #define pci_get_bus_and_slot(b, d) pci_get_domain_bus_and_slot(0, b, d) thereby completely ignoring what you're trying to do? -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.