From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFEE228CF4A for ; Thu, 23 Oct 2025 06:28:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761200943; cv=none; b=Gzc+jqutmt+MxQlpfUTMDsonojZ7wUE3kP9bYfekklZ1usYVVjkh5XMm/2gNktxGemudKEJgsGfzlH+X/JNMDpfsWjZHVRgVvWOU0zMmiQeUzXqLanOWq1ftiLbQ9mj5O2UAGregbjoPSqW9HIjPAPpAr92mVe3txYjIuAblgHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761200943; c=relaxed/simple; bh=fosxcRfm4IcPp2XyRa43blhpzgOGKZ7BZ6k6bvuh/k0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WwIa76c5i5lfTKbUPBMFGEqRFktB3FELOvV9xtzbIWiU6YgTx3aal/3yXWoC9yxywyhTWB30KtoXd6fW0VMIgGghaLIVZgJUoT4BQAWgD6v+KNkv3zMmFTtrY4Ugm/FLdGejUxiZpSy9wbVqDjuDWxAKDT8FM2ki1SCWXi6tAcQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UQAUXPLx; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UQAUXPLx" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-427015003eeso346326f8f.0 for ; Wed, 22 Oct 2025 23:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761200938; x=1761805738; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=cfXSNBJ3Lj8HMC9TG4zI26WPaoxL73AUzeIid3gj+Vk=; b=UQAUXPLxGaQ3JIiVdYUdrATpty4kk/Z9z3E91wSmzMgugOkFu8e0KzyK4GpMaskD/e qwbfgLjF4zKM7T/Jvndu3HlD9Ni5ypLSEBk8Nv7FsACmln67QlF+4NtuyvuG9LmfTz1J QOx5mwOom7Zqy3OQR/WgptokT6lsyYfrq55L9eNcmvUGOxjGlVAlwUuDz4T639CYurWd trSRj2LZyOzXBT88jnlckn9+xetqusl3IEYsSWXOHy0tahfNY9Bh4ocV+FAcotHj95oM 3VXgO1H9Lvc3t/zzi5wLt2HaC4x3kKnqyaAkWEMYr5k0mJYDsslcS4DNNEDSOUF3R54u oNYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761200938; x=1761805738; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cfXSNBJ3Lj8HMC9TG4zI26WPaoxL73AUzeIid3gj+Vk=; b=rkQb7xctTEVT3uSgVoolTcYv1aiIW4zgUerpY5/PS7wKsLy//aIx45eIV9r4xwBbLB NMC7qwaqQWhyWa0EyQvDvUNyCqWFUmIi4rPGTqf5nIphU8imWTImLYPp9jrXnbrbEZrS 3TmmXUH//prnFD8Gvp7zIDLB5GDWXkNLyvtdw3zSAXqxmMF9KzMFM4cbCFDY2W6f5hfo tQMf1E0gb5vaiWiID9DuIG/FUMYIDi1Fp5FrbogJfrzD4a6gasHqDW4IH59CTsDrkZus nOWiD8xjs2ndXi7RhHpRKiA39QoyXxXWYJClfhWCtk7fYYuM5OOM9aWYjv0Ce7Ko5m0A DvQw== X-Forwarded-Encrypted: i=1; AJvYcCVkRjDxpgDUARDnGTMfRoZXj/Hf0wYv+TWmblxW1+lTU/VyhlkqxXD1+7NsMJNGSC1yEV6cXXiBShSic4b9@vger.kernel.org X-Gm-Message-State: AOJu0YyGNZ3AA5Gz0PWWOXWXTpOEngpad8hY+QM2vmGvwYYx4EluR1ql wAESWkceeO/864y2waRH0MujqWIFdECvlCB4l/hIte4DKxTY2aPWQOi6 X-Gm-Gg: ASbGnctn90A0ZPL+/BDD2N+G8LtUBGnoHLXgbQQ0sgcI1UGBipEKPUSnZb6DotNwtki YBPsubUwzkFBJBaJ81YzXdgjNjG00zDaY9V1sDFupH5IVzdO1458SRIggcRCcgKykbEMxjmWtOq 3DS6MARgWLIcXOH2RHzHXxhdNoU+RYzRJrU85ijnM+xEgJHHobj6yO8OKd2rh9vE3urG9el0fYo gWCfc1LvaBupsbdBm9oNvBwwSu0hsQyKUQGxFyyTvZEPOBrZP3qMdILsbjxtt4aFbwOnJttq2Dv hT+Sig075BPmtinFyW23acGNFgwT9z+jU094Dn0+vH0U4GrbQTMcJWjs7oQqJ1Krkevan04Mra3 eLhxcB3WHATwxrm1fusiivums+045NUmEUEy+RObs5/U+KtvcE+SKMnKZttgijZ5T71kEp072bw ONQgQwM69x4QD7v3vQ1TQ56ZTnnylG9eaU3SQ8W+1b1I5IQjyDT7Ld7oEHY4AOmSuR/NRK/y2X+ ZZkW46bVCSJD2C/J4bIbA== X-Google-Smtp-Source: AGHT+IGQYsYCoWv277/L1DZqnSFky9hUnqtHFEhUT8R9Ao9EsxWIgBx6V3qKm2hKAnUcCyUKYbX8NA== X-Received: by 2002:a05:6000:2911:b0:426:da92:d390 with SMTP id ffacd0b85a97d-42704d83ce7mr16609944f8f.10.1761200937708; Wed, 22 Oct 2025 23:28:57 -0700 (PDT) Received: from [192.168.1.29] ([178.197.219.123]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-429897f52aasm2190315f8f.12.2025.10.22.23.28.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Oct 2025 23:28:56 -0700 (PDT) Message-ID: Date: Thu, 23 Oct 2025 08:28:54 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP To: Jingyi Wang , Dmitry Baryshkov Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com References: <20250924-knp-remoteproc-v1-0-611bf7be8329@oss.qualcomm.com> <20250924-knp-remoteproc-v1-2-611bf7be8329@oss.qualcomm.com> <5820a9a9-4474-4c4d-905c-0efd9442e5e1@oss.qualcomm.com> <540b1de6-c959-4911-925f-8163f5fa5147@oss.qualcomm.com> <7952ed3d-f019-4593-af43-b2df7f738d04@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=k.kozlowski.k@gmail.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzS1Lcnp5c3p0b2Yg S296bG93c2tpIDxrLmtvemxvd3NraS5rQGdtYWlsLmNvbT7CwZgEEwEKAEICGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAAhkBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmA87w8FCRRf reEACgkQG5NDfTtBYptlYhAAp060KZX9ZgCRuOzc3XSnYmfUsLT2UPFoDmEoHe+6ndQdD93B XXFrVM43Czd1GEmHUiARxH/7z4t9GIJcRnyax8+e0gmLaQO36uTba8odjjYspES4S+vpPfLo FdtkUKArTZ3R7oZ7VkKH5bcTaz71sEZnAJOqQ+HBMX/srmaAffEaPcnfbvsttwjxWD3NHQBj EJWWG3lsQ0m0yVL36r3WxKW2HVGCINPo32GBTk2ANU4Uypr46H7Z0EnHs4bqZCzsxc71693N shQLXjrdAfdz6MD4xHLymRPRehFTdFvqmYdUc+MDv8uGxofJ5+DdR6jWcTeKC8JJ/J8hK7fG UXMn7VmhFOgSKS/TJowHhqbQn4zQMJE/xWZsIoYwZeGTRep1QosUvmnipgGhBoZ64hNs2tfU bQ4nRDARz7CIvBulnj3zukYDRi2HWw6e+vAlvnksXp3lBOKcugsBhwlNauxAnFPPDhvWgVcj VA0b37PB9QNty2eJtctJpOlUB+/M+sfBkhzTJLHmIJGxcwHptMOCsXKZx5FOUXq5PofHGNVi IaI0Sc5fB9UTNCDe+x7H6Cllud29AyGZhEm2b0ibmcFLB/p+gIlGHmSjaYru1sTiZjWfyUbw Ex03f5qMP43Ot4vgftlu8KAO8oQPE4b7lAkcyG+Ux38un62KFhXOZqMxOG/OwU0EVUNcNAEQ AM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0hihS HlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJYoHtC vPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92H1HN q1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwtyupo dQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd5IE9 v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct95Znl avBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/+HYj C/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVqFPSV E+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy5y06 JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4ODFH4 1ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92Vcmzn/jaEBcqyT48 ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbThLsSN1AuyP8wFKChC 0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH5lSCjhP4VXiGq5ng CxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpFc1D/9NV/zIWBG1NR 1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzePt/SvC0RhQXNjXKBB +lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60RtThnhKc2kLIzd8G qyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7qVT41xdJ6KqQMNGQe V+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZv+PKIVf+zFKuh0At /TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1qwom6QbU06ltbvJE2 K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHpcwzYbmi/Et7T2+47 PN9NZAOyb771QoVr8A== In-Reply-To: <7952ed3d-f019-4593-af43-b2df7f738d04@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 23/10/2025 06:07, Jingyi Wang wrote: > > > On 10/9/2025 6:29 PM, Krzysztof Kozlowski wrote: >> On 29/09/2025 19:03, Dmitry Baryshkov wrote: >>> On Mon, Sep 29, 2025 at 05:41:10PM +0800, Jingyi Wang wrote: >>>> >>>> >>>> On 9/29/2025 5:34 PM, Dmitry Baryshkov wrote: >>>>> On Mon, Sep 29, 2025 at 02:20:54PM +0800, Jingyi Wang wrote: >>>>>> >>>>>> >>>>>> On 9/25/2025 9:48 AM, Krzysztof Kozłowski wrote: >>>>>>> On Thu, 25 Sept 2025 at 08:37, Jingyi Wang wrote: >>>>>>>> >>>>>>>> Add remote processor PAS loader for Kaanapali CDSP processor, compatible >>>>>>>> with earlier SM8550 with minor difference: one more sixth "shutdown-ack" >>>>>>>> interrupt. >>>>>>>> >>>>>>>> Signed-off-by: Jingyi Wang >>>>>>>> --- >>>>>>>> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 19 +++++++++++++++++++ >>>>>>>> 1 file changed, 19 insertions(+) >>>>>>>> >>>>>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>>>>> index be9e2a0bc060..031fdf36a66c 100644 >>>>>>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>>>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>>>>> @@ -35,6 +35,9 @@ properties: >>>>>>>> - items: >>>>>>>> - const: qcom,sm8750-cdsp-pas >>>>>>>> - const: qcom,sm8650-cdsp-pas >>>>>>>> + - items: >>>>>>>> + - const: qcom,kaanapali-cdsp-pas >>>>>>>> + - const: qcom,sm8550-cdsp-pas >>>>>>> >>>>>>> >>>>>>> This time maybe without HTML: >>>>>>> >>>>>>> This looks wrong. This is not compatible with SM8550. >>>>>> >>>>>> Could you point out what is the difference from your perspecetive? >>>>>> it is the same as SM8550 except for there is one more interrupt, >>>>>> which is also described in this patch. >>>>> >>>>> I'd second Krzysztof here. Your description points out that it is _not_ >>>>> compatible to SM8550. >>>>> >>>> >>>> Here is the binding for sm8750 cdsp. Fallback to sm8650 but describe the >>>> difference in interrupt: >>>> https://lore.kernel.org/all/20250221160036.159557-1-krzysztof.kozlowski@linaro.org/ >>> >>> Interesting. Let's wait for Krzysztof's response then. >>> >> >> >> Because it is evolution of sm8750, so it did not go back to old design. >> from three generations ago. This is compatible with sm8750 or with sm8650. >> >> >> Best regards, >> Krzysztof > > Hi Krzysztof， > > I tested with falling back to sm8650 cdsp but it will fail with: > [ 4.739615] qcom_q6v5_pas 26300000.remoteproc: unable to resolve shareable memory-region index 0 > > sm8550 and kaanapali define 2 memory regions: > "memory-region = <&cdsp_mem>, <&q6_cdsp_dtb_mem>;" > > sm8650 and sm8750 define 3 memory regions: > "memory-region = <&cdsp_mem>, <&q6_cdsp_dtb_mem>, <&global_sync_mem>;" > with the driver: > > static const struct qcom_pas_data sm8650_cdsp_resource = { > .crash_reason_smem = 601, > .firmware_name = "cdsp.mdt", > .dtb_firmware_name = "cdsp_dtb.mdt", > <...> > .region_assign_idx = 2, > .region_assign_count = 1, > .region_assign_shared = true, > .region_assign_vmid = QCOM_SCM_VMID_CDSP, > }; > > When kaanapali fallback to sm8650 it cannot parse this region_assign_idx. > > So shall we still fallback to sm8550 or define a new node "kaanapali_cdsp_resource" > in the driver? And partially the point here is that you might need the third region, no? Best regards, Krzysztof