From: Markus Elfring <Markus.Elfring@web.de>
To: Qiushi Wu <wu000273@umn.edu>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>, Kangjie Lu <kjlu@umn.edu>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: qcom: Improve exception handling in qcom_pcie_probe()
Date: Tue, 26 May 2020 16:30:34 +0200 [thread overview]
Message-ID: <c0e71850-a67b-2aac-7ddc-186f3850c087@web.de> (raw)
Please avoid a typo in the patch subject (by a possible alternative?).
> In function qcom_pcie_probe(), there are several error-handling problem.
Wording adjustments:
This function contained improvable implementation details according to
exception handling.
> because refcount will be increased even pm_runtime_get_sync() returns
> an error.
because the reference count will be increased despite of the failure.
Thus add the missed function call.
> 2. pm_runtime_disable() are called twice, …
…
Thus remove redundant function calls.
Regards,
Markus
reply other threads:[~2020-05-26 14:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0e71850-a67b-2aac-7ddc-186f3850c087@web.de \
--to=markus.elfring@web.de \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=kjlu@umn.edu \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox