From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7C38C7EE37 for ; Fri, 9 Jun 2023 09:12:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241294AbjFIJM4 (ORCPT ); Fri, 9 Jun 2023 05:12:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241456AbjFIJMZ (ORCPT ); Fri, 9 Jun 2023 05:12:25 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCA6449F8 for ; Fri, 9 Jun 2023 02:08:05 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4f63ab1ac4aso1862070e87.0 for ; Fri, 09 Jun 2023 02:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686301639; x=1688893639; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ut+UdOGUYV6ZPCloMfk71xOra+IPou8Ks2zziRmRFEc=; b=TzEJ+kHaf++h2o/IQ0+vrufd/PJNz+Qa7g86IoNKbGoAC4CuJs23659mYro50iqqCT av3IHNGUR24d984wVv5JQElrSFFB31VgA1LMS21Ku/YKbb55LcDunKrq4Vwf9IN/OX8c OqCFXj39eEv9+os5V4M9oLCfkhHZ7WZd++HphIEB5pY8kWGXNdqqGtskrqSAReK1Lw3F Et1jOeEHy2OxQaLnhGOKz47gm3BYmnhQkV4LSi5g4Ymu2CQjsWqJCAbj6YAiezPZF9sy qa32e3EyTt/8xKCRoUd8DoHGo6dZRz1iybIgja1w1DsLtInXjpQRqUXGxnDsUUjsrdRE SXQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686301639; x=1688893639; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ut+UdOGUYV6ZPCloMfk71xOra+IPou8Ks2zziRmRFEc=; b=THpQmd44h0560kbr5xvbXG4y/k9At+4iGQeDNQjPt5La4LloIAgwJarlzKjQonIkKZ kjnjz4rqK82yZGfN5spkCiwUxakxslxm2Z++qOLw91A5yXB6klBIVeYGrOUCb369KneE VxFSeomXC6ZobmpXyACUK7w62ACM/3xR0Flad/euFwzSvNJR9l9MlQMAenXVrpWa/10j LKp7TE/OyxfyoDzv0Ff9/2bsafMKGqW3suWp5Z3Duav6CUX0Eb50i51HJtCaklr4r3Ta IpQ9NZsULlrfMpJ75a6niwP3K3M7DiI9U6+nHUFe1ixpW2GYQXEOQtOmzMcifkuJhvjd Zj6Q== X-Gm-Message-State: AC+VfDx9eb7CZcqmk+GGh8wauSn8WoXWG+AnFD/p51Rkm37hegTcpuyj EhyhpQIpHkHrx5/sGmohVXeYsg== X-Google-Smtp-Source: ACHHUZ42fawBuo7RkPecPZhXac5mt8Wx5dZ8Dk95VjNMEK9sH0vBXfC7A1FMt30eCPmgY8SYu9IA5g== X-Received: by 2002:a19:2d58:0:b0:4f6:2a63:d3fc with SMTP id t24-20020a192d58000000b004f62a63d3fcmr420007lft.32.1686301639605; Fri, 09 Jun 2023 02:07:19 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id t12-20020ac2548c000000b004efae490c51sm471679lfk.240.2023.06.09.02.07.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 02:07:19 -0700 (PDT) Message-ID: Date: Fri, 9 Jun 2023 11:07:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] arm64: dts: qcom: ipq9574: enable the SPI NOR support in RDP433 Content-Language: en-US To: Kathiravan T , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230609081508.30982-1-quic_kathirav@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230609081508.30982-1-quic_kathirav@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 9.06.2023 10:15, Kathiravan T wrote: > RDP433 has the support for SPI NOR, add the support for it. > > Signed-off-by: Kathiravan T > --- > Note: This patch was part of initial submission > https://lore.kernel.org/linux-arm-msm/20230329053726.14860-1-quic_kathirav@quicinc.com/ > however this got missed in between, so sending it across again. > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > index 2b3ed8d351f7..31ee19112157 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > @@ -48,6 +48,20 @@ > }; > }; > > +&blsp1_spi0 { > + pinctrl-0 = <&spi_0_pins>; > + pinctrl-names = "default"; > + status = "okay"; > + > + flash@0 { > + compatible = "micron,n25q128a11", "jedec,spi-nor"; > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <1>; If you're not adding a partition table, you can drop the address- and size-cells properties, as they determine what the reg value of the child looks like. Konrad > + spi-max-frequency = <50000000>; > + }; > +}; > + > &sdhc_1 { > pinctrl-0 = <&sdc_default_state>; > pinctrl-names = "default"; > @@ -96,6 +110,13 @@ > bias-pull-down; > }; > }; > + > + spi_0_pins: spi-0-state { > + pins = "gpio11", "gpio12", "gpio13", "gpio14"; > + function = "blsp0_spi"; > + drive-strength = <8>; > + bias-disable; > + }; > }; > > &xo_board_clk {