From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A51C9C433E0 for ; Wed, 6 Jan 2021 02:26:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6790722CE3 for ; Wed, 6 Jan 2021 02:26:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726008AbhAFC0f (ORCPT ); Tue, 5 Jan 2021 21:26:35 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:11256 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbhAFC0f (ORCPT ); Tue, 5 Jan 2021 21:26:35 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1609899975; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=vB8ffsUc0/kCF/6n36HjGOI4z7sNSZ1SNQ+PGH1qzhg=; b=IaccxQHHU+0HbwlTodI9ZN49Sta7lYo3K++ndms8yHWfB53Wy3/ixT1FySY8sGAIyviVXAse t3Zckx0r2ELXkKanntgSBp5T8AleP0mB+DaUjkcqdE/0AlEa9cIhKbAfKVB1tN5pYaXJOYez T8ps1e17pEEXG/vcsybx0TeBryo= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 5ff51fa7d3eb3c36b4f07e64 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 06 Jan 2021 02:25:43 GMT Sender: hemantk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 304E3C433C6; Wed, 6 Jan 2021 02:25:43 +0000 (UTC) Received: from [10.46.162.249] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hemantk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8CCD3C433C6; Wed, 6 Jan 2021 02:25:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8CCD3C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=hemantk@codeaurora.org Subject: Re: [PATCH 1/2] mhi: unconstify mhi_event_config To: Manivannan Sadhasivam , Loic Poulain Cc: linux-arm-msm@vger.kernel.org References: <1609836975-5758-1-git-send-email-loic.poulain@linaro.org> <20210105152620.GA14794@thinkpad> From: Hemant Kumar Message-ID: Date: Tue, 5 Jan 2021 18:25:42 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210105152620.GA14794@thinkpad> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Loic, On 1/5/21 7:26 AM, Manivannan Sadhasivam wrote: > On Tue, Jan 05, 2021 at 09:56:14AM +0100, Loic Poulain wrote: >> Some parameters may have to be determined at runtime. >> It is the case for the event ring MSI vector. >> >> Signed-off-by: Loic Poulain > > Reviewed-by: Manivannan Sadhasivam > > Thanks, > Mani > >> --- >> include/linux/mhi.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/mhi.h b/include/linux/mhi.h >> index 62da830..48b1b2a 100644 >> --- a/include/linux/mhi.h >> +++ b/include/linux/mhi.h >> @@ -290,7 +290,7 @@ struct mhi_controller_config { >> u32 num_channels; >> const struct mhi_channel_config *ch_cfg; >> u32 num_events; >> - const struct mhi_event_config *event_cfg; >> + struct mhi_event_config *event_cfg; Do we need to update mhi controller driver like ath11k and generic pci driver to avoid compiler warnings? >> bool use_bounce_buf; >> bool m2_no_db; >> }; >> -- >> 2.7.4 >> -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project