From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rob Clark <robdclark@gmail.com>
Cc: Mark Pearson <markpearson@lenovo.com>,
linux-firmware@kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
bjorn.andersson@linaro.org
Subject: Re: qcom: Add firmware for Lenovo ThinkPad X13s
Date: Fri, 5 Aug 2022 23:35:12 +0300 [thread overview]
Message-ID: <c1dcfbf5-3bb8-8156-667c-f5966f7ba1d7@linaro.org> (raw)
In-Reply-To: <CAF6AEGvdnrPn+rnDGmjza1-xoPaOQgdPLkSfaOL6hCPnB2ea5w@mail.gmail.com>
On 05/08/2022 23:09, Rob Clark wrote:
> On Fri, Aug 5, 2022 at 2:37 AM Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
>>
>> On 03/08/2022 23:37, Mark Pearson wrote:
>>> The following changes since commit 150864a4d73e8c448eb1e2c68e65f07635fe1a66:
>>>
>>> amdgpu partially revert "amdgpu: update beige goby to release 22.20"
>>> (2022-07-25 14:16:04 -0400)
>>>
>>> are available in the Git repository at:
>>>
>>> https://github.com/mrhpearson/linux-firmware lenovo-thinkpad-x13s
>>>
>>> for you to fetch changes up to 4ae4ae88918928e15006eb129ad981aa58216b59:
>>>
>>> qcom: Add firmware for Lenovo ThinkPad X13s (2022-08-03 16:29:07 -0400)
>>
>> Mark, it's so great to see firmware packages for Lenovo laptops being
>> submitted!
>>
>>>
>>> ----------------------------------------------------------------
>>> Mark Pearson (1):
>>> qcom: Add firmware for Lenovo ThinkPad X13s
>>>
>>> WHENCE | 8 ++++++++
>>> qcom/LENOVO/21BX/adspr.jsn | 28 ++++++++++++++++++++++++++++
>>> qcom/LENOVO/21BX/adspua.jsn | 29 +++++++++++++++++++++++++++++
>>> qcom/LENOVO/21BX/battmgr.jsn | 22 ++++++++++++++++++++++
>>> qcom/LENOVO/21BX/cdspr.jsn | 22 ++++++++++++++++++++++
>>> qcom/LENOVO/21BX/qcadsp8280.mbn | Bin 0 -> 14367860 bytes
>>> qcom/LENOVO/21BX/qccdsp8280.mbn | Bin 0 -> 3575808 bytes
>>> qcom/LENOVO/21BX/qcdxkmsuc8280.mbn | Bin 0 -> 14392 bytes
>>> qcom/LENOVO/21BX/qcslpi8280.mbn | Bin 0 -> 6213632 bytes
>>> 9 files changed, 109 insertions(+)
>>> create mode 100644 qcom/LENOVO/21BX/adspr.jsn
>>> create mode 100644 qcom/LENOVO/21BX/adspua.jsn
>>> create mode 100644 qcom/LENOVO/21BX/battmgr.jsn
>>> create mode 100644 qcom/LENOVO/21BX/cdspr.jsn
>>> create mode 100755 qcom/LENOVO/21BX/qcadsp8280.mbn
>>> create mode 100755 qcom/LENOVO/21BX/qccdsp8280.mbn
>>> create mode 100755 qcom/LENOVO/21BX/qcdxkmsuc8280.mbn
>>> create mode 100755 qcom/LENOVO/21BX/qcslpi8280.mbn
>>
>> I think it's the time to settle onto firmware paths for the
>> Qualcomm-based devices. At some point it was proposed to use
>> qcom/<SoC>/device/*mbn.
>>
>> So, in your case it could be qcom/sc8280xp/Lenovo_21BX/
>
> I don't think it is a good idea.. we should stick to a path that can
> be constructed from SMBIOS fields if we ever want a chance to get ACPI
> boot with acceleration working
Yes, it's also true. I do not quite like the idea that we are going to
end up with two different path types. One using the DMI/SMBIOS ids,
another one using SoC and machine id. Maybe we can settle on using
SoC+id and then using DMI-based links.
There is another point to remember. I can imagine that once WoA/LoA
laptops are more common, there can be several different DMI models
sharing common firmware. So, there will be symlinks involved anyway.
--
With best wishes
Dmitry
prev parent reply other threads:[~2022-08-05 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9a79936b-70e2-f964-55ac-e2be8e9346ed@lenovo.com>
2022-08-05 9:36 ` qcom: Add firmware for Lenovo ThinkPad X13s Dmitry Baryshkov
2022-08-05 12:43 ` [External] " Mark Pearson
2022-08-05 20:45 ` Dmitry Baryshkov
2022-08-05 20:09 ` Rob Clark
2022-08-05 20:35 ` Dmitry Baryshkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1dcfbf5-3bb8-8156-667c-f5966f7ba1d7@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-firmware@kernel.org \
--cc=markpearson@lenovo.com \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).