Re: qcom: Add firmware for Lenovo ThinkPad X13s

Re: qcom: Add firmware for Lenovo ThinkPad X13s

[Dmitry Baryshkov]

On 03/08/2022 23:37, Mark Pearson wrote:
> The following changes since commit 150864a4d73e8c448eb1e2c68e65f07635fe1a66:
> 
>    amdgpu partially revert "amdgpu: update beige goby to release 22.20"
> (2022-07-25 14:16:04 -0400)
> 
> are available in the Git repository at:
> 
>    https://github.com/mrhpearson/linux-firmware lenovo-thinkpad-x13s
> 
> for you to fetch changes up to 4ae4ae88918928e15006eb129ad981aa58216b59:
> 
>    qcom: Add firmware for Lenovo ThinkPad X13s (2022-08-03 16:29:07 -0400)

Mark, it's so great to see firmware packages for Lenovo laptops being 
submitted!

> 
> ----------------------------------------------------------------
> Mark Pearson (1):
>        qcom: Add firmware for Lenovo ThinkPad X13s
> 
>   WHENCE                             |   8 ++++++++
>   qcom/LENOVO/21BX/adspr.jsn         |  28 ++++++++++++++++++++++++++++
>   qcom/LENOVO/21BX/adspua.jsn        |  29 +++++++++++++++++++++++++++++
>   qcom/LENOVO/21BX/battmgr.jsn       |  22 ++++++++++++++++++++++
>   qcom/LENOVO/21BX/cdspr.jsn         |  22 ++++++++++++++++++++++
>   qcom/LENOVO/21BX/qcadsp8280.mbn    | Bin 0 -> 14367860 bytes
>   qcom/LENOVO/21BX/qccdsp8280.mbn    | Bin 0 -> 3575808 bytes
>   qcom/LENOVO/21BX/qcdxkmsuc8280.mbn | Bin 0 -> 14392 bytes
>   qcom/LENOVO/21BX/qcslpi8280.mbn    | Bin 0 -> 6213632 bytes
>   9 files changed, 109 insertions(+)
>   create mode 100644 qcom/LENOVO/21BX/adspr.jsn
>   create mode 100644 qcom/LENOVO/21BX/adspua.jsn
>   create mode 100644 qcom/LENOVO/21BX/battmgr.jsn
>   create mode 100644 qcom/LENOVO/21BX/cdspr.jsn
>   create mode 100755 qcom/LENOVO/21BX/qcadsp8280.mbn
>   create mode 100755 qcom/LENOVO/21BX/qccdsp8280.mbn
>   create mode 100755 qcom/LENOVO/21BX/qcdxkmsuc8280.mbn
>   create mode 100755 qcom/LENOVO/21BX/qcslpi8280.mbn

I think it's the time to settle onto firmware paths for the 
Qualcomm-based devices. At some point it was proposed to use 
qcom/<SoC>/device/*mbn.

So, in your case it could be qcom/sc8280xp/Lenovo_21BX/

Bjorn, WDYT?


P.S. Can we hope to get firmware for older laptops to be published too? 
It would be really great if it would be possible to provide full support 
for Yoga C630 or Flex5G using redistributable firmware from linux-firmware.

-- 
With best wishes
Dmitry

Re: [External] Re: qcom: Add firmware for Lenovo ThinkPad X13s

[Mark Pearson]

Hi Dmitry

On 8/5/22 05:36, Dmitry Baryshkov wrote:
> On 03/08/2022 23:37, Mark Pearson wrote:
>> The following changes since commit
>> 150864a4d73e8c448eb1e2c68e65f07635fe1a66:
>>
>>    amdgpu partially revert "amdgpu: update beige goby to release 22.20"
>> (2022-07-25 14:16:04 -0400)
>>
>> are available in the Git repository at:
>>
>>   
>> https://github.com/mrhpearson/linux-firmware>>> lenovo-thinkpad-x13s
>>
>> for you to fetch changes up to 4ae4ae88918928e15006eb129ad981aa58216b59:
>>
>>    qcom: Add firmware for Lenovo ThinkPad X13s (2022-08-03 16:29:07
>> -0400)
> 
> Mark, it's so great to see firmware packages for Lenovo laptops being
> submitted!
> 
>>
>> ----------------------------------------------------------------
>> Mark Pearson (1):
>>        qcom: Add firmware for Lenovo ThinkPad X13s
>>
>>   WHENCE                             |   8 ++++++++
>>   qcom/LENOVO/21BX/adspr.jsn         |  28 ++++++++++++++++++++++++++++
>>   qcom/LENOVO/21BX/adspua.jsn        |  29 +++++++++++++++++++++++++++++
>>   qcom/LENOVO/21BX/battmgr.jsn       |  22 ++++++++++++++++++++++
>>   qcom/LENOVO/21BX/cdspr.jsn         |  22 ++++++++++++++++++++++
>>   qcom/LENOVO/21BX/qcadsp8280.mbn    | Bin 0 -> 14367860 bytes
>>   qcom/LENOVO/21BX/qccdsp8280.mbn    | Bin 0 -> 3575808 bytes
>>   qcom/LENOVO/21BX/qcdxkmsuc8280.mbn | Bin 0 -> 14392 bytes
>>   qcom/LENOVO/21BX/qcslpi8280.mbn    | Bin 0 -> 6213632 bytes
>>   9 files changed, 109 insertions(+)
>>   create mode 100644 qcom/LENOVO/21BX/adspr.jsn
>>   create mode 100644 qcom/LENOVO/21BX/adspua.jsn
>>   create mode 100644 qcom/LENOVO/21BX/battmgr.jsn
>>   create mode 100644 qcom/LENOVO/21BX/cdspr.jsn
>>   create mode 100755 qcom/LENOVO/21BX/qcadsp8280.mbn
>>   create mode 100755 qcom/LENOVO/21BX/qccdsp8280.mbn
>>   create mode 100755 qcom/LENOVO/21BX/qcdxkmsuc8280.mbn
>>   create mode 100755 qcom/LENOVO/21BX/qcslpi8280.mbn
> 
> I think it's the time to settle onto firmware paths for the
> Qualcomm-based devices. At some point it was proposed to use
> qcom/<SoC>/device/*mbn.
> 
> So, in your case it could be qcom/sc8280xp/Lenovo_21BX/
> 
> Bjorn, WDYT?
> 
For this I completely defer to Bjorn as he's been helping me with this
exercise :)
If it needs updating I can do that no problem - just let me know

(One minor note - I'm on vacation and offline next week...so there will
be a pause in responses after tomorrow)

> 
> P.S. Can we hope to get firmware for older laptops to be published too?
> It would be really great if it would be possible to provide full support
> for Yoga C630 or Flex5G using redistributable firmware from linux-firmware.
> 
I looked into this previously for the C630 and was nacked I'm afraid.

Going back to the older platforms is a harder ask unfortunately because
along with the FW you really need changes in the boot loader and I know
I won't win that argument.

I'll try again once we get a bit further along with this platform but
realistically, the chances of it happening are small. I'm (quite openly)
using this PoC project to prove that we can do Linux on one of our ARM
laptops and then hope to use our experiences to drive future platforms
and get it included fully in the Linux cert program. Right now the X13s
is a trial/test project to see how far we can push it.

Re: [External] Re: qcom: Add firmware for Lenovo ThinkPad X13s

[Dmitry Baryshkov]

On 05/08/2022 15:43, Mark Pearson wrote:
> Hi Dmitry
> 
> On 8/5/22 05:36, Dmitry Baryshkov wrote:
>> On 03/08/2022 23:37, Mark Pearson wrote:
>>> The following changes since commit
>>> 150864a4d73e8c448eb1e2c68e65f07635fe1a66:
>>>
>>>     amdgpu partially revert "amdgpu: update beige goby to release 22.20"
>>> (2022-07-25 14:16:04 -0400)
>>>
>>> are available in the Git repository at:
>>>
>>>    
>>> https://github.com/mrhpearson/linux-firmware>>> lenovo-thinkpad-x13s
>>>
>>> for you to fetch changes up to 4ae4ae88918928e15006eb129ad981aa58216b59:
>>>
>>>     qcom: Add firmware for Lenovo ThinkPad X13s (2022-08-03 16:29:07
>>> -0400)
>>
>> Mark, it's so great to see firmware packages for Lenovo laptops being
>> submitted!
>>
>>>
>>> ----------------------------------------------------------------
>>> Mark Pearson (1):
>>>         qcom: Add firmware for Lenovo ThinkPad X13s
>>>
>>>    WHENCE                             |   8 ++++++++
>>>    qcom/LENOVO/21BX/adspr.jsn         |  28 ++++++++++++++++++++++++++++
>>>    qcom/LENOVO/21BX/adspua.jsn        |  29 +++++++++++++++++++++++++++++
>>>    qcom/LENOVO/21BX/battmgr.jsn       |  22 ++++++++++++++++++++++
>>>    qcom/LENOVO/21BX/cdspr.jsn         |  22 ++++++++++++++++++++++
>>>    qcom/LENOVO/21BX/qcadsp8280.mbn    | Bin 0 -> 14367860 bytes
>>>    qcom/LENOVO/21BX/qccdsp8280.mbn    | Bin 0 -> 3575808 bytes
>>>    qcom/LENOVO/21BX/qcdxkmsuc8280.mbn | Bin 0 -> 14392 bytes
>>>    qcom/LENOVO/21BX/qcslpi8280.mbn    | Bin 0 -> 6213632 bytes

Another nit to consider. I suppose that these files follow the name for 
them on the window platform. Another point to consider is to rename the 
files to follow the usual pattern that we have on other platforms 
(adsp.mbn instead of qcadsp8280.mbn).

But as with the paths, the final decision should be probably in hands of 
Bjorn and linux-firmware maintainers.

[skipped]

>>
>> P.S. Can we hope to get firmware for older laptops to be published too?
>> It would be really great if it would be possible to provide full support
>> for Yoga C630 or Flex5G using redistributable firmware from linux-firmware.
>>
> I looked into this previously for the C630 and was nacked I'm afraid.
> 
> Going back to the older platforms is a harder ask unfortunately because
> along with the FW you really need changes in the boot loader and I know
> I won't win that argument.

Well... We would be happy if we can get redistributable FW even without 
bootloader changes.

We have been successfully running Linux on C630 and Flex5G by manually 
fetching the firmware from the Windows partitions. Getting it into 
linux-firmware would help major distros to support those laptops without 
having to resort to 'read files from Win partition' hacks.

> I'll try again once we get a bit further along with this platform but
> realistically, the chances of it happening are small. I'm (quite openly)
> using this PoC project to prove that we can do Linux on one of our ARM
> laptops and then hope to use our experiences to drive future platforms
> and get it included fully in the Linux cert program. Right now the X13s
> is a trial/test project to see how far we can push it.

Yes, let's focus on getting the firmware X13s in, sort all arising 
questions and then, if possible, use that as a lever to help publishing 
fw for older models. Fingers crossed.

-- 
With best wishes
Dmitry

Re: qcom: Add firmware for Lenovo ThinkPad X13s

[Rob Clark]

On Fri, Aug 5, 2022 at 2:37 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On 03/08/2022 23:37, Mark Pearson wrote:
> > The following changes since commit 150864a4d73e8c448eb1e2c68e65f07635fe1a66:
> >
> >    amdgpu partially revert "amdgpu: update beige goby to release 22.20"
> > (2022-07-25 14:16:04 -0400)
> >
> > are available in the Git repository at:
> >
> >    https://github.com/mrhpearson/linux-firmware lenovo-thinkpad-x13s
> >
> > for you to fetch changes up to 4ae4ae88918928e15006eb129ad981aa58216b59:
> >
> >    qcom: Add firmware for Lenovo ThinkPad X13s (2022-08-03 16:29:07 -0400)
>
> Mark, it's so great to see firmware packages for Lenovo laptops being
> submitted!
>
> >
> > ----------------------------------------------------------------
> > Mark Pearson (1):
> >        qcom: Add firmware for Lenovo ThinkPad X13s
> >
> >   WHENCE                             |   8 ++++++++
> >   qcom/LENOVO/21BX/adspr.jsn         |  28 ++++++++++++++++++++++++++++
> >   qcom/LENOVO/21BX/adspua.jsn        |  29 +++++++++++++++++++++++++++++
> >   qcom/LENOVO/21BX/battmgr.jsn       |  22 ++++++++++++++++++++++
> >   qcom/LENOVO/21BX/cdspr.jsn         |  22 ++++++++++++++++++++++
> >   qcom/LENOVO/21BX/qcadsp8280.mbn    | Bin 0 -> 14367860 bytes
> >   qcom/LENOVO/21BX/qccdsp8280.mbn    | Bin 0 -> 3575808 bytes
> >   qcom/LENOVO/21BX/qcdxkmsuc8280.mbn | Bin 0 -> 14392 bytes
> >   qcom/LENOVO/21BX/qcslpi8280.mbn    | Bin 0 -> 6213632 bytes
> >   9 files changed, 109 insertions(+)
> >   create mode 100644 qcom/LENOVO/21BX/adspr.jsn
> >   create mode 100644 qcom/LENOVO/21BX/adspua.jsn
> >   create mode 100644 qcom/LENOVO/21BX/battmgr.jsn
> >   create mode 100644 qcom/LENOVO/21BX/cdspr.jsn
> >   create mode 100755 qcom/LENOVO/21BX/qcadsp8280.mbn
> >   create mode 100755 qcom/LENOVO/21BX/qccdsp8280.mbn
> >   create mode 100755 qcom/LENOVO/21BX/qcdxkmsuc8280.mbn
> >   create mode 100755 qcom/LENOVO/21BX/qcslpi8280.mbn
>
> I think it's the time to settle onto firmware paths for the
> Qualcomm-based devices. At some point it was proposed to use
> qcom/<SoC>/device/*mbn.
>
> So, in your case it could be qcom/sc8280xp/Lenovo_21BX/

I don't think it is a good idea.. we should stick to a path that can
be constructed from SMBIOS fields if we ever want a chance to get ACPI
boot with acceleration working

BR,
-R

>
> Bjorn, WDYT?
>
>
> P.S. Can we hope to get firmware for older laptops to be published too?
> It would be really great if it would be possible to provide full support
> for Yoga C630 or Flex5G using redistributable firmware from linux-firmware.
>
> --
> With best wishes
> Dmitry

Re: qcom: Add firmware for Lenovo ThinkPad X13s

[Dmitry Baryshkov]

On 05/08/2022 23:09, Rob Clark wrote:
> On Fri, Aug 5, 2022 at 2:37 AM Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
>>
>> On 03/08/2022 23:37, Mark Pearson wrote:
>>> The following changes since commit 150864a4d73e8c448eb1e2c68e65f07635fe1a66:
>>>
>>>     amdgpu partially revert "amdgpu: update beige goby to release 22.20"
>>> (2022-07-25 14:16:04 -0400)
>>>
>>> are available in the Git repository at:
>>>
>>>     https://github.com/mrhpearson/linux-firmware lenovo-thinkpad-x13s
>>>
>>> for you to fetch changes up to 4ae4ae88918928e15006eb129ad981aa58216b59:
>>>
>>>     qcom: Add firmware for Lenovo ThinkPad X13s (2022-08-03 16:29:07 -0400)
>>
>> Mark, it's so great to see firmware packages for Lenovo laptops being
>> submitted!
>>
>>>
>>> ----------------------------------------------------------------
>>> Mark Pearson (1):
>>>         qcom: Add firmware for Lenovo ThinkPad X13s
>>>
>>>    WHENCE                             |   8 ++++++++
>>>    qcom/LENOVO/21BX/adspr.jsn         |  28 ++++++++++++++++++++++++++++
>>>    qcom/LENOVO/21BX/adspua.jsn        |  29 +++++++++++++++++++++++++++++
>>>    qcom/LENOVO/21BX/battmgr.jsn       |  22 ++++++++++++++++++++++
>>>    qcom/LENOVO/21BX/cdspr.jsn         |  22 ++++++++++++++++++++++
>>>    qcom/LENOVO/21BX/qcadsp8280.mbn    | Bin 0 -> 14367860 bytes
>>>    qcom/LENOVO/21BX/qccdsp8280.mbn    | Bin 0 -> 3575808 bytes
>>>    qcom/LENOVO/21BX/qcdxkmsuc8280.mbn | Bin 0 -> 14392 bytes
>>>    qcom/LENOVO/21BX/qcslpi8280.mbn    | Bin 0 -> 6213632 bytes
>>>    9 files changed, 109 insertions(+)
>>>    create mode 100644 qcom/LENOVO/21BX/adspr.jsn
>>>    create mode 100644 qcom/LENOVO/21BX/adspua.jsn
>>>    create mode 100644 qcom/LENOVO/21BX/battmgr.jsn
>>>    create mode 100644 qcom/LENOVO/21BX/cdspr.jsn
>>>    create mode 100755 qcom/LENOVO/21BX/qcadsp8280.mbn
>>>    create mode 100755 qcom/LENOVO/21BX/qccdsp8280.mbn
>>>    create mode 100755 qcom/LENOVO/21BX/qcdxkmsuc8280.mbn
>>>    create mode 100755 qcom/LENOVO/21BX/qcslpi8280.mbn
>>
>> I think it's the time to settle onto firmware paths for the
>> Qualcomm-based devices. At some point it was proposed to use
>> qcom/<SoC>/device/*mbn.
>>
>> So, in your case it could be qcom/sc8280xp/Lenovo_21BX/
> 
> I don't think it is a good idea.. we should stick to a path that can
> be constructed from SMBIOS fields if we ever want a chance to get ACPI
> boot with acceleration working

Yes, it's also true. I do not quite like the idea that we are going to 
end up with two different path types. One using the DMI/SMBIOS ids, 
another one using SoC and machine id. Maybe we can settle on using 
SoC+id and then using DMI-based links.

There is another point to remember. I can imagine that once WoA/LoA 
laptops are more common, there can be several different DMI models 
sharing common firmware. So, there will be symlinks involved anyway.


-- 
With best wishes
Dmitry