From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F23FFA372A for ; Thu, 17 Oct 2019 11:10:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60BE021835 for ; Thu, 17 Oct 2019 11:10:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="IUQrgY45"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="IUQrgY45" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406082AbfJQLKR (ORCPT ); Thu, 17 Oct 2019 07:10:17 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59792 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405285AbfJQLKR (ORCPT ); Thu, 17 Oct 2019 07:10:17 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id BBB6060ACF; Thu, 17 Oct 2019 11:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1571310616; bh=0gfqhLwHCyiY74iUPkYmU05BOXYOwFmZ8CqXNfYxPTM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=IUQrgY45sEaG+9T4Gef7R9CyK7ONF5WyX5NevM/iJBahHu2Kz2vMtxx2ulA9aL6IC VYYB5bfLo0F4JDOSMyUuFO+ZLi2OlfY0JmSzvSChFTPhN0EYlhBagKEL91EmfNKVPW VhKLmoMz1g4N1wfgmu9nddddllRr/B2tmg1oqMIc= Received: from [10.252.222.65] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akashast@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3D16F60A74; Thu, 17 Oct 2019 11:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1571310616; bh=0gfqhLwHCyiY74iUPkYmU05BOXYOwFmZ8CqXNfYxPTM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=IUQrgY45sEaG+9T4Gef7R9CyK7ONF5WyX5NevM/iJBahHu2Kz2vMtxx2ulA9aL6IC VYYB5bfLo0F4JDOSMyUuFO+ZLi2OlfY0JmSzvSChFTPhN0EYlhBagKEL91EmfNKVPW VhKLmoMz1g4N1wfgmu9nddddllRr/B2tmg1oqMIc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3D16F60A74 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=akashast@codeaurora.org Subject: Re: [PATCH V2 2/2] tty: serial: qcom_geni_serial: Wakeup over UART RX To: Stephen Boyd , gregkh@linuxfoundation.org Cc: linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, mgautam@codeaurora.org, bjorn.andersson@linaro.org References: <1570700803-17566-1-git-send-email-akashast@codeaurora.org> <5d9f3f4f.1c69fb81.5120f.b90e@mx.google.com> <5da627aa.1c69fb81.e2d51.203d@mx.google.com> From: Akash Asthana Message-ID: Date: Thu, 17 Oct 2019 16:40:10 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <5da627aa.1c69fb81.e2d51.203d@mx.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 10/16/2019 1:40 AM, Stephen Boyd wrote: > Quoting Akash Asthana (2019-10-11 02:48:42) >> On 10/10/2019 7:55 PM, Stephen Boyd wrote: >>> Quoting Akash Asthana (2019-10-10 02:46:43) >>>> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c >>>> index 5180cd8..ff63728 100644 >>>> --- a/drivers/tty/serial/qcom_geni_serial.c >>>> +++ b/drivers/tty/serial/qcom_geni_serial.c >>>> @@ -1306,6 +1317,29 @@ static int qcom_geni_serial_probe(struct platform_device *pdev) >>>> + if (port->wakeup_irq < 0) { >>>> + dev_err(&pdev->dev, "Failed to get wakeup IRQ %d\n", >>>> + port->wakeup_irq); >>>> + } else { >>>> + irq_set_status_flags(port->wakeup_irq, IRQ_NOAUTOEN); >>>> + ret = devm_request_irq(uport->dev, port->wakeup_irq, >>>> + qcom_geni_serial_wakeup_isr, >>>> + IRQF_TRIGGER_FALLING, "uart_wakeup", uport); >>>> + if (ret) { >>>> + dev_err(uport->dev, "Failed to register wakeup IRQ ret %d\n", >>>> + ret); >>>> + return ret; >>>> + } >>>> + >>>> + device_init_wakeup(&pdev->dev, true); >>>> + ret = dev_pm_set_wake_irq(&pdev->dev, port->wakeup_irq); >>> Why can't we use dev_pm_set_dedicated_wake_irq() here? >> If we use this API then handler "handle_threaded_wake_irq" uses device >> specific pm_runtime functions to wake the device and currently this >> >> driver don't support runtime PM callbacks. Also, we want to register >> "qcom_geni_serial_wakeup_isr" as our IRQ handler for wakeup scenario. >> > Why can't we make this driver use runtime PM? Currently there are no plans to use runtime PM as we are interested in enabling wakeup irq as part of system suspend only. -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project