From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C94D233712 for ; Fri, 16 May 2025 10:11:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747390301; cv=none; b=ChLWpb69Yq7Hjsd7BI5w0zYNNmAHwa/Ix0i3HhqV974BYP2fo5UkL/kj8MOYPFTqVtNS7+MljWLnp3WCVflf+TcBVNmpfjOMwiQMfqNhstZK/k4RyOaEJmCiT6GVZo3FENIm+edRP5kC6Wn0hkxLHKX2t4aL1qqQZ71C81NgIy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747390301; c=relaxed/simple; bh=PHD79eIwWCw9V5lNQ7QYdkVLrAR+HF/Hje38keTFPFc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FoE2gNaXFLfSw6AB8xVl+dyqepvx02UuJdkNERYLEh+MSUQqMMoIVQAOiXQgsQKi8nR2XFe3p5eMZQeVVqu8rJrn8Ix1gg7ITYvg+BTu9rTjz8UZ77k68rgBqkYZDL/bE9UHgN3EjFiFPlCoDMBFPdn3Qy59+/DEOpV1PscNYvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SvH+DbcZ; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SvH+DbcZ" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a363d15c64so59244f8f.3 for ; Fri, 16 May 2025 03:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747390298; x=1747995098; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FK5emDR4y7307fTZlqtGJXVVpQCgklOy57Bb5kZPQdc=; b=SvH+DbcZuDdpa8iXC1jr2c3Ywxtm6z2bWqo3ZhCsITj2rL4pkwvBvrsXK+FpSckHSq Sq89UwmY6BihghzgV6Il7Ks+rSQBKruOHIjRefNhNLl8KKIrhUERQME62NWoa27KoWpf jWoUFJfiYRwNP/eBDjl2JtviHPapZB2jQqbHBW3i74/QEqovQgf50WD3y3OlukGLmLkH +LTsYyQBQPeOuOroa8sBS/Jdj6VDIatNioNIeG38322dsqD2R9mjvETyupOM+aOzK6W0 8ioGQiMgAbEHgCr8gGSslMTisds8iUk279eu/amA3NXsN2hxXq8PXy6/uuI61bYVGzcz ig7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747390298; x=1747995098; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FK5emDR4y7307fTZlqtGJXVVpQCgklOy57Bb5kZPQdc=; b=dHlAhzDf/Sj+MaDaq81rnAwvOoi0eKoLxtKF4mjJEmg0fmSbc/KvSjgmiOovle6Ufw M2lacxHyN7JTeGTvWjG3faNPWsQsBUla97gqwD6i+Mht/YV68OyQLkH40HFtQJPdaKfs 5d/64dmsRz0GiN5LnlBWNbgzKdZT8V5bv30254HyHzLqCCEe0FG5Qz0yx1Bmb+HYToJ1 69hAGDK8XyBbdBNYozRHjQWSyzOYTfa8/pzx8Bu2c/d0L9UpKg/NOt/3Itvrk9l2o9jY /8UGzRlNvWY+tj/sU4qHX5P2LQkLK/Na0lz4/JUbwDwzfEvy7YHUf1Q1EL7Amg2Xo2L/ SuJw== X-Forwarded-Encrypted: i=1; AJvYcCXuv5IfK2EomopKJB5LECYQ7O0tCd5SywOYUtyW6WaEOkOSDc6zqbrl0eppQ50NdEAp4Zd+R8lXzIBUIBLS@vger.kernel.org X-Gm-Message-State: AOJu0YxpSm/o9XYZvqxJfR6+ySwFBAYxca5InBH5kMjo308ltrbAeLnS ycNJGBlfW0ZzdGkOpt4Om/xh4lrCG0iOcbF9MZ1VRba3B1XeaPhNoUzfwx2nKtTKKTU= X-Gm-Gg: ASbGncsUY1WlDETQI5Ano5GE6wCZLLFvUJIllzIY6GVMZIpqxJ6dcarLvi+cXgBycW+ CiOJuDoeAfZeyuvZG5ox8FGJSpEOg6izWeZyVYdaGQTGwL/4NgDi64jMAH8yn5uhkCKHZ7gktCI ZUy/n/eZTZWbVBMk6jUIq/JSlnWTHPE+HixKPmGKFnK/OH4DXKSsFx7XCV5CY5B9/PB144FSeEx NJcA4xttCxV8SbL6eTCYSg5AD5SsFDnSpE+aYAja4QlvQL3wo/K0ncrpWF4qTyF1FEmFwgI+gmH gBlQdiFMWRjbvHDlLa3db22uhIGfS5zHNh86Nzfd4ww3UusecAh88PeNoXP4E/E7uncHn0HtL1Z zX0DSVIH47XrH X-Google-Smtp-Source: AGHT+IENqe0ySJELs1LHO+iGEWDGqtm1yvWiW49LkEbYEHxbTK/1es1hMOvGyGFEKYjY38sVDEx5OA== X-Received: by 2002:a05:6000:3110:b0:3a0:b550:ded4 with SMTP id ffacd0b85a97d-3a35c821bbcmr2765151f8f.13.1747390297854; Fri, 16 May 2025 03:11:37 -0700 (PDT) Received: from [10.61.1.70] (110.8.30.213.rev.vodafone.pt. [213.30.8.110]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a3620dbc6asm1284004f8f.88.2025.05.16.03.11.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 03:11:37 -0700 (PDT) Message-ID: Date: Fri, 16 May 2025 11:11:36 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] media: venus: fix TOCTOU vulnerability when reading packets from shared memory To: Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Stanimir Varbanov , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vedang Nagar References: <20250514-venus-fixes-v3-0-32298566011f@quicinc.com> <20250514-venus-fixes-v3-1-32298566011f@quicinc.com> <0c50c24a-35fa-acfb-a807-b4ed5394506b@quicinc.com> <767909a0-70ea-47d3-b6bf-b57e5d7e7c5c@linaro.org> <13887de6-4f84-9d0c-bd48-de6f0472d9ef@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <13887de6-4f84-9d0c-bd48-de6f0472d9ef@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/05/2025 19:25, Vikash Garodia wrote: > Check the pseudo code which i proposed earlier in this conversation [1]. It does > not rely on ptr_val at all to check the sanity after memcpy. > > [1]https://lore.kernel.org/all/0c50c24a-35fa-acfb-a807- > b4ed5394506b@quicinc.com/ Understood. Another version of this patch to check after the memcpy() for verification purposes might be correct but, IMO there's no scope for a TOCTOU based modification here. --- bod