From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raju P L S S S N Subject: Re: [PATCH 1/7] drivers: qcom: rpmh-rsc: fix the loop index check in get_req_from_tcs Date: Thu, 19 Jul 2018 13:45:44 +0530 Message-ID: References: <1531984382-11780-1-git-send-email-rplsssn@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1531984382-11780-1-git-send-email-rplsssn@codeaurora.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: andy.gross@linaro.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org Cc: rnayak@codeaurora.org, bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org, sboyd@kernel.org, evgreen@chromium.org, dianders@chromium.org, mka@chromium.org, ilina@codeaurora.org List-Id: linux-arm-msm@vger.kernel.org Hi all, This is an independent patch and not part of patch set. There was some issue while sending the patch using git send-email. Please ignore 1/7 in the mail subject. Sorry for multiple mails. Thanks, Raju. On 7/19/2018 12:43 PM, Raju P L S S S N wrote: > From: "Raju P.L.S.S.S.N" > > get_req_from_tcs introduced in patch[1] returns tcs_request from > tcs_group. The size of tcs (of type - tcs_group) array in rsc_drv is > TCS_TYPE_NR. So the loop index needs to be iterated up to TCS_TYPE_NR only. > > [1] https://patchwork.kernel.org/patch/10477547/ > > Signed-off-by: Raju P.L.S.S.S.N > --- > drivers/soc/qcom/rpmh-rsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c > index fefda0f..33fe9f9 100644 > --- a/drivers/soc/qcom/rpmh-rsc.c > +++ b/drivers/soc/qcom/rpmh-rsc.c > @@ -190,7 +190,7 @@ static const struct tcs_request *get_req_from_tcs(struct rsc_drv *drv, > struct tcs_group *tcs; > int i; > > - for (i = 0; i < drv->num_tcs; i++) { > + for (i = 0; i < TCS_TYPE_NR; i++) { > tcs = &drv->tcs[i]; > if (tcs->mask & BIT(tcs_id)) > return tcs->req[tcs_id - tcs->offset]; >