From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D31E1C6FD18 for ; Thu, 20 Apr 2023 00:50:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232635AbjDTAu1 (ORCPT ); Wed, 19 Apr 2023 20:50:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232152AbjDTAuN (ORCPT ); Wed, 19 Apr 2023 20:50:13 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 017534EF6 for ; Wed, 19 Apr 2023 17:49:34 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id z38so915435ljq.12 for ; Wed, 19 Apr 2023 17:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681951771; x=1684543771; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nBTNgbwSnEqrTM/8Zo3F3tUjXoH2/yS/Mjd7eOQXnxA=; b=d4mVL2ra6uk1DxPznvuIlP+NohLtEcADu43dZmKn68AbF9I1zDQUZtYdsL9Ka0fhK3 yBoz6Y7I3MnVwjpbhFc9Th4t+ZXspnyWt7Lc6y12HI5yaJ6oqi4MJEWpl1d7uYP8stbM LNKY3VIrY9nuQjCTDZIOnB5RGi61FRnWR7cQ4mUK/Zf7IQ/ucseIb93BUhbJqZoJKQ/m z7tRSVl+KOi6Rk5qzuPo+pDa1Dr99MX2uMLjhsgfGnfHbDtTrro1EULq4qpm9VahfKvA VpcozY7D8YtZNPLSSDC+bUNOOjPLdDTCgCy4RrCInmG9axwD2Gd/JZj5qr3K9X17LUen jbhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681951771; x=1684543771; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nBTNgbwSnEqrTM/8Zo3F3tUjXoH2/yS/Mjd7eOQXnxA=; b=WmlMPEDTr5RRL9Kyt1Gk/02eVG8O7m5VaChfdHllNttBxWAUuYqHCbt4HoMKPP5YP7 xcruI3s4rC7ZNRp2ME4FFub++AQJp9DEO0pbPWCGtU4Ht9I2FPZ5oM0X86loI2O1+TJv 6nfaPhTNDsKnM7shtvJgbY0+zPFn1voJWPhKMnN1KiF7Rde+5ilOlizqU94jGlLaThgX 9odORwGOHFJHy0GTKIZiWSKgZr/F9rP+LdZtxRWdXHEw/13D0Ko+CpfWThfzWzU+26eA rjAJjcctfyWXOX/WdNTRIBVsrf4BsEp/hLz6GuVT4dUPBHgXrI7xFBOtJXVh1HkUjFVY oqjQ== X-Gm-Message-State: AAQBX9d4CcQTdrIJ5fIUF9HP6vjTVN7iBPySYFkWh0M+aC6WxEgQAULI +y3xK13eS8TCN/flQLct5LbtnA== X-Google-Smtp-Source: AKy350a58zmn+YohNF/dZT6zaO4ejf273w1HbL0Zriw2gCHMn/70LvEy/Q0m9ouzpmYgb6kSJCE2QA== X-Received: by 2002:a2e:6e0f:0:b0:2a8:bd3a:d418 with SMTP id j15-20020a2e6e0f000000b002a8bd3ad418mr2264178ljc.52.1681951771044; Wed, 19 Apr 2023 17:49:31 -0700 (PDT) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id w4-20020a2e9584000000b002a8bae7f9e8sm17599ljh.129.2023.04.19.17.49.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 17:49:30 -0700 (PDT) Message-ID: Date: Thu, 20 Apr 2023 03:49:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 09/17] drm/msm/dpu: Move autorefresh disable from CMD encoder to pingpong Content-Language: en-GB To: Marijn Suijten , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Adam Skladowski , Loic Poulain , Bjorn Andersson , Kuogee Hsieh , Robert Foss , Vinod Koul , Rajesh Yadav , Jeykumar Sankaran , Neil Armstrong , Chandan Uddaraju Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jordan Crouse , Archit Taneja , Sravanthi Kollukuduru References: <20230411-dpu-intf-te-v2-0-ef76c877eb97@somainline.org> <20230411-dpu-intf-te-v2-9-ef76c877eb97@somainline.org> From: Dmitry Baryshkov In-Reply-To: <20230411-dpu-intf-te-v2-9-ef76c877eb97@somainline.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 17/04/2023 23:21, Marijn Suijten wrote: > This autorefresh disable logic in the physical command-mode encoder > consumes three callbacks to the pingpong block, and will explode in > unnecessary complexity when the same callbacks need to be called on the > interface block instead to accommodate INTF TE support. To clean this > up, move the logic into the pingpong block under a disable_autorefresh > callback, replacing the aforementioned three get_autorefresh, > setup_autorefresh and get_vsync_info callbacks. > > The same logic will have to be replicated to the interface block when it > receives INTF TE support, but it is less complex than constantly > switching on a "has_intf_te" boolean to choose a callback. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Marijn Suijten > --- > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 60 ++-------------------- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 47 +++++++++++++++-- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 25 ++------- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4 ++ > 4 files changed, 57 insertions(+), 79 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry