From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vikram Sharma <quic_vikramsa@quicinc.com>,
rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andersson@kernel.org, konradybcio@kernel.org,
hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org,
catalin.marinas@arm.com, will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/7] media: qcom: camss: enable csid 690 for qcs8300
Date: Wed, 13 Aug 2025 22:33:44 +0100 [thread overview]
Message-ID: <c467e3a9-2c67-4231-9d64-d64de08ec2ce@linaro.org> (raw)
In-Reply-To: <20250813053724.232494-5-quic_vikramsa@quicinc.com>
On 13/08/2025 06:37, Vikram Sharma wrote:
> The CSID in qcs8300 is version 690, it is same as csid used in
> lemans(sa8775p). csid gen3 have support for csid 690.
>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> ---
> drivers/media/platform/qcom/camss/camss-csid-gen3.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen3.c b/drivers/media/platform/qcom/camss/camss-csid-gen3.c
> index fc6a9787febe..664245cf6eb0 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid-gen3.c
> +++ b/drivers/media/platform/qcom/camss/camss-csid-gen3.c
> @@ -45,7 +45,8 @@
> #define CSID_CSI2_RX_IRQ_CLEAR 0xA4
> #define CSID_CSI2_RX_IRQ_SET 0xA8
>
> -#define IS_CSID_690(csid) (csid->camss->res->version == CAMSS_8775P)
> +#define IS_CSID_690(csid) ((csid->camss->res->version == CAMSS_8775P) \
> + || (csid->camss->res->version == CAMSS_8300))
> #define CSID_BUF_DONE_IRQ_STATUS 0x8C
> #define BUF_DONE_IRQ_STATUS_RDI_OFFSET (csid_is_lite(csid) ?\
> 1 : (IS_CSID_690(csid) ?\
This really feels like it should be a property of the CSID not of the
SoC but... anyway it'll do for now.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2025-08-13 21:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 5:37 [PATCH v3 0/7] qcom: qcs8300: Add qcs8300 camss support Vikram Sharma
2025-08-13 5:37 ` [PATCH v3 1/7] media: dt-bindings: Add qcom,qcs8300-camss compatible Vikram Sharma
2025-08-13 21:31 ` Bryan O'Donoghue
2025-08-13 5:37 ` [PATCH v3 2/7] media: qcom: camss: Add qcs8300 compatible Vikram Sharma
2025-08-13 5:37 ` [PATCH v3 3/7] media: qcom: camss: Add CSIPHY support for QCS8300 Vikram Sharma
2025-08-13 21:32 ` Bryan O'Donoghue
2025-08-13 5:37 ` [PATCH v3 4/7] media: qcom: camss: enable csid 690 for qcs8300 Vikram Sharma
2025-08-13 21:33 ` Bryan O'Donoghue [this message]
2025-08-14 6:54 ` Vikram Sharma
2025-08-13 5:37 ` [PATCH v3 5/7] media: qcom: camss: enable vfe " Vikram Sharma
2025-08-13 21:35 ` Bryan O'Donoghue
2025-08-13 5:37 ` [PATCH v3 6/7] media: qcom: camss: Enumerate resources for QCS8300 Vikram Sharma
2025-08-13 5:37 ` [PATCH v3 7/7] arm64: dts: qcom: qcs8300: Add support for camss Vikram Sharma
2025-08-13 21:37 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c467e3a9-2c67-4231-9d64-d64de08ec2ce@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_vikramsa@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).