Re: [DPU PATCH 1/3] drm/msm: Fix uninitialized use of prefill_lines

[ryadav-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org]

On 2018-04-03 01:40, Sean Paul wrote:
> prefill_lines initialization was removed in da61c67cdec4, but it's 
> still
> being used :(
> 
> Fixes: da61c67cdec4 drm/msm: remove hw rotation support
> Cc: Jeykumar Sankaran <jsanka@codeaurora.org>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Rajesh Yadav <ryadav@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 7f4182294dfd..53f5d5c52063 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -1231,7 +1231,7 @@ static int _dpu_encoder_update_rsc_client(
>  	struct drm_crtc *crtc;
>  	enum dpu_rsc_state rsc_state;
>  	struct dpu_rsc_cmd_config *rsc_config;
> -	int ret, prefill_lines;
> +	int ret;
>  	struct msm_display_info *disp_info;
>  	struct msm_mode_info *mode_info;
>  	int wait_vblank_crtc_id = DPU_RSC_INVALID_CRTC_ID;
> @@ -1273,7 +1273,7 @@ static int _dpu_encoder_update_rsc_client(
>  	    (rsc_config->jitter_denom != mode_info->jitter_denom)) {
>  		rsc_config->fps = mode_info->frame_rate;
>  		rsc_config->vtotal = mode_info->vtotal;
> -		rsc_config->prefill_lines = prefill_lines;
> +		rsc_config->prefill_lines = mode_info->prefill_lines;
>  		rsc_config->jitter_numer = mode_info->jitter_numer;
>  		rsc_config->jitter_denom = mode_info->jitter_denom;
>  		dpu_enc->rsc_state_init = false;
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno