Re: [RFC PATCH 01/10] dt-bindings: thermal: tsens: support per-sensor calibration cells

Amit Kucheria
2022-09-13T19:19:54Z

On Sat, Sep 10, 2022 at 6:17 PM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> Allow specifing the exact calibration mode and calibration data as nvmem

typo: specifying

> cells, rather than specifying just a single calibration data blob.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Reviewed-by: Amit Kucheria <amitk@kernel.org>

> ---
> .../bindings/thermal/qcom-tsens.yaml | 64 ++++++++++++++++---
> 1 file changed, 54 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index 038d81338fcf..b813f6f19c1d 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -77,18 +77,62 @@ properties:
> - const: critical
>
> nvmem-cells:
> - minItems: 1
> - maxItems: 2
> - description:
> - Reference to an nvmem node for the calibration data
> + oneOf:
> + - minItems: 1
> + maxItems: 2
> + description:
> + Reference to an nvmem node for the calibration data
> + - minItems: 5
> + maxItems: 35
> + description: |
> + Reference to an nvmem cells for the calibration mode, two calibration
> + bases and two cells per each sensor
>
> nvmem-cell-names:
> - minItems: 1
> - items:
> - - const: calib
> - - enum:
> - - calib_backup
> - - calib_sel
> + oneOf:
> + - minItems: 1
> + items:
> + - const: calib
> + - enum:
> + - calib_backup
> + - calib_sel
> + - minItems: 5
> + items:
> + - const: mode
> + - const: base1
> + - const: base2
> + - const: s0_p1
> + - const: s0_p2
> + - const: s1_p1
> + - const: s1_p2
> + - const: s2_p1
> + - const: s2_p2
> + - const: s3_p1
> + - const: s3_p2
> + - const: s4_p1
> + - const: s4_p2
> + - const: s5_p1
> + - const: s5_p2
> + - const: s6_p1
> + - const: s6_p2
> + - const: s7_p1
> + - const: s7_p2
> + - const: s8_p1
> + - const: s8_p2
> + - const: s9_p1
> + - const: s9_p2
> + - const: s10_p1
> + - const: s10_p2
> + - const: s11_p1
> + - const: s11_p2
> + - const: s12_p1
> + - const: s12_p2
> + - const: s13_p1
> + - const: s13_p2
> + - const: s14_p1
> + - const: s14_p2
> + - const: s15_p1
> + - const: s15_p2
>
> "#qcom,sensors":
> description:
> --
> 2.35.1
>