From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH v10 17/27] drivers: firmware: psci: Prepare to support PM domains Date: Thu, 20 Dec 2018 19:06:35 +0100 Message-ID: References: <20181129174700.16585-1-ulf.hansson@linaro.org> <20181129174700.16585-18-ulf.hansson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Ulf Hansson Cc: "Rafael J . Wysocki" , Sudeep Holla , Lorenzo Pieralisi , Mark Rutland , Linux PM , "Raju P . L . S . S . S . N" , Stephen Boyd , Tony Lindgren , Kevin Hilman , Lina Iyer , Viresh Kumar , Vincent Guittot , Geert Uytterhoeven , Linux ARM , linux-arm-msm , Linux Kernel Mailing List List-Id: linux-arm-msm@vger.kernel.org On 20/12/2018 16:49, Ulf Hansson wrote: [ ... ] >>> +#ifdef CONFIG_CPU_IDLE >> >> It would be nicer if you can remove the CONFIG_CPU_IDLE by replacing it >> with a specific one (eg. CONFIG_PSCI_IDLE) and make it depend on >> CONFIG_CPU_IDLE, so the config options stay contained in their >> respective subsystems directory. > > I am all for simplifying the Kconfig options in here, as indeed it's > rather messy. However, I would rather avoid folding in additional > cleanup changes to this series, is already extensive enough. > > Would you be okay if we deal with that on top? IMO, there are patches in this series which can be grouped into a cleanup + set the scene patchset and merged immediately. An option similar to ARM_SCMI_POWER_DOMAIN can be part of it. However, if you swear you will do the change after and sign with your blood, I'm fine with that 0:) -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog