From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephen Boyd <swboyd@chromium.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts
Date: Thu, 22 Sep 2022 14:19:22 +0200 [thread overview]
Message-ID: <c582130c-9a12-10c7-833b-542e48f6bf70@linaro.org> (raw)
In-Reply-To: <CAA8EJppqxMvn+bpHQ-49nBw6esdgRyft4aPj2410bq2tbL=94w@mail.gmail.com>
On 22/09/2022 12:30, Dmitry Baryshkov wrote:
>>> + display-subsystem@ae00000 {
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + compatible = "qcom,sc7180-mdss";
>>> + reg = <0xae00000 0x1000>;
>>> + reg-names = "mdss";
>>> + power-domains = <&dispcc MDSS_GDSC>;
>>> + clocks = <&gcc GCC_DISP_AHB_CLK>,
>>> + <&dispcc DISP_CC_MDSS_AHB_CLK>,
>>> + <&dispcc DISP_CC_MDSS_MDP_CLK>;
>>> + clock-names = "iface", "ahb", "core";
>>> +
>>> + interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
>>> + interrupt-controller;
>>> + #interrupt-cells = <1>;
>>> +
>>> + interconnects = <&mmss_noc MASTER_MDP0 &mc_virt SLAVE_EBI1>;
>>> + interconnect-names = "mdp0-mem";
>>> +
>>> + iommus = <&apps_smmu 0x800 0x2>;
>>> + ranges;
>>
>> This should come with full example, so with display-controller child
>> (unless Rob asked not to?)
>
> I'm not sure here. We have an example of a display-controller in a
> separate schema file. Why would you like to duplicate it?
To validate the child node (display-controller) in the context of this
schema. The child node is essential, so I would also say that example is
incomplete.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-22 12:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 13:37 [PATCH v7 00/12] dt-bindings: display/msm: rework MDSS and DPU bindings Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 01/12] dt-bindings: display/msm: split qcom,mdss bindings Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 02/12] dt-bindings: display/msm: add gcc-bus clock to dpu-smd845 Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 03/12] dt-bindings: display/msm: add interconnects property to qcom,mdss-smd845 Dmitry Baryshkov
2022-09-22 7:00 ` Krzysztof Kozlowski
2022-09-15 13:37 ` [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml Dmitry Baryshkov
2022-09-22 7:02 ` Krzysztof Kozlowski
2022-09-22 7:50 ` Dmitry Baryshkov
2022-09-22 11:41 ` Krzysztof Kozlowski
2022-09-15 13:37 ` [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml Dmitry Baryshkov
2022-09-22 7:04 ` Krzysztof Kozlowski
2022-09-22 11:46 ` Dmitry Baryshkov
2022-09-22 12:28 ` Krzysztof Kozlowski
2022-09-23 20:32 ` Dmitry Baryshkov
2022-10-03 7:55 ` Krzysztof Kozlowski
2022-09-22 7:05 ` Krzysztof Kozlowski
2022-09-22 7:53 ` Dmitry Baryshkov
2022-09-22 11:43 ` Krzysztof Kozlowski
2022-09-22 11:47 ` Dmitry Baryshkov
2022-09-22 12:27 ` Krzysztof Kozlowski
2022-09-15 13:37 ` [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts Dmitry Baryshkov
2022-09-22 7:08 ` Krzysztof Kozlowski
2022-09-22 10:30 ` Dmitry Baryshkov
2022-09-22 12:19 ` Krzysztof Kozlowski [this message]
2022-09-15 13:37 ` [PATCH v7 07/12] dt-bindings: display/msm: split dpu-sc7280 " Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 08/12] dt-bindings: display/msm: split dpu-sdm845 " Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 09/12] dt-bindings: display/msm: split dpu-msm8998 " Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 10/12] dt-bindings: display/msm: split dpu-qcm2290 " Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas Dmitry Baryshkov
2022-09-22 7:09 ` Krzysztof Kozlowski
2022-09-15 13:37 ` [PATCH v7 12/12] dt-bindings: display/msm: add support for the display on SM8250 Dmitry Baryshkov
2022-09-22 7:10 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c582130c-9a12-10c7-833b-542e48f6bf70@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).