From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACC973081C5 for ; Mon, 10 Nov 2025 11:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762774677; cv=none; b=FSh1oRrOSgSRHv/MBUDJ1GCUXaDeSbs/0KErQkWLcnwecsA0tAoEuBaO2YiP0nO/ODWHOtfuX/wHY1ICiPMXp4p+XcVb5mDEhuXCg3SV4jdEt8XkFcwQBAeNQ4qgQCQDc7A2llilmrmUM4QctIzNDPxuTHQB/6MBDY9TIJcqVGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762774677; c=relaxed/simple; bh=bYvCRDJ8Gv1dOfdRqfRo9yHHV4IK3gLVIJ6PseVpKNo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N7iNLLWPdr1mlzVNPoh0FaUHTm507GaYcO1GJisAxIoTozyN9YY4WV1tAEnZPbhZ4eURmmLSl+hgCLvSeZqz4rlRFmledK9JovtR5gDWZIbrawPJtFSIYFBxj20+KR/AoLzPwLhjuYnBESHC7LeZkOc3glvZH0orq1YTp3x1uJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GK4xGvDu; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GK4xGvDu" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-42b3b29153fso511636f8f.3 for ; Mon, 10 Nov 2025 03:37:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762774674; x=1763379474; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lbIPi1f3TQjYD0qdQrLeTSWV5sgjs9x+ZurWSxF6us4=; b=GK4xGvDuKd3J3N0sFhw+qRe8dRFQj5wcWAsGkekk3jTlXEPJBJCtpwGfDw61uAmiTJ TJqDU7HOfO+3wwsSW/zBox6lNgj++WhnkbuVx+kbIpPH5aFq/PyjZmG9OcgHmPw6DPHQ taa8VW8ykh0uk9ehI4Uu/NThH21j5xy94btfr8F/IMC/mCNzwNsNJ88Svspja7jzgGkp 0Y5UOXzBYVEPmrMOF2Z1lux9cQ1xmp1QglCEnaLnl67dm5bP9AOuu1lxqJv0nQ60Sn3J pa9VC0QTkqrDzgjJjX8UpN+nrMivCynm72+Y9wCFdbdKiE1JyHwXS16I/VEIAx1zJKlb sq4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762774674; x=1763379474; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lbIPi1f3TQjYD0qdQrLeTSWV5sgjs9x+ZurWSxF6us4=; b=hSlr/hDyE/3Oks+IVVbd4SSoAUl+NXq6WXALANJJwcREvoISVqYP3umw0nOv5qYnRT xWKfApov7L7XdAko2Ppvntam+iFnLN8n1/iIFP781SOD4nv+qd4Jz7BabU4KBHU5i1ke hPxu0GmcCG2Jr9Mihqxiu7oCxeD61AGEUjyUCEpKUjgfxwv7yVGmGFJmku+8MlNjQEHf 6aawV9ichjwv/lzVO2FQKsatx51p6Y7CgICLqvaXL+apAyRykqsF1kIt4niMNRTMjLNl F2IQU1Q4U3JBn82x/0TpRKFJN68EfXxE2rrBB/esI0nRjCwRhj4PkiBzhsZ53UFRLpke s8sw== X-Forwarded-Encrypted: i=1; AJvYcCUH8SW1TKmg3hfkJG/PuOG7QZ4GFiomilnWVYZ9RrSCXvEYy1SoTt5GAm/edjdlUBV2AlNtgLR0sBzPeLAZ@vger.kernel.org X-Gm-Message-State: AOJu0Yy7w1436b1Y6hnJLKxJy6pfzTYuT04LtpQ9B5KmffyAZY2uBXnl Ko0KxoR41NlN3M9v63soXu8Ywq/cgbG/jBxpEXVqtDrZ4gMBHLpVkhAI8c8LHMlvgJk= X-Gm-Gg: ASbGncubhC8kp+jDNoC5UXl8Apx6O8kVz+9bmKepXCOlF+J+WjSJg9ksLPSn38NdP4I 75ThqLU3xFQYCzwagB98GpjxEju5Oa0w82NfzDDKv0mWTWO/mccq2p41izoxpsybj7NywwVMGtX VtxMHm5g6wqS78nWxzk0I2ybWqXOvul0OfQt8tPU5xbMLJyj8JBZvv0SY+1tliqzN3eqvwWLJr+ vwS6+8EW+owAOQH4AsxgnVyC3XaqoIbfOwzj1EUjI6oSskd1LT3HBtqvTdRR/xfA7w8usxdDDOZ 1MOS9zZnWoLFlUKYxvXSuEX7OopaQR/A8uDh0IAtThq+92YbP4XiniYkoyzwYQgy2ZemEiOFIKF 5UqcuTJ4a+OFIz+N/wCHrTb6aJDYF+OBVt59cB918ZC8saC7dU9IfXxiK4LwgBUHVL/m89ZxLRa WocYnJ+XF/z5Mnpin8vzKNSOkvg9P9OyR188qDvky2N+vqVN7uVfCX X-Google-Smtp-Source: AGHT+IHA0EBLJZJ+ndV4OQ/knM5PV3CmaEKbnGaPdN8RNMmCv96/hD4FMnZxtX3a7xuoueGlr3MwOg== X-Received: by 2002:a05:6000:613:b0:42b:39d0:638d with SMTP id ffacd0b85a97d-42b39d06632mr2610262f8f.28.1762774674004; Mon, 10 Nov 2025 03:37:54 -0800 (PST) Received: from [192.168.0.21] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42ac677abeasm22015186f8f.33.2025.11.10.03.37.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Nov 2025 03:37:53 -0800 (PST) Message-ID: Date: Mon, 10 Nov 2025 11:37:52 +0000 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 4/8] media: qcom: camss: Prepare CSID for C-PHY support To: david@ixit.cz, Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , Casey Connolly , "Dr. Git" Cc: Joel Selvaraj , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20251109-qcom-cphy-v1-0-165f7e79b0e1@ixit.cz> <20251109-qcom-cphy-v1-4-165f7e79b0e1@ixit.cz> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20251109-qcom-cphy-v1-4-165f7e79b0e1@ixit.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/11/2025 09:39, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > Inherit C-PHY information from CSIPHY, so we can configure CSID > properly. > > CSI2_RX_CFG0_PHY_TYPE_SEL must be set to 1, when C-PHY mode is used. > > Signed-off-by: David Heidelberg > --- > drivers/media/platform/qcom/camss/camss-csid-gen2.c | 1 + > drivers/media/platform/qcom/camss/camss-csid.c | 1 + > drivers/media/platform/qcom/camss/camss-csid.h | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen2.c b/drivers/media/platform/qcom/camss/camss-csid-gen2.c > index 2a1746dcc1c5b..033036ae28a4f 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid-gen2.c > +++ b/drivers/media/platform/qcom/camss/camss-csid-gen2.c > @@ -183,6 +183,7 @@ static void __csid_configure_rx(struct csid_device *csid, > val = (lane_cnt - 1) << CSI2_RX_CFG0_NUM_ACTIVE_LANES; > val |= phy->lane_assign << CSI2_RX_CFG0_DL0_INPUT_SEL; > val |= phy->csiphy_id << CSI2_RX_CFG0_PHY_NUM_SEL; > + val |= csid->phy.cphy << CSI2_RX_CFG0_PHY_TYPE_SEL; > writel_relaxed(val, csid->base + CSID_CSI2_RX_CFG0); > > val = 1 << CSI2_RX_CFG1_PACKET_ECC_CORRECTION_EN; > diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c > index 5284b5857368c..68adea33cc719 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid.c > +++ b/drivers/media/platform/qcom/camss/camss-csid.c > @@ -1287,6 +1287,7 @@ static int csid_link_setup(struct media_entity *entity, > csid->phy.csiphy_id = csiphy->id; > > lane_cfg = &csiphy->cfg.csi2->lane_cfg; > + csid->phy.cphy = lane_cfg->cphy; > csid->phy.lane_cnt = lane_cfg->num_data; > csid->phy.lane_assign = csid_get_lane_assign(lane_cfg); > } > diff --git a/drivers/media/platform/qcom/camss/camss-csid.h b/drivers/media/platform/qcom/camss/camss-csid.h > index aedc96ed84b2f..a82db31bd2335 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid.h > +++ b/drivers/media/platform/qcom/camss/camss-csid.h > @@ -70,6 +70,7 @@ struct csid_phy_config { > u32 lane_assign; > u32 en_vc; > u8 need_vc_update; > + bool cphy; > }; > > struct csid_device; > I'm not convinced you need another flag for this. It should be possible for the CSID to get a pointer to the PHY and interrogate the encoded mode. --- bod