From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F88E1EE019; Fri, 17 Oct 2025 07:36:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760686610; cv=none; b=jSKkKI18FwzNbnaOaKxt7sfwN4ms8tH2PU44ejE7Q2GljTucJC1eReqyA4pfwEiv5nBTq3eFz9XcB0JtiQ/4O16Aswv/eyD9J39b6eANfpH4cpZb6BZ47QOEEcptbHkShEUBfbB0mFypZsNEfiBV6Tmuhh9+jCrbV5amYlP/6Uw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760686610; c=relaxed/simple; bh=0a4AvQVxlE5HThoshNnmiekoS3FChrg7c4bp7NdEtGc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pXLQ0nFQUcYZu8TShI63/tjm3dHjc8XLTHMf3n5JU91YZ6OYQQGWIxlQUKrf+pWoGZW+0Ry0oAtLDHdC1Lk+F5oeB5tjllJJpw8drKVHuaSqxADakHp7LnFppkgBlCp1mij/zUvavmq1sfqSUMGNgEXOw7kgNjKK6jsQX3yo5Bk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e8G8bBsJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e8G8bBsJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75BB4C4CEE7; Fri, 17 Oct 2025 07:36:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760686609; bh=0a4AvQVxlE5HThoshNnmiekoS3FChrg7c4bp7NdEtGc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=e8G8bBsJdRhZXzwfLH7pImO5jSb7vM0rp0RK2Fv4z4nr6TVpDCr1zj0WTmjbqLdUl oN4Ko4iuN/c6TXGY2gLENNCcAOc3wJNtYk8sRiJhIw4+nIt3tNtGnERZKaAXxx78pl b84SFY3nuWoF3tykqnEMfMc8RRDadXRJNhKoYmxf1NBqbfiC6wPi76sNAJfOxd3RCT Gn21xkmFNjHfbuZ/m9kXGREDmFk6dGZ2lE86Vr2AKLcx5znlR2eZ79HBau1LdJfOn7 3UeacmQHtUsvJHkKlwkZfZOepe1g/ej7TWxvhAxMnwdwsKKsdEOLN1OCJ6Zu19bUHN Gi7jrSxkoknBg== Message-ID: Date: Fri, 17 Oct 2025 09:36:45 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: defconfig: Change CONFIG_SM_TCSRCC_8750 from m to y To: Taniya Das , Taniya Das , Bjorn Andersson , linux-arm-msm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-kernel@vger.kernel.org References: <20251017-update_defconfig_tcsrcc_sm8750-v1-1-34b1b47a0bda@oss.qualcomm.com> <30390038-0f90-48a4-befe-475cf88ba1fb@kernel.org> <37f54b76-a274-4ce2-aaa9-88ba0eb84199@oss.qualcomm.com> <90c8dda3-f753-43dc-8bb9-d03a808c8704@kernel.org> <38b8468f-5006-46a3-a4ea-28e6692ef14a@quicinc.com> <03ac36fb-a227-438e-bdf6-f787e26008b3@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/10/2025 08:55, Taniya Das wrote: > > > On 10/17/2025 11:26 AM, Krzysztof Kozlowski wrote: >> On 17/10/2025 07:49, Taniya Das wrote: >>> >>> >>> On 10/17/2025 10:51 AM, Krzysztof Kozlowski wrote: >>>> On 17/10/2025 07:16, Taniya Das wrote: >>>>> >>>>> >>>>> On 10/17/2025 10:00 AM, Krzysztof Kozlowski wrote: >>>>>> On 16/10/2025 20:53, Taniya Das wrote: >>>>>>> The TCSR clock controller is required during boot to provide the ref >>>>>>> clocks to the UFS controller. Setting CONFIG_SM_TCSRCC_8750 to y ensures >>>>>>> the UFS driver successfully probe and initialize the device. >>>>>>> >>>>>>> Without this change, the UFS subsystem fails to mount as a usable file >>>>>>> system during boot. >>>>>> >>>>>> >>>>>> That's not what I observed. UFS works fine, especially that it is a >>>>>> module, so no, this is not a desired change and explanation is not only >>>>>> insufficient but actually incorrect. >>>>>> >>>>> >>>>> Krzysztof, on Pakala MTP we are observing the below issue and it >>>>> requires the module of tscrcc to be loaded explicitly. This patch also >>>>> aligns to how it is on all other targets. >>>>> >>>>> /soc@0/phy@1d80000: Failed to get clk index: 2 ret: -517 >>>>> [ 10.496570] ufshcd-qcom 1d84000.ufs: freq-table-hz property not specified >>>>> [ 10.503660] ufshcd-qcom 1d84000.ufs: ufshcd_populate_vreg: Unable to >>>>> find vdd-hba-supply regulator, assuming enabled >>>>> [ 10.514548] ufshcd-qcom 1d84000.ufs: ufshcd_populate_vreg: Unable to >>>>> find vccq2-supply regulator, assuming enabled >>>>> [ 10.565955] platform 1d80000.phy: deferred probe pending: (reason >>>>> unknown) >>>>> [ 10.573078] platform 1d84000.ufs: deferred probe pending: >>>>> ufshcd-qcom: ufshcd_pltfrm_init() failed >>>>> >>>> >>>> >>>> I don't and I am testing regularly, so I assume you have incorrect >>>> config. Maybe I have incorrect one (which works), but then commit msg is >>>> incomplete - you must explain the bug and provide proof that this is the >>>> correct fix for it. >>>> >>> >>> We have tried booting up recently and and that is what we observed. The >>> patch from 'm' to 'y' helps the UFS probe is successful and the rootfs >>> is picked from ufs partitions. I will add these fail & success log >>> snippets in the commit text. >> >> That's not enough. You need to explain why UFS fails. After explaining >> this, I guess bug in UFS would be exposed thus that one should be fixed. >> You just provided band-aid without fixing the real problem. >> > > When the kernel commandline uses is 'root=PARTLABEL=system', the is a > dependency of the UFS driver on the TCSRCC clockref during bootup and > the TCSRCC made as a module will not provide the clocks unless we No, that's not true. cmdline does not matter here at all. > explicitly load the modules. To meet this dependency we need to load root= has nothing to do with modules. > TCSRCC statically and move CONFIG_SM_TCSRCC_8750 from 'm' to 'y. No. > This will help the UFS partitions to be identified and then the rootfs > to be mounted from the partitions. No, it's completely different problem. Now you are mixing UFS partitions with root= argument. Best regards, Krzysztof