From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gilad Broner" Subject: Re: [PATCH v2 3/4] scsi: ufs: add trace events and dump prints for debug Date: Sun, 22 Feb 2015 14:58:34 -0000 Message-ID: References: <1423576735-26267-1-git-send-email-gbroner@codeaurora.org> <1423576735-26267-4-git-send-email-gbroner@codeaurora.org> <20150212145551.2d234fb1@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:58645 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbbBVO6h (ORCPT ); Sun, 22 Feb 2015 09:58:37 -0500 In-Reply-To: <20150212145551.2d234fb1@gandalf.local.home> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Steven Rostedt Cc: Gilad Broner , james.bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org, ygardi@codeaurora.org, draviv@codeaurora.org, Lee Susman , Sujit Reddy Thumma , Vinayak Holikatti , "James E.J. Bottomley" , Ingo Molnar >> struct ufs_stats { >> +#ifdef CONFIG_DEBUG_FS >> bool enabled; >> u64 **tag_stats; >> int q_depth; >> int err_stats[UFS_ERR_MAX]; >> +#endif > > Can any of the tracepoint code be called that references these when > CONFIG_DEBUG_FS is not set? Because soon (possibly even this merge > window), tracing will no longer depend on DEBUG_FS, because it will > have its own filesystem. Thanks for the update about this dependency. None of these are used for the tracepoints, so I don't expect any problems. Gilad. -- Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project